starred/audiobookshelf
1
0
Fork 0
mirror of https://github.com/advplyr/audiobookshelf.git synced 2026-05-30 23:40:40 +02:00
Code Issues 1.0k Packages Projects Releases 10 Wiki Activity

[PR #2797] [MERGED] Add dir="auto" attribute where RTL display is needed #3807

New Issue
Closed
opened 2026-04-25 00:17:08 +02:00 by adam · 0 comments
adam commented 2026-04-25 00:17:08 +02:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/advplyr/audiobookshelf/pull/2797
Author: @mikiher
Created: 3/28/2024
Status: ✅ Merged
Merged: 3/29/2024
Merged by: @advplyr

Base: master ← Head: rtl-fixes

📝 Commits (1)

  • 3325465 Add dir="auto" attribute where it makes sense

📊 Changes

10 files changed (+12 additions, -12 deletions)

View changed files

📝 client/components/cards/LazyBookCard.vue (+1 -1)
📝 client/components/modals/item/tabs/Episodes.vue (+1 -1)
📝 client/components/modals/podcast/ViewEpisode.vue (+2 -2)
📝 client/components/tables/ChaptersTable.vue (+1 -1)
📝 client/components/tables/podcast/DownloadQueueTable.vue (+1 -1)
📝 client/components/tables/podcast/LazyEpisodeRow.vue (+1 -1)
📝 client/components/ui/TextInput.vue (+1 -1)
📝 client/components/ui/TextareaInput.vue (+1 -1)
📝 client/pages/item/_id/index.vue (+1 -1)
📝 client/pages/library/_library/podcast/latest.vue (+2 -2)

📄 Description

This adds dir="auto" attribute to some text elements, in which it makes sense to modify the display when the text is in a RTL language (e.g. Arabic, Hebrew, Urdu, etc.)

The change has no effect on LTR text. The main visible difference in RTL text is that it is naturally aligned to the right (and there are also some subtler differences in the rendering of mixed text containing both RTL and LTR characters).

Some examples after the change:

In the Latest Episodes page:
Screenshot 2024-03-29 000604

In the Recently Added row on the Homepage:
Screenshot 2024-03-29 000937

You can see in both examples how Hebrew text is right-aligned (as expected), while English text remains as-is.

Note: this is not an attempt at full RTL support for the Hebrew locale (which will likely require more work).

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/advplyr/audiobookshelf/pull/2797 **Author:** [@mikiher](https://github.com/mikiher) **Created:** 3/28/2024 **Status:** ✅ Merged **Merged:** 3/29/2024 **Merged by:** [@advplyr](https://github.com/advplyr) **Base:** `master` ← **Head:** `rtl-fixes` --- ### 📝 Commits (1) - [`3325465`](https://github.com/advplyr/audiobookshelf/commit/33254654d5fbf589eee90861309a5ef2a51d572b) Add dir="auto" attribute where it makes sense ### 📊 Changes **10 files changed** (+12 additions, -12 deletions) <details> <summary>View changed files</summary> 📝 `client/components/cards/LazyBookCard.vue` (+1 -1) 📝 `client/components/modals/item/tabs/Episodes.vue` (+1 -1) 📝 `client/components/modals/podcast/ViewEpisode.vue` (+2 -2) 📝 `client/components/tables/ChaptersTable.vue` (+1 -1) 📝 `client/components/tables/podcast/DownloadQueueTable.vue` (+1 -1) 📝 `client/components/tables/podcast/LazyEpisodeRow.vue` (+1 -1) 📝 `client/components/ui/TextInput.vue` (+1 -1) 📝 `client/components/ui/TextareaInput.vue` (+1 -1) 📝 `client/pages/item/_id/index.vue` (+1 -1) 📝 `client/pages/library/_library/podcast/latest.vue` (+2 -2) </details> ### 📄 Description This adds dir="auto" attribute to some text elements, in which it makes sense to modify the display when the text is in a RTL language (e.g. Arabic, Hebrew, Urdu, etc.) The change has no effect on LTR text. The main visible difference in RTL text is that it is naturally aligned to the right (and there are also some subtler differences in the rendering of mixed text containing both RTL and LTR characters). Some examples after the change: In the Latest Episodes page: <img width="602" alt="Screenshot 2024-03-29 000604" src="https://github.com/advplyr/audiobookshelf/assets/22557398/68cc9f7c-4992-4fd5-a0dc-c39111b4dbea"> In the Recently Added row on the Homepage: <img width="601" alt="Screenshot 2024-03-29 000937" src="https://github.com/advplyr/audiobookshelf/assets/22557398/509b641c-6051-4ef2-8226-ec20620ea1c3"> You can see in both examples how Hebrew text is right-aligned (as expected), while English text remains as-is. *Note*: this is *not* an attempt at full RTL support for the Hebrew locale (which will likely require more work). --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2026-04-25 00:17:08 +02:00
adam closed this issue 2026-04-25 00:17:08 +02:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
authentication
backlog
bug
chapter editor
config-issue
ebooks
encoding/embedding
enhancement
help wanted
listening sessions & progress
planned
possible plugin
progress sync
pull-request
Mirrored from GitHub Pull Request
 sorting/filtering/searching
unable to reproduce
upload
users & permissions
waiting
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam (Adam Melkus)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/audiobookshelf#3807
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?