starred/audiobookshelf
1
0
Fork 0
mirror of https://github.com/advplyr/audiobookshelf.git synced 2026-05-30 23:40:40 +02:00
Code Issues 1.0k Packages Projects Releases 10 Wiki Activity

[PR #2742] [MERGED] Fix broken BinaryManager.isBinaryGood test #3790

New Issue
Closed
opened 2026-04-25 00:17:04 +02:00 by adam · 0 comments
adam commented 2026-04-25 00:17:04 +02:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/advplyr/audiobookshelf/pull/2742
Author: @mikiher
Created: 3/14/2024
Status: ✅ Merged
Merged: 3/14/2024
Merged by: @advplyr

Base: master ← Head: broken-binary-manager-test

📝 Commits (1)

  • f7ae778 Fix broken BinaryManager.isBinaryGood test

📊 Changes

1 file changed (+7 additions, -6 deletions)

View changed files

📝 test/server/managers/BinaryManager.test.js (+7 -6)

📄 Description

For some reason the test was broken.

Not sure how I didn't notice it when I first submitted PR #2554.

I should really add the unit test runs to the PR check flow - will do this in a separate PR.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/advplyr/audiobookshelf/pull/2742 **Author:** [@mikiher](https://github.com/mikiher) **Created:** 3/14/2024 **Status:** ✅ Merged **Merged:** 3/14/2024 **Merged by:** [@advplyr](https://github.com/advplyr) **Base:** `master` ← **Head:** `broken-binary-manager-test` --- ### 📝 Commits (1) - [`f7ae778`](https://github.com/advplyr/audiobookshelf/commit/f7ae7783bd6dfa3d2d2d998a7b05c59c352f3766) Fix broken BinaryManager.isBinaryGood test ### 📊 Changes **1 file changed** (+7 additions, -6 deletions) <details> <summary>View changed files</summary> 📝 `test/server/managers/BinaryManager.test.js` (+7 -6) </details> ### 📄 Description For some reason the test was broken. Not sure how I didn't notice it when I first submitted PR #2554. I should really add the unit test runs to the PR check flow - will do this in a separate PR. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2026-04-25 00:17:04 +02:00
adam closed this issue 2026-04-25 00:17:04 +02:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
authentication
backlog
bug
chapter editor
config-issue
ebooks
encoding/embedding
enhancement
help wanted
listening sessions & progress
planned
possible plugin
progress sync
pull-request
Mirrored from GitHub Pull Request
 sorting/filtering/searching
unable to reproduce
upload
users & permissions
waiting
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam (Adam Melkus)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/audiobookshelf#3790
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?