starred/audiobookshelf
1
0
Fork 0
mirror of https://github.com/advplyr/audiobookshelf.git synced 2026-05-30 23:40:40 +02:00
Code Issues 1.0k Packages Projects Releases 10 Wiki Activity

[PR #2740] [MERGED] Add name labels to login form #3788

New Issue
Closed
opened 2026-04-25 00:17:04 +02:00 by adam · 0 comments
adam commented 2026-04-25 00:17:04 +02:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/advplyr/audiobookshelf/pull/2740
Author: @Schiriki123
Created: 3/14/2024
Status: ✅ Merged
Merged: 3/14/2024
Merged by: @advplyr

Base: master ← Head: master

📝 Commits (1)

  • d6f1351 Add name labels to login form

📊 Changes

2 files changed (+6 additions, -5 deletions)

View changed files

📝 client/components/ui/TextInput.vue (+3 -2)
📝 client/pages/login.vue (+3 -3)

📄 Description

To increase the likelihood for password managers to detect the username field, I added the name attribute to the username input field (and for the password filed too because it cannot hurt).

P.S.: I don't know if this is the right way of implementing this (I never worked with vue.js before).

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/advplyr/audiobookshelf/pull/2740 **Author:** [@Schiriki123](https://github.com/Schiriki123) **Created:** 3/14/2024 **Status:** ✅ Merged **Merged:** 3/14/2024 **Merged by:** [@advplyr](https://github.com/advplyr) **Base:** `master` ← **Head:** `master` --- ### 📝 Commits (1) - [`d6f1351`](https://github.com/advplyr/audiobookshelf/commit/d6f13513aee29ec5d0a1701c68ef81095ee0c9e8) Add name labels to login form ### 📊 Changes **2 files changed** (+6 additions, -5 deletions) <details> <summary>View changed files</summary> 📝 `client/components/ui/TextInput.vue` (+3 -2) 📝 `client/pages/login.vue` (+3 -3) </details> ### 📄 Description To increase the likelihood for password managers to detect the username field, I added the `name` attribute to the username input field (and for the password filed too because it cannot hurt). P.S.: I don't know if this is the right way of implementing this (I never worked with vue.js before). --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2026-04-25 00:17:04 +02:00
adam closed this issue 2026-04-25 00:17:04 +02:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
authentication
backlog
bug
chapter editor
config-issue
ebooks
encoding/embedding
enhancement
help wanted
listening sessions & progress
planned
possible plugin
progress sync
pull-request
Mirrored from GitHub Pull Request
 sorting/filtering/searching
unable to reproduce
upload
users & permissions
waiting
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam (Adam Melkus)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/audiobookshelf#3788
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?