starred/audiobookshelf
1
0
Fork 0
mirror of https://github.com/advplyr/audiobookshelf.git synced 2026-05-30 23:40:40 +02:00
Code Issues 1.0k Packages Projects Releases 10 Wiki Activity

[PR #2737] [MERGED] Add library toggle setting for skipping earlier instalments in Continue Series #3787

New Issue
Closed
opened 2026-04-25 00:17:04 +02:00 by adam · 0 comments
adam commented 2026-04-25 00:17:04 +02:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/advplyr/audiobookshelf/pull/2737
Author: @justcallmelarry
Created: 3/12/2024
Status: ✅ Merged
Merged: 3/14/2024
Merged by: @advplyr

Base: master ← Head: feature/add-toggle-for-skipping-earlier-instalments-in-continue-series

📝 Commits (6)

  • a814e45 add a toggle for the new continue series setting
  • c83399c use the toggle to not show earlier works than the ones already read
  • d4c1bc5 use already fetched library settings, only fetch maxSequence if setting is turned on
  • 65153fa var => let
  • d02fc2d Update continue series skip earlier books query attribute to look for finished books, update wording on help text, map translations
  • 521db90 Update JSDocs, remove unused libraryId replacement

📊 Changes

27 files changed (+98 additions, -18 deletions)

View changed files

📝 client/components/modals/libraries/EditModal.vue (+1 -0)
📝 client/components/modals/libraries/LibrarySettings.vue (+14 -0)
📝 client/strings/cs.json (+2 -0)
📝 client/strings/da.json (+2 -0)
📝 client/strings/de.json (+2 -0)
📝 client/strings/en-us.json (+2 -0)
📝 client/strings/es.json (+2 -0)
📝 client/strings/et.json (+2 -0)
📝 client/strings/fr.json (+3 -1)
📝 client/strings/gu.json (+2 -0)
📝 client/strings/hi.json (+2 -0)
📝 client/strings/hr.json (+2 -0)
📝 client/strings/hu.json (+2 -0)
📝 client/strings/it.json (+2 -0)
📝 client/strings/lt.json (+2 -0)
📝 client/strings/nl.json (+2 -0)
📝 client/strings/no.json (+2 -0)
📝 client/strings/pl.json (+2 -0)
📝 client/strings/pt-br.json (+3 -1)
📝 client/strings/ru.json (+2 -0)

...and 7 more files

📄 Description

Issues

Closes https://github.com/advplyr/audiobookshelf/issues/2687 on merge.

Open questions

  • Are there any linting rules I should make sure I follow?
  • Did I miss running some script for the other translations?
  • Does anyone know of a better name than onlyShowLaterBooksInContinueSeries for the setting variable name?
  • Does anyone have better copy suggestions for the toggle + info text?

Pictures

Picture in library, second book read, third up next (first is unread but not next in continue series) image
Book 2 and 3 read, book 1 still not showing up in Continue Series image
Library settings page image

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/advplyr/audiobookshelf/pull/2737 **Author:** [@justcallmelarry](https://github.com/justcallmelarry) **Created:** 3/12/2024 **Status:** ✅ Merged **Merged:** 3/14/2024 **Merged by:** [@advplyr](https://github.com/advplyr) **Base:** `master` ← **Head:** `feature/add-toggle-for-skipping-earlier-instalments-in-continue-series` --- ### 📝 Commits (6) - [`a814e45`](https://github.com/advplyr/audiobookshelf/commit/a814e4515034a8910d3f755ca76d067a201aeb4e) add a toggle for the new continue series setting - [`c83399c`](https://github.com/advplyr/audiobookshelf/commit/c83399c7b5de67103d508ac2d758e8d4e3d88672) use the toggle to not show earlier works than the ones already read - [`d4c1bc5`](https://github.com/advplyr/audiobookshelf/commit/d4c1bc5dfcfe323706604039088359daad879b1a) use already fetched library settings, only fetch maxSequence if setting is turned on - [`65153fa`](https://github.com/advplyr/audiobookshelf/commit/65153fae9da30a5528380d279cfde1aab4652603) var => let - [`d02fc2d`](https://github.com/advplyr/audiobookshelf/commit/d02fc2debe3ca91c467113d7d03fc7e13bc684fb) Update continue series skip earlier books query attribute to look for finished books, update wording on help text, map translations - [`521db90`](https://github.com/advplyr/audiobookshelf/commit/521db90ae0873efacaf91e88c3f3db98580b80dd) Update JSDocs, remove unused libraryId replacement ### 📊 Changes **27 files changed** (+98 additions, -18 deletions) <details> <summary>View changed files</summary> 📝 `client/components/modals/libraries/EditModal.vue` (+1 -0) 📝 `client/components/modals/libraries/LibrarySettings.vue` (+14 -0) 📝 `client/strings/cs.json` (+2 -0) 📝 `client/strings/da.json` (+2 -0) 📝 `client/strings/de.json` (+2 -0) 📝 `client/strings/en-us.json` (+2 -0) 📝 `client/strings/es.json` (+2 -0) 📝 `client/strings/et.json` (+2 -0) 📝 `client/strings/fr.json` (+3 -1) 📝 `client/strings/gu.json` (+2 -0) 📝 `client/strings/hi.json` (+2 -0) 📝 `client/strings/hr.json` (+2 -0) 📝 `client/strings/hu.json` (+2 -0) 📝 `client/strings/it.json` (+2 -0) 📝 `client/strings/lt.json` (+2 -0) 📝 `client/strings/nl.json` (+2 -0) 📝 `client/strings/no.json` (+2 -0) 📝 `client/strings/pl.json` (+2 -0) 📝 `client/strings/pt-br.json` (+3 -1) 📝 `client/strings/ru.json` (+2 -0) _...and 7 more files_ </details> ### 📄 Description ## Issues Closes https://github.com/advplyr/audiobookshelf/issues/2687 on merge. ## Open questions * Are there any linting rules I should make sure I follow? * Did I miss running some script for the other translations? * Does anyone know of a better name than `onlyShowLaterBooksInContinueSeries` for the setting variable name? * Does anyone have better copy suggestions for the toggle + info text? ## Pictures <details> <summary>Picture in library, second book read, third up next (first is unread but not next in continue series)</summary> <img width="531" alt="image" src="https://github.com/advplyr/audiobookshelf/assets/24991021/6b055588-c7dd-477b-ad8b-961efab4707b"> </details> <details> <summary>Book 2 and 3 read, book 1 still not showing up in Continue Series</summary> <img width="632" alt="image" src="https://github.com/advplyr/audiobookshelf/assets/24991021/389f4965-a313-4a70-858d-774d88b1acc6"> </details> <details> <summary>Library settings page</summary> <img width="802" alt="image" src="https://github.com/advplyr/audiobookshelf/assets/24991021/ae8a21c8-550b-46b3-b207-a68f7af3d44e"> </details> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2026-04-25 00:17:04 +02:00
adam closed this issue 2026-04-25 00:17:04 +02:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
authentication
backlog
bug
chapter editor
config-issue
ebooks
encoding/embedding
enhancement
help wanted
listening sessions & progress
planned
possible plugin
progress sync
pull-request
Mirrored from GitHub Pull Request
 sorting/filtering/searching
unable to reproduce
upload
users & permissions
waiting
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam (Adam Melkus)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/audiobookshelf#3787
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?