starred/audiobookshelf
1
0
Fork 0
mirror of https://github.com/advplyr/audiobookshelf.git synced 2026-05-30 23:40:40 +02:00
Code Issues 1.0k Packages Projects Releases 10 Wiki Activity

[PR #2734] [MERGED] Make series sequence cleanup slighlty less aggressive #3786

New Issue
Closed
opened 2026-04-25 00:17:03 +02:00 by adam · 0 comments
adam commented 2026-04-25 00:17:03 +02:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/advplyr/audiobookshelf/pull/2734
Author: @mikiher
Created: 3/12/2024
Status: ✅ Merged
Merged: 3/14/2024
Merged by: @advplyr

Base: master ← Head: fix-sequence-cleanup

📝 Commits (3)

  • 29e9216 Make series sequence cleanup slighlty less aggressive
  • 8826d3a fix cleanSeriesSequence method to extract first numeric value
  • ae39549 Add tests for cleanSeriesSequence

📊 Changes

2 files changed (+51 additions, -4 deletions)

View changed files

📝 server/providers/Audible.js (+3 -4)
➕ test/server/providers/Audible.test.js (+48 -0)

📄 Description

Fixes #2710.

The fix makes the sequence cleanup a bit less aggressive, so that the sequence number, which translates to: "first-season : 1", does not get trimmed to "first-season".

The fix to #2380 still works.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/advplyr/audiobookshelf/pull/2734 **Author:** [@mikiher](https://github.com/mikiher) **Created:** 3/12/2024 **Status:** ✅ Merged **Merged:** 3/14/2024 **Merged by:** [@advplyr](https://github.com/advplyr) **Base:** `master` ← **Head:** `fix-sequence-cleanup` --- ### 📝 Commits (3) - [`29e9216`](https://github.com/advplyr/audiobookshelf/commit/29e9216bb1a0b0772601438905ac68977febed0a) Make series sequence cleanup slighlty less aggressive - [`8826d3a`](https://github.com/advplyr/audiobookshelf/commit/8826d3af62ec534ca23706a41370a7720cb34963) fix cleanSeriesSequence method to extract first numeric value - [`ae39549`](https://github.com/advplyr/audiobookshelf/commit/ae395497a5da9cbec9940a675d78d1b43bee91fa) Add tests for cleanSeriesSequence ### 📊 Changes **2 files changed** (+51 additions, -4 deletions) <details> <summary>View changed files</summary> 📝 `server/providers/Audible.js` (+3 -4) ➕ `test/server/providers/Audible.test.js` (+48 -0) </details> ### 📄 Description Fixes #2710. The fix makes the sequence cleanup a bit less aggressive, so that the sequence number, which translates to: "first-season : 1", does not get trimmed to "first-season". The fix to #2380 still works. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2026-04-25 00:17:03 +02:00
adam closed this issue 2026-04-25 00:17:03 +02:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
authentication
backlog
bug
chapter editor
config-issue
ebooks
encoding/embedding
enhancement
help wanted
listening sessions & progress
planned
possible plugin
progress sync
pull-request
Mirrored from GitHub Pull Request
 sorting/filtering/searching
unable to reproduce
upload
users & permissions
waiting
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam (Adam Melkus)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/audiobookshelf#3786
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?