starred/audiobookshelf
1
0
Fork 0
mirror of https://github.com/advplyr/audiobookshelf.git synced 2026-05-30 23:40:40 +02:00
Code Issues 1.0k Packages Projects Releases 10 Wiki Activity

[PR #2728] [CLOSED] Automating localization #3782

New Issue
Closed
opened 2026-04-25 00:17:02 +02:00 by adam · 0 comments
adam commented 2026-04-25 00:17:02 +02:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/advplyr/audiobookshelf/pull/2728
Author: @nichwall
Created: 3/11/2024
Status: ❌ Closed

Base: master ← Head: automating_localization

📝 Commits (6)

  • dff1bd4 Added alphabetization integration test workflow
  • 9fa7950 Run script and create branch automatic workflow
  • bc6cb8d Updated automatic name
  • 90e27f9 Added manual i18n workflow
  • 17f22a7 Fixed paths
  • 3100f32 Fix: Manual branch creation dispatch

📊 Changes

3 files changed (+160 additions, -0 deletions)

View changed files

➕ .github/workflows/alphabetization_check.yml (+29 -0)
➕ .github/workflows/i18n-automatic-branch.yml (+68 -0)
➕ .github/workflows/i18n-manual-branch.yml (+63 -0)

📄 Description

This PR includes 3 new workflows:

  • alphabetization_check which performs an integration test to verify that all localization keys are alphabetical for all commits and PRs
  • i18n-automatic-branch which automatically runs the key-copying script on pushes to the main/master branch and opens a branch with the updated files if there were any changes
  • i18n-manual-branch which can be manually triggered

The branch workflows are identical other than the trigger condition to allow for disabling the automatic workflow without removing the ability to run the manual workflow. These two workflows will need write access to be able to create the branch and PR. These also require defining the USER_EMAIL and USER_NAME secrets for the git initialization. These don't necessarily to be secrets, but felt better to do that instead of just including a default value.

These workflows make use of the https://github.com/audiobookshelf/audiobookshelf-i18n-updater GitHub action.

Edit: The action linked above ensures a newline at the end of each i18n file so the last line stops showing up as a change when viewing the diff.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/advplyr/audiobookshelf/pull/2728 **Author:** [@nichwall](https://github.com/nichwall) **Created:** 3/11/2024 **Status:** ❌ Closed **Base:** `master` ← **Head:** `automating_localization` --- ### 📝 Commits (6) - [`dff1bd4`](https://github.com/advplyr/audiobookshelf/commit/dff1bd4e871863da903bb92ccb33e31407ce46a6) Added alphabetization integration test workflow - [`9fa7950`](https://github.com/advplyr/audiobookshelf/commit/9fa7950df358b4f046a3a1fef3b59758821d2d16) Run script and create branch automatic workflow - [`bc6cb8d`](https://github.com/advplyr/audiobookshelf/commit/bc6cb8db4bf0bf07fb4272a5c9b112efcd269c18) Updated automatic name - [`90e27f9`](https://github.com/advplyr/audiobookshelf/commit/90e27f9ed2984255b82016ae5c557414b79e503e) Added manual i18n workflow - [`17f22a7`](https://github.com/advplyr/audiobookshelf/commit/17f22a71975ac49a1f6e4d00f99297a0dd324881) Fixed paths - [`3100f32`](https://github.com/advplyr/audiobookshelf/commit/3100f3261ae7f0614ea43a0fe83b196ef4d76708) Fix: Manual branch creation dispatch ### 📊 Changes **3 files changed** (+160 additions, -0 deletions) <details> <summary>View changed files</summary> ➕ `.github/workflows/alphabetization_check.yml` (+29 -0) ➕ `.github/workflows/i18n-automatic-branch.yml` (+68 -0) ➕ `.github/workflows/i18n-manual-branch.yml` (+63 -0) </details> ### 📄 Description This PR includes 3 new workflows: - `alphabetization_check` which performs an integration test to verify that all localization keys are alphabetical for all commits and PRs - `i18n-automatic-branch` which automatically runs the key-copying script on pushes to the main/master branch and opens a branch with the updated files if there were any changes - `i18n-manual-branch` which can be manually triggered The `branch` workflows are identical other than the trigger condition to allow for disabling the `automatic` workflow without removing the ability to run the `manual` workflow. These two workflows will need write access to be able to create the branch and PR. These also require defining the `USER_EMAIL` and `USER_NAME` secrets for the git initialization. These don't necessarily to be secrets, but felt better to do that instead of just including a default value. These workflows make use of the https://github.com/audiobookshelf/audiobookshelf-i18n-updater GitHub action. Edit: The action linked above ensures a newline at the end of each i18n file so the last line stops showing up as a change when viewing the diff. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2026-04-25 00:17:02 +02:00
adam closed this issue 2026-04-25 00:17:02 +02:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
authentication
backlog
bug
chapter editor
config-issue
ebooks
encoding/embedding
enhancement
help wanted
listening sessions & progress
planned
possible plugin
progress sync
pull-request
Mirrored from GitHub Pull Request
 sorting/filtering/searching
unable to reproduce
upload
users & permissions
waiting
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam (Adam Melkus)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/audiobookshelf#3782
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?