starred/audiobookshelf
1
0
Fork 0
mirror of https://github.com/advplyr/audiobookshelf.git synced 2026-05-30 23:40:40 +02:00
Code Issues 1.0k Packages Projects Releases 10 Wiki Activity

[PR #2724] [MERGED] Fix library filter data direct access #3780

New Issue
Closed
opened 2026-04-25 00:17:02 +02:00 by adam · 0 comments
adam commented 2026-04-25 00:17:02 +02:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/advplyr/audiobookshelf/pull/2724
Author: @mikiher
Created: 3/9/2024
Status: ✅ Merged
Merged: 3/11/2024
Merged by: @advplyr

Base: master ← Head: fix-library-filter-data-access

📝 Commits (4)

  • 0e81480 Fix direct access to Database.libraryFilterData
  • ad45dad Remove redundant space
  • ae0a9bc Merge branch 'advplyr:master' into fix-library-filter-data-access
  • c14f9ac Update functions for #2724 and add jsdocs

📊 Changes

2 files changed (+40 additions, -12 deletions)

View changed files

📝 server/Database.js (+28 -0)
📝 server/scanner/BookScanner.js (+12 -12)

📄 Description

Fixes #2693 (see details in the bug).

Replaces all direct access to Database.libraryFilterData (which caused the crash in the bug) with Database method calls that check if the cached libraryFilterData exists for the given libraryID, and perform a database query if it doesn't exist.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/advplyr/audiobookshelf/pull/2724 **Author:** [@mikiher](https://github.com/mikiher) **Created:** 3/9/2024 **Status:** ✅ Merged **Merged:** 3/11/2024 **Merged by:** [@advplyr](https://github.com/advplyr) **Base:** `master` ← **Head:** `fix-library-filter-data-access` --- ### 📝 Commits (4) - [`0e81480`](https://github.com/advplyr/audiobookshelf/commit/0e8148001e0865996b3b8cd7eb56d15dbcd5e14d) Fix direct access to Database.libraryFilterData - [`ad45dad`](https://github.com/advplyr/audiobookshelf/commit/ad45dadc15ebd881a2e75c127ea9650fe8f30cc2) Remove redundant space - [`ae0a9bc`](https://github.com/advplyr/audiobookshelf/commit/ae0a9bcf863ba9367a26fe982bba7a005b7e6787) Merge branch 'advplyr:master' into fix-library-filter-data-access - [`c14f9ac`](https://github.com/advplyr/audiobookshelf/commit/c14f9accafcc688d178f66c795826d6b8ea3b159) Update functions for #2724 and add jsdocs ### 📊 Changes **2 files changed** (+40 additions, -12 deletions) <details> <summary>View changed files</summary> 📝 `server/Database.js` (+28 -0) 📝 `server/scanner/BookScanner.js` (+12 -12) </details> ### 📄 Description Fixes #2693 (see details in the bug). Replaces all direct access to Database.libraryFilterData (which caused the crash in the bug) with Database method calls that check if the cached libraryFilterData exists for the given libraryID, and perform a database query if it doesn't exist. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2026-04-25 00:17:02 +02:00
adam closed this issue 2026-04-25 00:17:02 +02:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
authentication
backlog
bug
chapter editor
config-issue
ebooks
encoding/embedding
enhancement
help wanted
listening sessions & progress
planned
possible plugin
progress sync
pull-request
Mirrored from GitHub Pull Request
 sorting/filtering/searching
unable to reproduce
upload
users & permissions
waiting
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam (Adam Melkus)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/audiobookshelf#3780
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?