starred/audiobookshelf
1
0
Fork 0
mirror of https://github.com/advplyr/audiobookshelf.git synced 2026-05-30 23:40:40 +02:00
Code Issues 1.0k Packages Projects Releases 10 Wiki Activity

[PR #2666] [CLOSED] fix: http_proxy is not supported. #3765

New Issue
Closed
opened 2026-04-25 00:16:58 +02:00 by adam · 0 comments
adam commented 2026-04-25 00:16:58 +02:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/advplyr/audiobookshelf/pull/2666
Author: @zhzy0077
Created: 2/26/2024
Status: ❌ Closed

Base: master ← Head: patch

📝 Commits (2)

  • 0669338 fix: http_proxy is not supported.
  • 0319709 Remove unnecessary DISABLE_SSRF variable

📊 Changes

5 files changed (+19 additions, -12 deletions)

View changed files

📝 package-lock.json (+13 -7)
📝 package.json (+1 -1)
📝 server/Server.js (+1 -0)
📝 server/utils/fileUtils.js (+2 -2)
📝 server/utils/podcastUtils.js (+2 -2)

📄 Description

fixes #1313

Problem:
As stated in #1313, the http_proxy doesn't work for abs. Reasons are:

Changes:

  1. SSRF is necessary for public-exposing apps - while unnecessary for internal use. Make it can be disabled by env var DISABLE_SSRF and we can bring it back to enable for all when the issue aforementioned is fixed.
  2. Upgrade axios to the latest version.

Tests:
Manually tested mainline scenarios and no issue is found.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/advplyr/audiobookshelf/pull/2666 **Author:** [@zhzy0077](https://github.com/zhzy0077) **Created:** 2/26/2024 **Status:** ❌ Closed **Base:** `master` ← **Head:** `patch` --- ### 📝 Commits (2) - [`0669338`](https://github.com/advplyr/audiobookshelf/commit/0669338ede7763897848ba2c5f90346a69581bba) fix: http_proxy is not supported. - [`0319709`](https://github.com/advplyr/audiobookshelf/commit/03197092eba0ddf083420a63d1d5dea8c9c5e16b) Remove unnecessary DISABLE_SSRF variable ### 📊 Changes **5 files changed** (+19 additions, -12 deletions) <details> <summary>View changed files</summary> 📝 `package-lock.json` (+13 -7) 📝 `package.json` (+1 -1) 📝 `server/Server.js` (+1 -0) 📝 `server/utils/fileUtils.js` (+2 -2) 📝 `server/utils/podcastUtils.js` (+2 -2) </details> ### 📄 Description fixes #1313 **Problem:** As stated in #1313, the http_proxy doesn't work for abs. Reasons are: - ssrf-req-filter issue: <a href="https://github.com/y-mehta/ssrf-req-filter/issues/42">[HTTP Proxy is not well supported in HTTPS connection. · Issue #42 · y-mehta/ssrf-req-filter](https://github.com/y-mehta/ssrf-req-filter/issues/42)</a> - axios issue: fixed 1.x version. version bisect says the fix is between 0.27.2 and 1.0.0. Changes are too much in middle. **Changes:** 1. SSRF is necessary for public-exposing apps - while unnecessary for internal use. Make it can be disabled by env var DISABLE_SSRF and we can bring it back to enable for all when the issue aforementioned is fixed. 2. Upgrade `axios` to the latest version. **Tests:** Manually tested mainline scenarios and no issue is found. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2026-04-25 00:16:58 +02:00
adam closed this issue 2026-04-25 00:16:58 +02:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
authentication
backlog
bug
chapter editor
config-issue
ebooks
encoding/embedding
enhancement
help wanted
listening sessions & progress
planned
possible plugin
progress sync
pull-request
Mirrored from GitHub Pull Request
 sorting/filtering/searching
unable to reproduce
upload
users & permissions
waiting
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam (Adam Melkus)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/audiobookshelf#3765
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?