starred/audiobookshelf
1
0
Fork 0
mirror of https://github.com/advplyr/audiobookshelf.git synced 2026-05-30 23:40:40 +02:00
Code Issues 1.0k Packages Projects Releases 10 Wiki Activity

[PR #2643] [CLOSED] feat(i18n): add missing localizations #3757

New Issue
Closed
opened 2026-04-25 00:16:56 +02:00 by adam · 0 comments
adam commented 2026-04-25 00:16:56 +02:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/advplyr/audiobookshelf/pull/2643
Author: @megamegax
Created: 2/22/2024
Status: ❌ Closed

Base: master ← Head: localization

📝 Commits (2)

  • ec29c9a feat(i18n): add missing localizations
  • 49a4789 Merge branch 'advplyr:master' into localization

📊 Changes

26 files changed (+253 additions, -25 deletions)

View changed files

📝 client/components/app/BookShelfCategorized.vue (+5 -5)
📝 client/components/tables/AudioTracksTableRow.vue (+2 -2)
📝 client/components/tables/EbookFilesTableRow.vue (+2 -2)
📝 client/components/tables/LibraryFilesTableRow.vue (+2 -2)
📝 client/pages/config/authentication.vue (+2 -2)
📝 client/pages/config/index.vue (+9 -9)
📝 client/pages/config/rss-feeds.vue (+1 -1)
📝 client/strings/cs.json (+12 -0)
📝 client/strings/da.json (+12 -0)
📝 client/strings/de.json (+12 -0)
📝 client/strings/en-us.json (+12 -0)
📝 client/strings/es.json (+12 -0)
📝 client/strings/fr.json (+12 -0)
📝 client/strings/gu.json (+12 -0)
📝 client/strings/hi.json (+12 -0)
📝 client/strings/hr.json (+12 -0)
📝 client/strings/hu.json (+14 -2)
📝 client/strings/it.json (+12 -0)
📝 client/strings/lt.json (+12 -0)
📝 client/strings/nl.json (+12 -0)

...and 6 more files

📄 Description

I've noticed, that there are a lot of hardcoded strings in the project. I've started to extract them into localized strings as that is something anyone can do and benefits everyone at the end :)

This is the first batch, I plan to do it in small chunks a few files a time.

May I ask wether filling the existing localization jsons with the new strings is necessary or I can just skip that step in the future?

Also, do you approve the initiation or should I just leave it?

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/advplyr/audiobookshelf/pull/2643 **Author:** [@megamegax](https://github.com/megamegax) **Created:** 2/22/2024 **Status:** ❌ Closed **Base:** `master` ← **Head:** `localization` --- ### 📝 Commits (2) - [`ec29c9a`](https://github.com/advplyr/audiobookshelf/commit/ec29c9a3b083eeea221a36c4d5c266e6f2feef08) feat(i18n): add missing localizations - [`49a4789`](https://github.com/advplyr/audiobookshelf/commit/49a4789d6e00151843b58a5cc38d14cd1e28c621) Merge branch 'advplyr:master' into localization ### 📊 Changes **26 files changed** (+253 additions, -25 deletions) <details> <summary>View changed files</summary> 📝 `client/components/app/BookShelfCategorized.vue` (+5 -5) 📝 `client/components/tables/AudioTracksTableRow.vue` (+2 -2) 📝 `client/components/tables/EbookFilesTableRow.vue` (+2 -2) 📝 `client/components/tables/LibraryFilesTableRow.vue` (+2 -2) 📝 `client/pages/config/authentication.vue` (+2 -2) 📝 `client/pages/config/index.vue` (+9 -9) 📝 `client/pages/config/rss-feeds.vue` (+1 -1) 📝 `client/strings/cs.json` (+12 -0) 📝 `client/strings/da.json` (+12 -0) 📝 `client/strings/de.json` (+12 -0) 📝 `client/strings/en-us.json` (+12 -0) 📝 `client/strings/es.json` (+12 -0) 📝 `client/strings/fr.json` (+12 -0) 📝 `client/strings/gu.json` (+12 -0) 📝 `client/strings/hi.json` (+12 -0) 📝 `client/strings/hr.json` (+12 -0) 📝 `client/strings/hu.json` (+14 -2) 📝 `client/strings/it.json` (+12 -0) 📝 `client/strings/lt.json` (+12 -0) 📝 `client/strings/nl.json` (+12 -0) _...and 6 more files_ </details> ### 📄 Description I've noticed, that there are a lot of hardcoded strings in the project. I've started to extract them into localized strings as that is something anyone can do and benefits everyone at the end :) This is the first batch, I plan to do it in small chunks a few files a time. May I ask wether filling the existing localization jsons with the new strings is necessary or I can just skip that step in the future? Also, do you approve the initiation or should I just leave it? --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2026-04-25 00:16:56 +02:00
adam closed this issue 2026-04-25 00:16:56 +02:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
authentication
backlog
bug
chapter editor
config-issue
ebooks
encoding/embedding
enhancement
help wanted
listening sessions & progress
planned
possible plugin
progress sync
pull-request
Mirrored from GitHub Pull Request
 sorting/filtering/searching
unable to reproduce
upload
users & permissions
waiting
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam (Adam Melkus)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/audiobookshelf#3757
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?