starred/audiobookshelf
1
0
Fork 0
mirror of https://github.com/advplyr/audiobookshelf.git synced 2026-05-30 23:40:40 +02:00
Code Issues 1.0k Packages Projects Releases 10 Wiki Activity

[PR #2554] [MERGED] Modify BinaryManager to download version 6.1 #3733

New Issue
Closed
opened 2026-04-25 00:16:51 +02:00 by adam · 0 comments
adam commented 2026-04-25 00:16:51 +02:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/advplyr/audiobookshelf/pull/2554
Author: @mikiher
Created: 1/25/2024
Status: ✅ Merged
Merged: 2/18/2024
Merged by: @advplyr

Base: master ← Head: ffmpeg-latest

📝 Commits (3)

  • d43a110 Modify BinaryManager to download version 6.1 and remove old dowloaded versions
  • a119b05 Merge branch 'master' into ffmpeg-latest
  • d9e7f5d Update BinaryManager JSDocs, move validVersions to required binary objects

📊 Changes

3 files changed (+257 additions, -60 deletions)

View changed files

📝 server/managers/BinaryManager.js (+93 -14)
📝 server/utils/fileUtils.js (+3 -2)
📝 test/server/managers/BinaryManager.test.js (+161 -44)

📄 Description

This fixes this issue on audiobookself-windows

TLDR, the Windows native server requires at at least version 5.1 of ffmpeg/ffprobe, as older versions do not support Windows long paths. This seems like a necessary upgrade, since it might cause all sorts of unexpected problems.

Some more details:

  • BinaryManager now downloads the latest ffmpeg and ffprobe versions (6.1) from the ffbinaries repository, instead of version 4.4.1 (which is still set as the 'latest' version on ffbinaries)
  • Added a version check to make sure existing versions of the binaries are at least 5.1
  • Added removal of old installed binaries (only ones that were installed by audiobookshelf)
  • Updated tests
  • Fixed a bug in fileUtils.isWritable()

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/advplyr/audiobookshelf/pull/2554 **Author:** [@mikiher](https://github.com/mikiher) **Created:** 1/25/2024 **Status:** ✅ Merged **Merged:** 2/18/2024 **Merged by:** [@advplyr](https://github.com/advplyr) **Base:** `master` ← **Head:** `ffmpeg-latest` --- ### 📝 Commits (3) - [`d43a110`](https://github.com/advplyr/audiobookshelf/commit/d43a1109c82bad451d9e4df9f4eef103e3ed60b2) Modify BinaryManager to download version 6.1 and remove old dowloaded versions - [`a119b05`](https://github.com/advplyr/audiobookshelf/commit/a119b05d85aceee6dac60ee8d6f35ee16a4df610) Merge branch 'master' into ffmpeg-latest - [`d9e7f5d`](https://github.com/advplyr/audiobookshelf/commit/d9e7f5d1333fb9abd39d9b368e2236bf716c0acd) Update BinaryManager JSDocs, move validVersions to required binary objects ### 📊 Changes **3 files changed** (+257 additions, -60 deletions) <details> <summary>View changed files</summary> 📝 `server/managers/BinaryManager.js` (+93 -14) 📝 `server/utils/fileUtils.js` (+3 -2) 📝 `test/server/managers/BinaryManager.test.js` (+161 -44) </details> ### 📄 Description This fixes [this issue](https://github.com/mikiher/audiobookshelf-windows/issues/5) on audiobookself-windows TLDR, the Windows native server requires at at least version 5.1 of ffmpeg/ffprobe, as older versions do not support Windows long paths. This seems like a necessary upgrade, since it might cause all sorts of unexpected problems. Some more details: - BinaryManager now downloads the latest ffmpeg and ffprobe versions (6.1) from the ffbinaries repository, instead of version 4.4.1 (which is still set as the 'latest' version on ffbinaries) - Added a version check to make sure existing versions of the binaries are at least 5.1 - Added removal of old installed binaries (only ones that were installed by audiobookshelf) - Updated tests - Fixed a bug in fileUtils.isWritable() --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2026-04-25 00:16:51 +02:00
adam closed this issue 2026-04-25 00:16:51 +02:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
authentication
backlog
bug
chapter editor
config-issue
ebooks
encoding/embedding
enhancement
help wanted
listening sessions & progress
planned
possible plugin
progress sync
pull-request
Mirrored from GitHub Pull Request
 sorting/filtering/searching
unable to reproduce
upload
users & permissions
waiting
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam (Adam Melkus)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/audiobookshelf#3733
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?