starred/audiobookshelf
1
0
Fork 0
mirror of https://github.com/advplyr/audiobookshelf.git synced 2026-05-30 23:40:40 +02:00
Code Issues 1.0k Packages Projects Releases 10 Wiki Activity

[PR #2506] [MERGED] Change Logger.dev calls to Logger.debug #3730

New Issue
Closed
opened 2026-04-25 00:16:50 +02:00 by adam · 0 comments
adam commented 2026-04-25 00:16:50 +02:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/advplyr/audiobookshelf/pull/2506
Author: @FreedomBen
Created: 1/9/2024
Status: ✅ Merged
Merged: 1/9/2024
Merged by: @advplyr

Base: master ← Head: remove-dev-logs

📝 Commits (1)

  • 4a76059 Change Logger.dev calls to Logger.debug

📊 Changes

4 files changed (+21 additions, -31 deletions)

View changed files

📝 server/Database.js (+2 -2)
📝 server/Logger.js (+0 -10)
📝 server/models/Library.js (+1 -1)
📝 server/models/LibraryItem.js (+18 -18)

📄 Description

Change Logger.dev calls to Logger.debug

Logger.dev is kind of in a weird spot where it doesn't fit into the
standard log level. It is called directly by some code and it only
checks whether a property is set (which comes from an env var) before
deciding to print out.

This standardizes on debug by changing the dev calls to debug. Also
removes the now unused code.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/advplyr/audiobookshelf/pull/2506 **Author:** [@FreedomBen](https://github.com/FreedomBen) **Created:** 1/9/2024 **Status:** ✅ Merged **Merged:** 1/9/2024 **Merged by:** [@advplyr](https://github.com/advplyr) **Base:** `master` ← **Head:** `remove-dev-logs` --- ### 📝 Commits (1) - [`4a76059`](https://github.com/advplyr/audiobookshelf/commit/4a76059608651ce219dc9e18d41cb11f879008b4) Change `Logger.dev` calls to `Logger.debug` ### 📊 Changes **4 files changed** (+21 additions, -31 deletions) <details> <summary>View changed files</summary> 📝 `server/Database.js` (+2 -2) 📝 `server/Logger.js` (+0 -10) 📝 `server/models/Library.js` (+1 -1) 📝 `server/models/LibraryItem.js` (+18 -18) </details> ### 📄 Description Change `Logger.dev` calls to `Logger.debug` `Logger.dev` is kind of in a weird spot where it doesn't fit into the standard log level. It is called directly by some code and it only checks whether a property is set (which comes from an env var) before deciding to print out. This standardizes on `debug` by changing the dev calls to debug. Also removes the now unused code. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2026-04-25 00:16:50 +02:00
adam closed this issue 2026-04-25 00:16:50 +02:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
authentication
backlog
bug
chapter editor
config-issue
ebooks
encoding/embedding
enhancement
help wanted
listening sessions & progress
planned
possible plugin
progress sync
pull-request
Mirrored from GitHub Pull Request
 sorting/filtering/searching
unable to reproduce
upload
users & permissions
waiting
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam (Adam Melkus)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/audiobookshelf#3730
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?