starred/audiobookshelf
1
0
Fork 0
mirror of https://github.com/advplyr/audiobookshelf.git synced 2026-05-30 23:40:40 +02:00
Code Issues 1.0k Packages Projects Releases 10 Wiki Activity

[PR #2291] [MERGED] Hide collection duration if 0 #3690

New Issue
Closed
opened 2026-04-25 00:16:40 +02:00 by adam · 0 comments
adam commented 2026-04-25 00:16:40 +02:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/advplyr/audiobookshelf/pull/2291
Author: @brianjaustin
Created: 11/6/2023
Status: ✅ Merged
Merged: 11/6/2023
Merged by: @advplyr

Base: master ← Head: fix/collection-duration

📝 Commits (2)

  • 0344e8c Hide collection duration if 0
  • aad6402 Update client/components/tables/collection/BookTableRow.vue

📊 Changes

1 file changed (+1 additions, -1 deletions)

View changed files

📝 client/components/tables/collection/BookTableRow.vue (+1 -1)

📄 Description

This fixes #2278 by hiding the duration of a book in a collection if it is 0 (or less). I suppose some audiobooks could also have a duration of 0, but this seems rare (and perhaps hiding the duration in those cases also makes sense?). I opted not to go with progress as that would result in the value having different meanings depending on the media type, which sounds like a potentially confusing user experience.

While this fixes the reported bug, I wonder if it makes sense to have page count as the "duration". Although that would require more effort to implement I think.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/advplyr/audiobookshelf/pull/2291 **Author:** [@brianjaustin](https://github.com/brianjaustin) **Created:** 11/6/2023 **Status:** ✅ Merged **Merged:** 11/6/2023 **Merged by:** [@advplyr](https://github.com/advplyr) **Base:** `master` ← **Head:** `fix/collection-duration` --- ### 📝 Commits (2) - [`0344e8c`](https://github.com/advplyr/audiobookshelf/commit/0344e8cf1b90eab6411cbea32d7b3c03c61ef011) Hide collection duration if 0 - [`aad6402`](https://github.com/advplyr/audiobookshelf/commit/aad6402fdbfd2df3df524b17aefc2df34c089cb6) Update client/components/tables/collection/BookTableRow.vue ### 📊 Changes **1 file changed** (+1 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `client/components/tables/collection/BookTableRow.vue` (+1 -1) </details> ### 📄 Description This fixes #2278 by hiding the duration of a book in a collection if it is 0 (or less). I suppose some audiobooks could also have a duration of 0, but this seems rare (and perhaps hiding the duration in those cases also makes sense?). I opted not to go with progress as that would result in the value having different meanings depending on the media type, which sounds like a potentially confusing user experience. While this fixes the reported bug, I wonder if it makes sense to have page count as the "duration". Although that would require more effort to implement I think. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2026-04-25 00:16:40 +02:00
adam closed this issue 2026-04-25 00:16:40 +02:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
authentication
backlog
bug
chapter editor
config-issue
ebooks
encoding/embedding
enhancement
help wanted
listening sessions & progress
planned
possible plugin
progress sync
pull-request
Mirrored from GitHub Pull Request
 sorting/filtering/searching
unable to reproduce
upload
users & permissions
waiting
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam (Adam Melkus)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/audiobookshelf#3690
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?