starred/audiobookshelf
1
0
Fork 0
mirror of https://github.com/advplyr/audiobookshelf.git synced 2026-05-30 23:40:40 +02:00
Code Issues 1.0k Packages Projects Releases 10 Wiki Activity

[PR #2272] [MERGED] Add support for the old Apple Podcasts iOS app #3684

New Issue
Closed
opened 2026-04-25 00:16:38 +02:00 by adam · 0 comments
adam commented 2026-04-25 00:16:38 +02:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/advplyr/audiobookshelf/pull/2272
Author: @clement-dufour
Created: 11/1/2023
Status: ✅ Merged
Merged: 11/1/2023
Merged by: @advplyr

Base: master ← Head: master

📝 Commits (2)

  • 3c21e9d Update:Simpler content URL in RSS feeds
  • 1ae2089 Update:Add cover file extension in RSS feeds

📊 Changes

3 files changed (+25 additions, -9 deletions)

View changed files

📝 server/Server.js (+1 -1)
📝 server/objects/Feed.js (+19 -6)
📝 server/objects/FeedEpisode.js (+5 -2)

📄 Description

Following my enhancement request to add support for an old version (1.2.3) of the Apple Podcasts iOS app, I found that the RSS feed needed:

  1. the artwork URL to include the file extension;
  2. the audio file URL not to contain any non-ASCII character and to include the file extension.

With this patch:

  1. The artwork URL on the RSS feed now includes the artwork file extension.
  2. The content URL does not contain anymore the full filename (/feed/${slug}/item/${episode.id}/${episode.audioFile.metadata.filename}) but is now generic keeping a correct file extension (/feed/${slug}/item/${episode.id}/media${contentFileExtension}).

Feel free to comment or suggest any prettier code, I digged recently into this project.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/advplyr/audiobookshelf/pull/2272 **Author:** [@clement-dufour](https://github.com/clement-dufour) **Created:** 11/1/2023 **Status:** ✅ Merged **Merged:** 11/1/2023 **Merged by:** [@advplyr](https://github.com/advplyr) **Base:** `master` ← **Head:** `master` --- ### 📝 Commits (2) - [`3c21e9d`](https://github.com/advplyr/audiobookshelf/commit/3c21e9d4135f3e9f7cd0b111776c2d65a2455035) Update:Simpler content URL in RSS feeds - [`1ae2089`](https://github.com/advplyr/audiobookshelf/commit/1ae20892536ee467bfe146eabfa3629fd7b37b41) Update:Add cover file extension in RSS feeds ### 📊 Changes **3 files changed** (+25 additions, -9 deletions) <details> <summary>View changed files</summary> 📝 `server/Server.js` (+1 -1) 📝 `server/objects/Feed.js` (+19 -6) 📝 `server/objects/FeedEpisode.js` (+5 -2) </details> ### 📄 Description Following my [enhancement request](https://github.com/advplyr/audiobookshelf/issues/2263) to add support for an old version (1.2.3) of the Apple Podcasts iOS app, I found that the RSS feed needed: 1. the artwork URL to include the file extension; 2. the audio file URL not to contain any non-ASCII character and to include the file extension. With this patch: 1. The artwork URL on the RSS feed now includes the artwork file extension. 2. The content URL does not contain anymore the full filename (`/feed/${slug}/item/${episode.id}/${episode.audioFile.metadata.filename}`) but is now generic keeping a correct file extension (`/feed/${slug}/item/${episode.id}/media${contentFileExtension}`). Feel free to comment or suggest any prettier code, I digged recently into this project. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2026-04-25 00:16:38 +02:00
adam closed this issue 2026-04-25 00:16:38 +02:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
authentication
backlog
bug
chapter editor
config-issue
ebooks
encoding/embedding
enhancement
help wanted
listening sessions & progress
planned
possible plugin
progress sync
pull-request
Mirrored from GitHub Pull Request
 sorting/filtering/searching
unable to reproduce
upload
users & permissions
waiting
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam (Adam Melkus)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/audiobookshelf#3684
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?