starred/audiobookshelf
1
0
Fork 0
mirror of https://github.com/advplyr/audiobookshelf.git synced 2026-05-30 23:40:40 +02:00
Code Issues 1.0k Packages Projects Releases 10 Wiki Activity

[PR #1994] [MERGED] Fix: server crash when uploading invalid backup file #3639

New Issue
Closed
opened 2026-04-25 00:16:28 +02:00 by adam · 0 comments
adam commented 2026-04-25 00:16:28 +02:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/advplyr/audiobookshelf/pull/1994
Author: @NiclasHaderer
Created: 8/6/2023
Status: ✅ Merged
Merged: 8/8/2023
Merged by: @advplyr

Base: master ← Head: fix-backup-server-crash

📝 Commits (2)

  • 409c5f7 fix: the server does not crash any more when an invalid backup file is uploaded
  • 43a5296 Update server/managers/BackupManager.js

📊 Changes

2 files changed (+12 additions, -4 deletions)

View changed files

📝 .gitignore (+1 -0)
📝 server/managers/BackupManager.js (+11 -4)

📄 Description

If the backup file is not a valid .zip file, or the .zip file is corrupted the server crashes.
This catches the error and returns an error description to the user

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/advplyr/audiobookshelf/pull/1994 **Author:** [@NiclasHaderer](https://github.com/NiclasHaderer) **Created:** 8/6/2023 **Status:** ✅ Merged **Merged:** 8/8/2023 **Merged by:** [@advplyr](https://github.com/advplyr) **Base:** `master` ← **Head:** `fix-backup-server-crash` --- ### 📝 Commits (2) - [`409c5f7`](https://github.com/advplyr/audiobookshelf/commit/409c5f7b75b0ed2f7c798a873b1e7661b41d4e8c) fix: the server does not crash any more when an invalid backup file is uploaded - [`43a5296`](https://github.com/advplyr/audiobookshelf/commit/43a5296dd75aac412788d1272e69bcc5ff058da5) Update server/managers/BackupManager.js ### 📊 Changes **2 files changed** (+12 additions, -4 deletions) <details> <summary>View changed files</summary> 📝 `.gitignore` (+1 -0) 📝 `server/managers/BackupManager.js` (+11 -4) </details> ### 📄 Description If the backup file is not a valid .zip file, or the .zip file is corrupted the server crashes. This catches the error and returns an error description to the user --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2026-04-25 00:16:28 +02:00
adam closed this issue 2026-04-25 00:16:28 +02:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
authentication
backlog
bug
chapter editor
config-issue
ebooks
encoding/embedding
enhancement
help wanted
listening sessions & progress
planned
possible plugin
progress sync
pull-request
Mirrored from GitHub Pull Request
 sorting/filtering/searching
unable to reproduce
upload
users & permissions
waiting
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam (Adam Melkus)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/audiobookshelf#3639
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?