starred/audiobookshelf
1
0
Fork 0
mirror of https://github.com/advplyr/audiobookshelf.git synced 2026-05-30 23:40:40 +02:00
Code Issues 1.0k Packages Projects Releases 10 Wiki Activity

[PR #1946] [MERGED] Fix byte conversion #3636

New Issue
Closed
opened 2026-04-25 00:16:27 +02:00 by adam · 0 comments
adam commented 2026-04-25 00:16:27 +02:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/advplyr/audiobookshelf/pull/1946
Author: @rasmuslos
Created: 7/20/2023
Status: ✅ Merged
Merged: 7/20/2023
Merged by: @advplyr

Base: master ← Head: master

📝 Commits (1)

📊 Changes

1 file changed (+2 additions, -2 deletions)

View changed files

📝 server/utils/fileUtils.js (+2 -2)

📄 Description

Right now ABS converts 206291193b into 196.73MB. This is only partially correct, because the bytes are converted using a factor of 1024. The correct amount would be 206.29MB The are converted to Mebibyte not Megabytes. I got confused by it, because if was wondering why my file size did not match with the one I uploaded. Changing the factor to 1000 fixes this. The unit could also be renamed to MiB but I think this would only confuse most people.

Bildschirmfoto 2023-07-20 um 00 00 38 Bildschirmfoto 2023-07-20 um 00 00 56 Bildschirmfoto 2023-07-20 um 00 02 49 Bildschirmfoto 2023-07-20 um 00 02 11

And yes linux used Mebibyte here, but they do it throughout the entire system. My supposed 5TB Hard drive shows up as a 4.5TB one, because it is only technically 5TB large. Actually it has only 4.5TiB of usable space. But I think this is trivial, as most people probably don't use the linux command line to find out what the size of a file is.

Bildschirmfoto 2023-07-20 um 00 11 06

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/advplyr/audiobookshelf/pull/1946 **Author:** [@rasmuslos](https://github.com/rasmuslos) **Created:** 7/20/2023 **Status:** ✅ Merged **Merged:** 7/20/2023 **Merged by:** [@advplyr](https://github.com/advplyr) **Base:** `master` ← **Head:** `master` --- ### 📝 Commits (1) - [`38596d0`](https://github.com/advplyr/audiobookshelf/commit/38596d017f842ba64dd1cfef64ce9623ea04cd36) Fix byte conversion ### 📊 Changes **1 file changed** (+2 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `server/utils/fileUtils.js` (+2 -2) </details> ### 📄 Description Right now ABS converts `206291193b` into `196.73MB`. This is only partially correct, because the bytes are converted using a factor of 1024. The correct amount would be `206.29MB` The are converted to [Mebibyte](https://en.wikipedia.org/wiki/Byte#Multiple-byte_units) not Megabytes. I got confused by it, because if was wondering why my file size did not match with the one I uploaded. Changing the factor to 1000 fixes this. The unit could also be renamed to `MiB` but I think this would only confuse most people. <img width="682" alt="Bildschirmfoto 2023-07-20 um 00 00 38" src="https://github.com/advplyr/audiobookshelf/assets/49640416/d4d8ae61-c28f-4a01-a93d-9eb5548e6bb3"> <img width="680" alt="Bildschirmfoto 2023-07-20 um 00 00 56" src="https://github.com/advplyr/audiobookshelf/assets/49640416/224e8f3c-dfff-4cc1-a7e8-b8a659897e16"> <img width="877" alt="Bildschirmfoto 2023-07-20 um 00 02 49" src="https://github.com/advplyr/audiobookshelf/assets/49640416/ce5da7cf-8739-4e4e-acb3-a4c43851f799"> <img width="1186" alt="Bildschirmfoto 2023-07-20 um 00 02 11" src="https://github.com/advplyr/audiobookshelf/assets/49640416/1f9c925f-080b-49ac-a5d6-f254e4c5bfc7"> And yes linux used Mebibyte here, but they do it throughout the entire system. My supposed 5TB Hard drive shows up as a 4.5TB one, because it is only technically 5TB large. Actually it has only 4.5TiB of usable space. But I think this is trivial, as most people probably don't use the linux command line to find out what the size of a file is. <img width="520" alt="Bildschirmfoto 2023-07-20 um 00 11 06" src="https://github.com/advplyr/audiobookshelf/assets/49640416/17828c78-3412-4bd5-8767-d933078a6ab1"> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2026-04-25 00:16:27 +02:00
adam closed this issue 2026-04-25 00:16:27 +02:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
authentication
backlog
bug
chapter editor
config-issue
ebooks
encoding/embedding
enhancement
help wanted
listening sessions & progress
planned
possible plugin
progress sync
pull-request
Mirrored from GitHub Pull Request
 sorting/filtering/searching
unable to reproduce
upload
users & permissions
waiting
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam (Adam Melkus)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/audiobookshelf#3636
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?