starred/audiobookshelf
1
0
Fork 0
mirror of https://github.com/advplyr/audiobookshelf.git synced 2026-05-30 23:40:40 +02:00
Code Issues 1.0k Packages Projects Releases 10 Wiki Activity

[PR #1724] [CLOSED] Fix: apply base path to client and websocket #3607

New Issue
Closed
opened 2026-04-25 00:16:20 +02:00 by adam · 0 comments
adam commented 2026-04-25 00:16:20 +02:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/advplyr/audiobookshelf/pull/1724
Author: @1nVitr0
Created: 4/25/2023
Status: ❌ Closed

Base: master ← Head: master

📝 Commits (5)

  • 97e8d4f Fix: apply base path to client and websocket
  • 29d1f75 Update bookshelf texture image path, update glob
  • e39a2bf Merge branch 'master' into 1nVitr0/master
  • 9f6d70e Fix: apply base path workerUrls
  • e50b78e Style: simplify base path normalization

📊 Changes

7 files changed (+550 additions, -10 deletions)

View changed files

📝 client/assets/app.css (+1 -1)
📝 client/layouts/default.vue (+1 -0)
📝 client/plugins/axios.js (+4 -0)
📝 package-lock.json (+483 -5)
📝 package.json (+2 -1)
📝 server/Server.js (+57 -1)
📝 server/SocketAuthority.js (+2 -2)

📄 Description

Adresses #385

Although in my tests this seems to work reliably, this is at best a temporary solution. As discussed in #385, this should be replaced by a long-term solution, such as running nuxt programatically or as it's own thread and proxying requests to it.

Feel free to absolutely obliterate it, or keep this open until the long-term solution is finished. I think we should decide on a direction before I begin tackling that one.

Also, this was done outside the development container (Node 16.20, Ubuntu 22.04), so you might want to look over the lockfile.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/advplyr/audiobookshelf/pull/1724 **Author:** [@1nVitr0](https://github.com/1nVitr0) **Created:** 4/25/2023 **Status:** ❌ Closed **Base:** `master` ← **Head:** `master` --- ### 📝 Commits (5) - [`97e8d4f`](https://github.com/advplyr/audiobookshelf/commit/97e8d4f5c059be6345f9e9d42f4bcc02beed2310) Fix: apply base path to client and websocket - [`29d1f75`](https://github.com/advplyr/audiobookshelf/commit/29d1f75f5c055479f6ae115f08f718a406535c6e) Update bookshelf texture image path, update glob - [`e39a2bf`](https://github.com/advplyr/audiobookshelf/commit/e39a2bf1a38f0d8d5168b632fcdffdfe6e4eeee2) Merge branch 'master' into 1nVitr0/master - [`9f6d70e`](https://github.com/advplyr/audiobookshelf/commit/9f6d70e130754fee52464a85646fb8d2dcffa41b) Fix: apply base path workerUrls - [`e50b78e`](https://github.com/advplyr/audiobookshelf/commit/e50b78e121b04797a4e36931be64019c298bffb6) Style: simplify base path normalization ### 📊 Changes **7 files changed** (+550 additions, -10 deletions) <details> <summary>View changed files</summary> 📝 `client/assets/app.css` (+1 -1) 📝 `client/layouts/default.vue` (+1 -0) 📝 `client/plugins/axios.js` (+4 -0) 📝 `package-lock.json` (+483 -5) 📝 `package.json` (+2 -1) 📝 `server/Server.js` (+57 -1) 📝 `server/SocketAuthority.js` (+2 -2) </details> ### 📄 Description ### Adresses #385 Although in my tests this seems to work reliably, this is at best a temporary solution. As discussed in #385, this should be replaced by a long-term solution, such as running nuxt programatically or as it's own thread and proxying requests to it. Feel free to absolutely obliterate it, or keep this open until the long-term solution is finished. I think we should decide on a direction before I begin tackling that one. Also, this was done outside the development container (Node 16.20, Ubuntu 22.04), so you might want to look over the lockfile. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2026-04-25 00:16:20 +02:00
adam closed this issue 2026-04-25 00:16:20 +02:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
authentication
backlog
bug
chapter editor
config-issue
ebooks
encoding/embedding
enhancement
help wanted
listening sessions & progress
planned
possible plugin
progress sync
pull-request
Mirrored from GitHub Pull Request
 sorting/filtering/searching
unable to reproduce
upload
users & permissions
waiting
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam (Adam Melkus)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/audiobookshelf#3607
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?