starred/audiobookshelf
1
0
Fork 0
mirror of https://github.com/advplyr/audiobookshelf.git synced 2026-05-30 23:40:40 +02:00
Code Issues 1.0k Packages Projects Releases 10 Wiki Activity

[PR #1706] [MERGED] Update:Fix filename issue in tone, bump to v0.1.5 #3603

New Issue
Closed
opened 2026-04-25 00:16:19 +02:00 by adam · 0 comments
adam commented 2026-04-25 00:16:19 +02:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/advplyr/audiobookshelf/pull/1706
Author: @ajaxbits
Created: 4/19/2023
Status: ✅ Merged
Merged: 4/20/2023
Merged by: @advplyr

Base: master ← Head: master

📝 Commits (4)

  • c7b4b3b Update:Bump tone version
  • 6f73345 Merge branch 'advplyr:master' into master
  • b1b53a1 Update:Bump tone version in devcontainer to v0.1.5
  • 3b6fa73 Update tone in debian package to v0.1.5

📊 Changes

3 files changed (+5 additions, -5 deletions)

View changed files

📝 .devcontainer/Dockerfile (+1 -1)
📝 Dockerfile (+1 -1)
📝 build/debian/DEBIAN/preinst (+3 -3)

📄 Description

Addresses #1703, where tone:v0.1.2 could not parse certain files with quotations and spaces in the name. Relevant tone bug here.

This is fixed in tone >= v0.1.3, and this PR pins the docker image to the latest version. The devcontainer version is also bumped

Confirmed the fix works by running the following inside the docker container:

wget https://archive.org/download/sonnets_etk_librivox/sonnets_etk_librivox.m4b
mv sonnets_etk_librivox.m4b \"Diane...\"\ The\ Twin\ Peaks\ Tapes\ of\ Agent\ Cooper.m4b
tone dump \"Diane...\"\ The\ Twin\ Peaks\ Tapes\ of\ Agent\ Cooper.m4b

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/advplyr/audiobookshelf/pull/1706 **Author:** [@ajaxbits](https://github.com/ajaxbits) **Created:** 4/19/2023 **Status:** ✅ Merged **Merged:** 4/20/2023 **Merged by:** [@advplyr](https://github.com/advplyr) **Base:** `master` ← **Head:** `master` --- ### 📝 Commits (4) - [`c7b4b3b`](https://github.com/advplyr/audiobookshelf/commit/c7b4b3bd3e7e9c85b511c002ca2f587cdae42985) Update:Bump tone version - [`6f73345`](https://github.com/advplyr/audiobookshelf/commit/6f73345f39ef9a8528d92450f0bf27002752c0d7) Merge branch 'advplyr:master' into master - [`b1b53a1`](https://github.com/advplyr/audiobookshelf/commit/b1b53a1eaeede304485157aebb69dc0d7f932503) Update:Bump tone version in devcontainer to v0.1.5 - [`3b6fa73`](https://github.com/advplyr/audiobookshelf/commit/3b6fa73ac0c444d52bc0b9b0da0a35ce61136e5b) Update tone in debian package to v0.1.5 ### 📊 Changes **3 files changed** (+5 additions, -5 deletions) <details> <summary>View changed files</summary> 📝 `.devcontainer/Dockerfile` (+1 -1) 📝 `Dockerfile` (+1 -1) 📝 `build/debian/DEBIAN/preinst` (+3 -3) </details> ### 📄 Description Addresses #1703, where `tone:v0.1.2` could not parse certain files with quotations and spaces in the name. [Relevant `tone` bug here](https://github.com/sandreas/tone/issues/43). This is fixed in `tone >= v0.1.3`, and this PR pins the docker image to the latest version. The devcontainer version is also bumped Confirmed the fix works by running the following inside the docker container: ```bash wget https://archive.org/download/sonnets_etk_librivox/sonnets_etk_librivox.m4b mv sonnets_etk_librivox.m4b \"Diane...\"\ The\ Twin\ Peaks\ Tapes\ of\ Agent\ Cooper.m4b tone dump \"Diane...\"\ The\ Twin\ Peaks\ Tapes\ of\ Agent\ Cooper.m4b ``` --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2026-04-25 00:16:19 +02:00
adam closed this issue 2026-04-25 00:16:19 +02:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
authentication
backlog
bug
chapter editor
config-issue
ebooks
encoding/embedding
enhancement
help wanted
listening sessions & progress
planned
possible plugin
progress sync
pull-request
Mirrored from GitHub Pull Request
 sorting/filtering/searching
unable to reproduce
upload
users & permissions
waiting
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam (Adam Melkus)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/audiobookshelf#3603
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?