starred/audiobookshelf
1
0
Fork 0
mirror of https://github.com/advplyr/audiobookshelf.git synced 2026-05-30 23:40:40 +02:00
Code Issues 1.0k Packages Projects Releases 10 Wiki Activity

[PR #1556] [MERGED] Fix incorrect tags when blocking public feeds #3574

New Issue
Closed
opened 2026-04-25 00:16:12 +02:00 by adam · 0 comments
adam commented 2026-04-25 00:16:12 +02:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/advplyr/audiobookshelf/pull/1556
Author: @Weldawadyathink
Created: 2/25/2023
Status: ✅ Merged
Merged: 2/27/2023
Merged by: @advplyr

Base: master ← Head: public_rss_feeds

📝 Commits (1)

  • 3a7fd0b Fix incorrect tags when blocking public feeds

📊 Changes

1 file changed (+2 additions, -2 deletions)

View changed files

📝 server/objects/FeedMeta.js (+2 -2)

📄 Description

#1554 was way better than what I could do, had 1 minor issue. iTunes:block should be "Yes". Any other result is ignored. Documentation here. Although I cannot find the documentation for google:block, pattern podcast feeds suggest it should be lowercase "yes".

image

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/advplyr/audiobookshelf/pull/1556 **Author:** [@Weldawadyathink](https://github.com/Weldawadyathink) **Created:** 2/25/2023 **Status:** ✅ Merged **Merged:** 2/27/2023 **Merged by:** [@advplyr](https://github.com/advplyr) **Base:** `master` ← **Head:** `public_rss_feeds` --- ### 📝 Commits (1) - [`3a7fd0b`](https://github.com/advplyr/audiobookshelf/commit/3a7fd0bcc90bc61510d4d146740e7bc938037caf) Fix incorrect tags when blocking public feeds ### 📊 Changes **1 file changed** (+2 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `server/objects/FeedMeta.js` (+2 -2) </details> ### 📄 Description #1554 was way better than what I could do, had 1 minor issue. iTunes:block should be "Yes". Any other result is ignored. [Documentation here](https://help.apple.com/itc/podcasts_connect/#/itcb54353390). Although I cannot find the documentation for google:block, pattern podcast feeds suggest it should be lowercase "yes". <img width="342" alt="image" src="https://user-images.githubusercontent.com/2880344/221370323-2c0d5188-c86e-4963-87e1-7c916141ec8a.png"> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2026-04-25 00:16:12 +02:00
adam closed this issue 2026-04-25 00:16:12 +02:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
authentication
backlog
bug
chapter editor
config-issue
ebooks
encoding/embedding
enhancement
help wanted
listening sessions & progress
planned
possible plugin
progress sync
pull-request
Mirrored from GitHub Pull Request
 sorting/filtering/searching
unable to reproduce
upload
users & permissions
waiting
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam (Adam Melkus)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/audiobookshelf#3574
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?