starred/audiobookshelf
1
0
Fork 0
mirror of https://github.com/advplyr/audiobookshelf.git synced 2026-05-30 23:40:40 +02:00
Code Issues 1.0k Packages Projects Releases 10 Wiki Activity

[PR #1515] [MERGED] Encode podcast url when downloading episode #3561

New Issue
Closed
opened 2026-04-25 00:16:08 +02:00 by adam · 0 comments
adam commented 2026-04-25 00:16:08 +02:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/advplyr/audiobookshelf/pull/1515
Author: @dwtong
Created: 2/18/2023
Status: ✅ Merged
Merged: 2/21/2023
Merged by: @advplyr

Base: master ← Head: encode-podcast-url

📝 Commits (1)

  • 956678c Encode podcast url when downloading episode

📊 Changes

1 file changed (+1 additions, -1 deletions)

View changed files

📝 server/objects/PodcastEpisodeDownload.js (+1 -1)

📄 Description

Thanks for all the great work on audiobookshelf! This is a small change to fix a error that I encountered:

ERROR: [PodcastManager] Podcast Episode download failed TypeError [ERR_UNESCAPED_CHARACTERS]: Request path contains unescaped characters
  at new NodeError (node:internal/errors:387:5)
  at new ClientRequest (node:_http_client:182:13)
  at Object.request (node:https:357:10)
  at RedirectableRequest._performRequest (/node_modules/follow-redirects/index.js:284:24)
  at new RedirectableRequest (/node_modules/follow-redirects/index.js:66:8)
  at Object.request (/node_modules/follow-redirects/index.js:523:14)
  at dispatchHttpRequest (/node_modules/axios/lib/adapters/http.js:262:25)
  at new Promise (<anonymous>)
  at httpAdapter (/node_modules/axios/lib/adapters/http.js:49:10)
  at dispatchRequest (/node_modules/axios/lib/core/dispatchRequest.js:58:10) {
  code: 'ERR_UNESCAPED_CHARACTERS'
} (PodcastManager.js:85)

Tested the change, this error no longer occurs, and podcast downloads correctly.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/advplyr/audiobookshelf/pull/1515 **Author:** [@dwtong](https://github.com/dwtong) **Created:** 2/18/2023 **Status:** ✅ Merged **Merged:** 2/21/2023 **Merged by:** [@advplyr](https://github.com/advplyr) **Base:** `master` ← **Head:** `encode-podcast-url` --- ### 📝 Commits (1) - [`956678c`](https://github.com/advplyr/audiobookshelf/commit/956678c08c697eb24709a8280e5de02a876dbfe3) Encode podcast url when downloading episode ### 📊 Changes **1 file changed** (+1 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `server/objects/PodcastEpisodeDownload.js` (+1 -1) </details> ### 📄 Description Thanks for all the great work on audiobookshelf! This is a small change to fix a error that I encountered: ``` ERROR: [PodcastManager] Podcast Episode download failed TypeError [ERR_UNESCAPED_CHARACTERS]: Request path contains unescaped characters at new NodeError (node:internal/errors:387:5) at new ClientRequest (node:_http_client:182:13) at Object.request (node:https:357:10) at RedirectableRequest._performRequest (/node_modules/follow-redirects/index.js:284:24) at new RedirectableRequest (/node_modules/follow-redirects/index.js:66:8) at Object.request (/node_modules/follow-redirects/index.js:523:14) at dispatchHttpRequest (/node_modules/axios/lib/adapters/http.js:262:25) at new Promise (<anonymous>) at httpAdapter (/node_modules/axios/lib/adapters/http.js:49:10) at dispatchRequest (/node_modules/axios/lib/core/dispatchRequest.js:58:10) { code: 'ERR_UNESCAPED_CHARACTERS' } (PodcastManager.js:85) ``` Tested the change, this error no longer occurs, and podcast downloads correctly. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2026-04-25 00:16:08 +02:00
adam closed this issue 2026-04-25 00:16:08 +02:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
authentication
backlog
bug
chapter editor
config-issue
ebooks
encoding/embedding
enhancement
help wanted
listening sessions & progress
planned
possible plugin
progress sync
pull-request
Mirrored from GitHub Pull Request
 sorting/filtering/searching
unable to reproduce
upload
users & permissions
waiting
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam (Adam Melkus)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/audiobookshelf#3561
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?