starred/audiobookshelf
1
0
Fork 0
mirror of https://github.com/advplyr/audiobookshelf.git synced 2026-05-30 23:40:40 +02:00
Code Issues 1.0k Packages Projects Releases 10 Wiki Activity

[PR #1456] [MERGED] Fixes m4b chapters only taken from first file. #3551

New Issue
Closed
opened 2026-04-25 00:16:06 +02:00 by adam · 0 comments
adam commented 2026-04-25 00:16:06 +02:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/advplyr/audiobookshelf/pull/1456
Author: @jramer
Created: 1/30/2023
Status: ✅ Merged
Merged: 1/31/2023
Merged by: @advplyr

Base: master ← Head: master

📝 Commits (6)

  • 80ef8ee Fixes m4b chapters only taken from first file.
  • 36d2957 Adds check for duplicated chapter data
  • 72d0b09 Reverts change of file ending
  • 5d96b2c Logs correctly and simplifies for single audio file.
  • 4770be5 Update server/objects/mediaTypes/Book.js
  • 0203f9c Update server/objects/mediaTypes/Book.js

📊 Changes

1 file changed (+32 additions, -4 deletions)

View changed files

📝 server/objects/mediaTypes/Book.js (+32 -4)

📄 Description

Noticed that I was only getting chapters from the first m4b file and this fixes that.
Only tested with m4b. Don't know if other file formats support chapters.

Code uses let and optional chaining. Hope that's ok.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/advplyr/audiobookshelf/pull/1456 **Author:** [@jramer](https://github.com/jramer) **Created:** 1/30/2023 **Status:** ✅ Merged **Merged:** 1/31/2023 **Merged by:** [@advplyr](https://github.com/advplyr) **Base:** `master` ← **Head:** `master` --- ### 📝 Commits (6) - [`80ef8ee`](https://github.com/advplyr/audiobookshelf/commit/80ef8ee890949b860585331e6c73a3a71b3e5912) Fixes m4b chapters only taken from first file. - [`36d2957`](https://github.com/advplyr/audiobookshelf/commit/36d2957fb4db0d89198a4fe1751b772d2cb30c62) Adds check for duplicated chapter data - [`72d0b09`](https://github.com/advplyr/audiobookshelf/commit/72d0b097ab373ef933f723381597f857bf1fd59b) Reverts change of file ending - [`5d96b2c`](https://github.com/advplyr/audiobookshelf/commit/5d96b2cc6e165dad812c1b0d4438afc387f1fc48) Logs correctly and simplifies for single audio file. - [`4770be5`](https://github.com/advplyr/audiobookshelf/commit/4770be5a397253b0a183787af293bb8752d86542) Update server/objects/mediaTypes/Book.js - [`0203f9c`](https://github.com/advplyr/audiobookshelf/commit/0203f9cc1b37b5dda029858e62a5ad216774e6ec) Update server/objects/mediaTypes/Book.js ### 📊 Changes **1 file changed** (+32 additions, -4 deletions) <details> <summary>View changed files</summary> 📝 `server/objects/mediaTypes/Book.js` (+32 -4) </details> ### 📄 Description Noticed that I was only getting chapters from the first `m4b` file and this fixes that. Only tested with `m4b`. Don't know if other file formats support chapters. Code uses `let` and optional chaining. Hope that's ok. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2026-04-25 00:16:06 +02:00
adam closed this issue 2026-04-25 00:16:06 +02:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
authentication
backlog
bug
chapter editor
config-issue
ebooks
encoding/embedding
enhancement
help wanted
listening sessions & progress
planned
possible plugin
progress sync
pull-request
Mirrored from GitHub Pull Request
 sorting/filtering/searching
unable to reproduce
upload
users & permissions
waiting
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam (Adam Melkus)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/audiobookshelf#3551
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?