starred/audiobookshelf
1
0
Fork 0
mirror of https://github.com/advplyr/audiobookshelf.git synced 2026-05-30 23:40:40 +02:00
Code Issues 1.0k Packages Projects Releases 10 Wiki Activity

[PR #1425] [MERGED] Skip AUDIOBOOKSHELF_UID/GID if undefined #3543

New Issue
Closed
opened 2026-04-25 00:16:04 +02:00 by adam · 0 comments
adam commented 2026-04-25 00:16:04 +02:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/advplyr/audiobookshelf/pull/1425
Author: @lkiesow
Created: 1/22/2023
Status: ✅ Merged
Merged: 1/22/2023
Merged by: @advplyr

Base: master ← Head: undefined-uid-gid

📝 Commits (1)

  • 274b0e4 Skip AUDIOBOOKSHELF_UID/GID if undefined

📊 Changes

4 files changed (+15 additions, -7 deletions)

View changed files

📝 index.js (+2 -2)
📝 prod.js (+2 -2)
📝 server/Server.js (+2 -2)
📝 server/utils/filePerms.js (+9 -1)

📄 Description

This patch slightly changes the behavior of the AUDIOBOOKSHELF_UID and AUDIOBOOKSHELF_GID options. Instead of defining a default user and group, trying to modify files and silently failing if the filesystem mode cannot be changed, this patch will just skip the entire process in the first place.

If these options are defined, Audiobookshelf should behave exactly as before. If they are not defined, Audiobookshelf will now cause fewer file modifications (or less failures when trying to modify files).

If this patch gets applied, it should probably be highlighted in the release notes. This usually shouldn't cause problems for migrations since the Docker guides explicitly configure the options and the package installations do not seem to use this at all, but there is still a change that it will and users should be aware of that.

If a problem arises, users can easily fix the problem by either setting the permissions once manually to the audiobookshelf user or by simply defining the AUDIOBOOKSHELF_UID/GID options.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/advplyr/audiobookshelf/pull/1425 **Author:** [@lkiesow](https://github.com/lkiesow) **Created:** 1/22/2023 **Status:** ✅ Merged **Merged:** 1/22/2023 **Merged by:** [@advplyr](https://github.com/advplyr) **Base:** `master` ← **Head:** `undefined-uid-gid` --- ### 📝 Commits (1) - [`274b0e4`](https://github.com/advplyr/audiobookshelf/commit/274b0e48be527adb8ca75d9d8a133040bd0a0a76) Skip AUDIOBOOKSHELF_UID/GID if undefined ### 📊 Changes **4 files changed** (+15 additions, -7 deletions) <details> <summary>View changed files</summary> 📝 `index.js` (+2 -2) 📝 `prod.js` (+2 -2) 📝 `server/Server.js` (+2 -2) 📝 `server/utils/filePerms.js` (+9 -1) </details> ### 📄 Description This patch slightly changes the behavior of the `AUDIOBOOKSHELF_UID` and `AUDIOBOOKSHELF_GID` options. Instead of defining a default user and group, trying to modify files and silently failing if the filesystem mode cannot be changed, this patch will just skip the entire process in the first place. If these options are defined, Audiobookshelf should behave exactly as before. If they are not defined, Audiobookshelf will now cause fewer file modifications (or less failures when trying to modify files). If this patch gets applied, it should probably be highlighted in the release notes. This usually shouldn't cause problems for migrations since the Docker guides explicitly configure the options and the package installations do not seem to use this at all, but there is still a change that it will and users should be aware of that. If a problem arises, users can easily fix the problem by either setting the permissions once manually to the audiobookshelf user or by simply defining the `AUDIOBOOKSHELF_UID/GID` options. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2026-04-25 00:16:04 +02:00
adam closed this issue 2026-04-25 00:16:04 +02:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
authentication
backlog
bug
chapter editor
config-issue
ebooks
encoding/embedding
enhancement
help wanted
listening sessions & progress
planned
possible plugin
progress sync
pull-request
Mirrored from GitHub Pull Request
 sorting/filtering/searching
unable to reproduce
upload
users & permissions
waiting
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam (Adam Melkus)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/audiobookshelf#3543
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?