[PR #1423] [MERGED] Ensure default are similar in different environments #3542

Closed
opened 2026-04-25 00:16:04 +02:00 by adam · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/advplyr/audiobookshelf/pull/1423
Author: @lkiesow
Created: 1/22/2023
Status: Merged
Merged: 1/22/2023
Merged by: @advplyr

Base: masterHead: prod-opts


📝 Commits (2)

  • 4d8ffc5 Ensure default are similar in different environments
  • 22179d8 Merge branch 'master' into prod-opts

📊 Changes

1 file changed (+3 additions, -2 deletions)

View changed files

📝 prod.js (+3 -2)

📄 Description

This patch tries to make sure that defaults and options work in the same way regardless of users using Docker or a package deployment.

  • Commit 10295b0 updated Host to be empty by default to better support IPv6. This fixes a missed occurrence of the old default.
  • This makes sure the SOURCE environment variable is honored when installing the packages. The --source option will still take precedence though.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/advplyr/audiobookshelf/pull/1423 **Author:** [@lkiesow](https://github.com/lkiesow) **Created:** 1/22/2023 **Status:** ✅ Merged **Merged:** 1/22/2023 **Merged by:** [@advplyr](https://github.com/advplyr) **Base:** `master` ← **Head:** `prod-opts` --- ### 📝 Commits (2) - [`4d8ffc5`](https://github.com/advplyr/audiobookshelf/commit/4d8ffc5d9974f42c9ec1ef12c07d3186ca6ba118) Ensure default are similar in different environments - [`22179d8`](https://github.com/advplyr/audiobookshelf/commit/22179d82b812829efae9cda993b94ebfed375871) Merge branch 'master' into prod-opts ### 📊 Changes **1 file changed** (+3 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `prod.js` (+3 -2) </details> ### 📄 Description This patch tries to make sure that defaults and options work in the same way regardless of users using Docker or a package deployment. - Commit 10295b0 updated `Host` to be empty by default to better support IPv6. This fixes a missed occurrence of the old default. - This makes sure the `SOURCE` environment variable is honored when installing the packages. The `--source` option will still take precedence though. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2026-04-25 00:16:04 +02:00
adam closed this issue 2026-04-25 00:16:04 +02:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/audiobookshelf#3542