starred/audiobookshelf
1
0
Fork 0
mirror of https://github.com/advplyr/audiobookshelf.git synced 2026-05-30 23:40:40 +02:00
Code Issues 1.0k Packages Projects Releases 10 Wiki Activity

[PR #1350] [MERGED] Fix Hidden Settings Menu #3524

New Issue
Closed
opened 2026-04-25 00:15:59 +02:00 by adam · 0 comments
adam commented 2026-04-25 00:15:59 +02:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/advplyr/audiobookshelf/pull/1350
Author: @lkiesow
Created: 1/1/2023
Status: ✅ Merged
Merged: 1/2/2023
Merged by: @advplyr

Base: master ← Head: settings-menu

📝 Commits (1)

📊 Changes

3 files changed (+16 additions, -12 deletions)

View changed files

📝 client/components/app/ConfigSideNav.vue (+6 -4)
📝 client/pages/config.vue (+7 -7)
📝 client/store/globals.js (+3 -1)

📄 Description

This patch fixes several problems of the settings menu related to display on mobile devices or small(ish) windows:

  • The isMobileLandscape is now calculated correctly. Previously, this was set to true if a device was in portrait mode.

  • Showing the button to collapse the settings menu and making the menu collapsible now use the same mechanism. Previously, it could happen that the menu was opened and not fixed, but no button to close it again was shown.

  • The icons fore opening and closing the settings menu are now both arrows, indicating that their functionality is reversed.

  • The button to open the menu now always has the string “Settings”, instead of using the name of the current page. The current page hader is listed below that anyway and this is the action component to open the settings menu after all.

This fixes #1334

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/advplyr/audiobookshelf/pull/1350 **Author:** [@lkiesow](https://github.com/lkiesow) **Created:** 1/1/2023 **Status:** ✅ Merged **Merged:** 1/2/2023 **Merged by:** [@advplyr](https://github.com/advplyr) **Base:** `master` ← **Head:** `settings-menu` --- ### 📝 Commits (1) - [`452af43`](https://github.com/advplyr/audiobookshelf/commit/452af4391687a9835b62d8e764ca03bf82f49102) Fix Hidden Settings Menu ### 📊 Changes **3 files changed** (+16 additions, -12 deletions) <details> <summary>View changed files</summary> 📝 `client/components/app/ConfigSideNav.vue` (+6 -4) 📝 `client/pages/config.vue` (+7 -7) 📝 `client/store/globals.js` (+3 -1) </details> ### 📄 Description This patch fixes several problems of the settings menu related to display on mobile devices or small(ish) windows: - The `isMobileLandscape` is now calculated correctly. Previously, this was set to `true` if a device was in portrait mode. - Showing the button to collapse the settings menu and making the menu collapsible now use the same mechanism. Previously, it could happen that the menu was opened and not fixed, but no button to close it again was shown. - The icons fore opening and closing the settings menu are now both arrows, indicating that their functionality is reversed. - The button to open the menu now always has the string “Settings”, instead of using the name of the current page. The current page hader is listed below that anyway and this is the action component to open the settings menu after all. This fixes #1334 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2026-04-25 00:15:59 +02:00
adam closed this issue 2026-04-25 00:15:59 +02:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
authentication
backlog
bug
chapter editor
config-issue
ebooks
encoding/embedding
enhancement
help wanted
listening sessions & progress
planned
possible plugin
progress sync
pull-request
Mirrored from GitHub Pull Request
 sorting/filtering/searching
unable to reproduce
upload
users & permissions
waiting
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam (Adam Melkus)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/audiobookshelf#3524
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?