starred/audiobookshelf
1
0
Fork 0
mirror of https://github.com/advplyr/audiobookshelf.git synced 2026-05-30 23:40:40 +02:00
Code Issues 1.0k Packages Projects Releases 10 Wiki Activity

[PR #1341] [MERGED] Fix keyboard navigation in user settings #3522

New Issue
Closed
opened 2026-04-25 00:15:59 +02:00 by adam · 0 comments
adam commented 2026-04-25 00:15:59 +02:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/advplyr/audiobookshelf/pull/1341
Author: @lkiesow
Created: 12/29/2022
Status: ✅ Merged
Merged: 12/30/2022
Merged by: @advplyr

Base: master ← Head: a11y-user-settings

📝 Commits (1)

  • 4e61185 Fix keyboard navigation in user settings

📊 Changes

3 files changed (+7 additions, -3 deletions)

View changed files

📝 client/components/tables/UsersTable.vue (+3 -3)
📝 client/strings/de.json (+2 -0)
📝 client/strings/en-us.json (+2 -0)

📄 Description

This patch makes sure that the option in the user settings are accessible via keyboard navigation and that the labels, if users use a screen reader, actually make sense.

This patch introduces new strings which need to be translated. Although I did already provide a German translation.

As a minor visual details, this patch also aligns the delete and edit icons:

Screenshot from 2022-12-29 21-03-12

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/advplyr/audiobookshelf/pull/1341 **Author:** [@lkiesow](https://github.com/lkiesow) **Created:** 12/29/2022 **Status:** ✅ Merged **Merged:** 12/30/2022 **Merged by:** [@advplyr](https://github.com/advplyr) **Base:** `master` ← **Head:** `a11y-user-settings` --- ### 📝 Commits (1) - [`4e61185`](https://github.com/advplyr/audiobookshelf/commit/4e61185136f9e971b7b9a85dfd06acb5cbcc57d5) Fix keyboard navigation in user settings ### 📊 Changes **3 files changed** (+7 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `client/components/tables/UsersTable.vue` (+3 -3) 📝 `client/strings/de.json` (+2 -0) 📝 `client/strings/en-us.json` (+2 -0) </details> ### 📄 Description This patch makes sure that the option in the user settings are accessible via keyboard navigation and that the labels, if users use a screen reader, actually make sense. This patch introduces new strings which need to be translated. Although I did already provide a German translation. As a minor visual details, this patch also aligns the delete and edit icons: ![Screenshot from 2022-12-29 21-03-12](https://user-images.githubusercontent.com/1008395/210008917-720371be-05dc-4885-9b28-16ce474b3237.png) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2026-04-25 00:15:59 +02:00
adam closed this issue 2026-04-25 00:15:59 +02:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
authentication
backlog
bug
chapter editor
config-issue
ebooks
encoding/embedding
enhancement
help wanted
listening sessions & progress
planned
possible plugin
progress sync
pull-request
Mirrored from GitHub Pull Request
 sorting/filtering/searching
unable to reproduce
upload
users & permissions
waiting
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam (Adam Melkus)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/audiobookshelf#3522
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?