starred/audiobookshelf
1
0
Fork 0
mirror of https://github.com/advplyr/audiobookshelf.git synced 2026-05-30 23:40:40 +02:00
Code Issues 1.0k Packages Projects Releases 10 Wiki Activity

[PR #1336] [MERGED] Make User Settings Accessible via Screen Reader #3519

New Issue
Closed
opened 2026-04-25 00:15:58 +02:00 by adam · 0 comments
adam commented 2026-04-25 00:15:58 +02:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/advplyr/audiobookshelf/pull/1336
Author: @lkiesow
Created: 12/29/2022
Status: ✅ Merged
Merged: 12/30/2022
Merged by: @advplyr

Base: master ← Head: user-settings-screenreader

📝 Commits (2)

  • 2c344a0 Make User Settings Accessible via Screen Reader
  • 5a3f14a Remove extra space from label

📊 Changes

6 files changed (+32 additions, -27 deletions)

View changed files

📝 client/components/app/SettingsContent.vue (+1 -1)
📝 client/components/modals/AccountModal.vue (+14 -14)
📝 client/components/ui/Dropdown.vue (+3 -3)
📝 client/components/ui/TextInput.vue (+3 -2)
📝 client/components/ui/TextInputWithLabel.vue (+7 -4)
📝 client/components/ui/ToggleSwitch.vue (+4 -3)

📄 Description

This patch should fix most of the problems for users trying to access the user settings via screen reader. It makes sure user interface elements can be reached via keyboard and provides proper labels, roles and values so you not only can interact with elements but also know what you are actually changing.

While not focused on other views, this should also already fix a number of accessibility issues with other settings pages.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/advplyr/audiobookshelf/pull/1336 **Author:** [@lkiesow](https://github.com/lkiesow) **Created:** 12/29/2022 **Status:** ✅ Merged **Merged:** 12/30/2022 **Merged by:** [@advplyr](https://github.com/advplyr) **Base:** `master` ← **Head:** `user-settings-screenreader` --- ### 📝 Commits (2) - [`2c344a0`](https://github.com/advplyr/audiobookshelf/commit/2c344a0bc027b101bf0fa8e94c07c3ba6a580fa6) Make User Settings Accessible via Screen Reader - [`5a3f14a`](https://github.com/advplyr/audiobookshelf/commit/5a3f14ae51127b844daf5a34f4f9397803610d40) Remove extra space from label ### 📊 Changes **6 files changed** (+32 additions, -27 deletions) <details> <summary>View changed files</summary> 📝 `client/components/app/SettingsContent.vue` (+1 -1) 📝 `client/components/modals/AccountModal.vue` (+14 -14) 📝 `client/components/ui/Dropdown.vue` (+3 -3) 📝 `client/components/ui/TextInput.vue` (+3 -2) 📝 `client/components/ui/TextInputWithLabel.vue` (+7 -4) 📝 `client/components/ui/ToggleSwitch.vue` (+4 -3) </details> ### 📄 Description This patch should fix most of the problems for users trying to access the user settings via screen reader. It makes sure user interface elements can be reached via keyboard and provides proper labels, roles and values so you not only can interact with elements but also know what you are actually changing. While not focused on other views, this should also already fix a number of accessibility issues with other settings pages. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2026-04-25 00:15:58 +02:00
adam closed this issue 2026-04-25 00:15:58 +02:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
authentication
backlog
bug
chapter editor
config-issue
ebooks
encoding/embedding
enhancement
help wanted
listening sessions & progress
planned
possible plugin
progress sync
pull-request
Mirrored from GitHub Pull Request
 sorting/filtering/searching
unable to reproduce
upload
users & permissions
waiting
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam (Adam Melkus)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/audiobookshelf#3519
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?