starred/audiobookshelf
1
0
Fork 0
mirror of https://github.com/advplyr/audiobookshelf.git synced 2026-05-30 23:40:40 +02:00
Code Issues 1.0k Packages Projects Releases 10 Wiki Activity

[PR #1282] [MERGED] Use HTTPS for Google Books Images #3503

New Issue
Closed
opened 2026-04-25 00:15:55 +02:00 by adam · 0 comments
adam commented 2026-04-25 00:15:55 +02:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/advplyr/audiobookshelf/pull/1282
Author: @lkiesow
Created: 12/18/2022
Status: ✅ Merged
Merged: 12/18/2022
Merged by: @advplyr

Base: master ← Head: google-books-https

📝 Commits (1)

  • b47ce4f Use HTTPS for Google Books Images

📊 Changes

1 file changed (+2 additions, -1 deletions)

View changed files

📝 server/providers/GoogleBooks.js (+2 -1)

📄 Description

The API for Google Books will return HTTP image URLs when matiching any books using it as a search provider. In a secure environment, this causes browser warnings.

Screenshot from 2022-12-18 00-05-36

Screenshot from 2022-12-18 00-02-08

All Google image links support HTTPS and we can safely switch to HTTOS to avoid these warnings.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/advplyr/audiobookshelf/pull/1282 **Author:** [@lkiesow](https://github.com/lkiesow) **Created:** 12/18/2022 **Status:** ✅ Merged **Merged:** 12/18/2022 **Merged by:** [@advplyr](https://github.com/advplyr) **Base:** `master` ← **Head:** `google-books-https` --- ### 📝 Commits (1) - [`b47ce4f`](https://github.com/advplyr/audiobookshelf/commit/b47ce4fb240645ec7d50036da6d8352a8ca0f2e6) Use HTTPS for Google Books Images ### 📊 Changes **1 file changed** (+2 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `server/providers/GoogleBooks.js` (+2 -1) </details> ### 📄 Description The API for Google Books will return HTTP image URLs when matiching any books using it as a search provider. In a secure environment, this causes browser warnings. ![Screenshot from 2022-12-18 00-05-36](https://user-images.githubusercontent.com/1008395/208269585-fe3529f6-df1a-4736-87ba-6cd91a77be3a.png) ![Screenshot from 2022-12-18 00-02-08](https://user-images.githubusercontent.com/1008395/208269591-1a59ad67-4e23-4b85-9b3c-48d9a132ea44.png) All Google image links support HTTPS and we can safely switch to HTTOS to avoid these warnings. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2026-04-25 00:15:55 +02:00
adam closed this issue 2026-04-25 00:15:55 +02:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
authentication
backlog
bug
chapter editor
config-issue
ebooks
encoding/embedding
enhancement
help wanted
listening sessions & progress
planned
possible plugin
progress sync
pull-request
Mirrored from GitHub Pull Request
 sorting/filtering/searching
unable to reproduce
upload
users & permissions
waiting
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam (Adam Melkus)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/audiobookshelf#3503
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?