starred/audiobookshelf
1
0
Fork 0
mirror of https://github.com/advplyr/audiobookshelf.git synced 2026-05-30 23:40:40 +02:00
Code Issues 1.0k Packages Projects Releases 10 Wiki Activity

[PR #1268] [CLOSED] Improve docker dev container support #3498

New Issue
Closed
opened 2026-04-25 00:15:53 +02:00 by adam · 0 comments
adam commented 2026-04-25 00:15:53 +02:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/advplyr/audiobookshelf/pull/1268
Author: @Weldawadyathink
Created: 12/14/2022
Status: ❌ Closed

Base: master ← Head: devcontainer

📝 Commits (6)

  • ef56714 Updated dev container
  • aa336cf Add dev.default.js file
  • f972533 Fix npm reinstalling everything every reboot
  • e3b83d6 debug npm generate not working
  • 6bb43b2 Working reliably with local containers
  • 63192f3 Github codespaces seems to ignore postStartCommand

📊 Changes

4 files changed (+33 additions, -7 deletions)

View changed files

📝 .devcontainer/Dockerfile (+8 -2)
📝 .devcontainer/devcontainer.json (+11 -4)
➕ dev.default.js (+11 -0)
📝 index.js (+3 -1)

📄 Description

The dev container config was missing a few necessary features. This adds the following features to the dev container:

  • Adds tone to the dev container
  • moves client/node_modules to a docker volume for performance reasons
  • configures git project directory to be trusted, preventing git complaining about ownership
  • Automatically install node modules and generate client
  • adds dev.default.js. This provides a default config that should work for most linux dev environments. Can be overridden by creating dev.js, so this will not interfere with existing setups.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/advplyr/audiobookshelf/pull/1268 **Author:** [@Weldawadyathink](https://github.com/Weldawadyathink) **Created:** 12/14/2022 **Status:** ❌ Closed **Base:** `master` ← **Head:** `devcontainer` --- ### 📝 Commits (6) - [`ef56714`](https://github.com/advplyr/audiobookshelf/commit/ef56714573ae7b260f1403665c36b597e2df5aef) Updated dev container - [`aa336cf`](https://github.com/advplyr/audiobookshelf/commit/aa336cfeb4dd17d7c10e6970e80234e7a18967f3) Add dev.default.js file - [`f972533`](https://github.com/advplyr/audiobookshelf/commit/f9725339476e928c3e12928608b86cc5f6dfd77e) Fix npm reinstalling everything every reboot - [`e3b83d6`](https://github.com/advplyr/audiobookshelf/commit/e3b83d6ed2f9af8fca2cee6889a69ef7632d3af0) debug npm generate not working - [`6bb43b2`](https://github.com/advplyr/audiobookshelf/commit/6bb43b21e14662f550c687d41f70e88e7eed4a77) Working reliably with local containers - [`63192f3`](https://github.com/advplyr/audiobookshelf/commit/63192f311f58ac1cffd18b3bf32959240fb7ff6e) Github codespaces seems to ignore postStartCommand ### 📊 Changes **4 files changed** (+33 additions, -7 deletions) <details> <summary>View changed files</summary> 📝 `.devcontainer/Dockerfile` (+8 -2) 📝 `.devcontainer/devcontainer.json` (+11 -4) ➕ `dev.default.js` (+11 -0) 📝 `index.js` (+3 -1) </details> ### 📄 Description The dev container config was missing a few necessary features. This adds the following features to the dev container: - Adds tone to the dev container - moves client/node_modules to a docker volume for performance reasons - configures git project directory to be trusted, preventing git complaining about ownership - Automatically install node modules and generate client - adds dev.default.js. This provides a default config that should work for most linux dev environments. Can be overridden by creating dev.js, so this will not interfere with existing setups. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2026-04-25 00:15:53 +02:00
adam closed this issue 2026-04-25 00:15:53 +02:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
authentication
backlog
bug
chapter editor
config-issue
ebooks
encoding/embedding
enhancement
help wanted
listening sessions & progress
planned
possible plugin
progress sync
pull-request
Mirrored from GitHub Pull Request
 sorting/filtering/searching
unable to reproduce
upload
users & permissions
waiting
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam (Adam Melkus)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/audiobookshelf#3498
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?