starred/audiobookshelf
1
0
Fork 0
mirror of https://github.com/advplyr/audiobookshelf.git synced 2026-05-30 23:40:40 +02:00
Code Issues 1.0k Packages Projects Releases 10 Wiki Activity

[PR #1221] [MERGED] Implement a Settings Content component #3490

New Issue
Closed
opened 2026-04-25 00:15:51 +02:00 by adam · 0 comments
adam commented 2026-04-25 00:15:51 +02:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/advplyr/audiobookshelf/pull/1221
Author: @jmt-gh
Created: 11/26/2022
Status: ✅ Merged
Merged: 11/26/2022
Merged by: @advplyr

Base: master ← Head: settings_page_component

📝 Commits (10+)

  • 4db34e0 Add new settings content component
  • 7627482 convert settings page to use settings content component
  • e3ec5dd convert sessions page to use settings content component
  • d5a19f2 Convert Library settings page to use new component
  • 5de6ee1 Convert Users settings page to use new component
  • a3ca615 convert stats page to use new settings component
  • 087de03 convert log page to use new settings component
  • 000d7fd convert library stats page to use new settings component
  • 61f8055 convert notifications page to use new settings component
  • c62a1df Convert Backup page to use new settings component

📊 Changes

20 files changed (+204 additions, -206 deletions)

View changed files

➕ client/components/app/SettingsContent.vue (+48 -0)
📝 client/components/tables/UsersTable.vue (+1 -8)
📝 client/components/tables/library/LibrariesTable.vue (+1 -7)
📝 client/pages/config/backups.vue (+3 -12)
📝 client/pages/config/index.vue (+3 -6)
📝 client/pages/config/libraries.vue (+3 -2)
📝 client/pages/config/library-stats.vue (+55 -54)
📝 client/pages/config/log.vue (+3 -6)
📝 client/pages/config/notifications.vue (+3 -25)
📝 client/pages/config/sessions.vue (+3 -7)
📝 client/pages/config/stats.vue (+55 -56)
📝 client/pages/config/users/index.vue (+14 -3)
📝 client/strings/de.json (+1 -2)
📝 client/strings/en-us.json (+2 -3)
📝 client/strings/es.json (+2 -3)
📝 client/strings/fr.json (+1 -2)
📝 client/strings/hr.json (+2 -3)
📝 client/strings/it.json (+1 -2)
📝 client/strings/pl.json (+2 -3)
📝 client/strings/zh-cn.json (+1 -2)

📄 Description

In previous commits, we consolidated all of the settings pages to have the same styling. This commit takes that one step further by extracting out all of that logic to a singular component. This component wraps the content of the settings pages themselves, so it is very easy to use. As well, it has the functionality to pass through the header text, description text, and a method that could be needed to "add a new one" of something for the page (users, libraries, etc.).

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/advplyr/audiobookshelf/pull/1221 **Author:** [@jmt-gh](https://github.com/jmt-gh) **Created:** 11/26/2022 **Status:** ✅ Merged **Merged:** 11/26/2022 **Merged by:** [@advplyr](https://github.com/advplyr) **Base:** `master` ← **Head:** `settings_page_component` --- ### 📝 Commits (10+) - [`4db34e0`](https://github.com/advplyr/audiobookshelf/commit/4db34e0c56696dff2f2aa35c9cfa208df0ad32cf) Add new settings content component - [`7627482`](https://github.com/advplyr/audiobookshelf/commit/762748225d726ba7f123f7384424bc7ad89274c7) convert settings page to use settings content component - [`e3ec5dd`](https://github.com/advplyr/audiobookshelf/commit/e3ec5dd50650f041cf64f20172bc841f3b6eebc4) convert sessions page to use settings content component - [`d5a19f2`](https://github.com/advplyr/audiobookshelf/commit/d5a19f2b42cee0844170d9ddd30f5e8697a95061) Convert Library settings page to use new component - [`5de6ee1`](https://github.com/advplyr/audiobookshelf/commit/5de6ee136ac820f640e0d11f64fff4ccba5379d5) Convert Users settings page to use new component - [`a3ca615`](https://github.com/advplyr/audiobookshelf/commit/a3ca6159fb480888d624b53e37cd764265138911) convert stats page to use new settings component - [`087de03`](https://github.com/advplyr/audiobookshelf/commit/087de03a1f793b2213f9577b4e20ccd0fe52aa96) convert log page to use new settings component - [`000d7fd`](https://github.com/advplyr/audiobookshelf/commit/000d7fd2498fc0bdd989e48d0198027a0810cd36) convert library stats page to use new settings component - [`61f8055`](https://github.com/advplyr/audiobookshelf/commit/61f805549357443e76722bf8ed0fc1c98f4394f8) convert notifications page to use new settings component - [`c62a1df`](https://github.com/advplyr/audiobookshelf/commit/c62a1dfff0f8a3a9c49cf4203fa7fa431d8209c6) Convert Backup page to use new settings component ### 📊 Changes **20 files changed** (+204 additions, -206 deletions) <details> <summary>View changed files</summary> ➕ `client/components/app/SettingsContent.vue` (+48 -0) 📝 `client/components/tables/UsersTable.vue` (+1 -8) 📝 `client/components/tables/library/LibrariesTable.vue` (+1 -7) 📝 `client/pages/config/backups.vue` (+3 -12) 📝 `client/pages/config/index.vue` (+3 -6) 📝 `client/pages/config/libraries.vue` (+3 -2) 📝 `client/pages/config/library-stats.vue` (+55 -54) 📝 `client/pages/config/log.vue` (+3 -6) 📝 `client/pages/config/notifications.vue` (+3 -25) 📝 `client/pages/config/sessions.vue` (+3 -7) 📝 `client/pages/config/stats.vue` (+55 -56) 📝 `client/pages/config/users/index.vue` (+14 -3) 📝 `client/strings/de.json` (+1 -2) 📝 `client/strings/en-us.json` (+2 -3) 📝 `client/strings/es.json` (+2 -3) 📝 `client/strings/fr.json` (+1 -2) 📝 `client/strings/hr.json` (+2 -3) 📝 `client/strings/it.json` (+1 -2) 📝 `client/strings/pl.json` (+2 -3) 📝 `client/strings/zh-cn.json` (+1 -2) </details> ### 📄 Description In previous commits, we consolidated all of the settings pages to have the same styling. This commit takes that one step further by extracting out all of that logic to a singular component. This component wraps the content of the settings pages themselves, so it is very easy to use. As well, it has the functionality to pass through the header text, description text, and a method that could be needed to "add a new one" of something for the page (users, libraries, etc.). --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2026-04-25 00:15:51 +02:00
adam closed this issue 2026-04-25 00:15:51 +02:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
authentication
backlog
bug
chapter editor
config-issue
ebooks
encoding/embedding
enhancement
help wanted
listening sessions & progress
planned
possible plugin
progress sync
pull-request
Mirrored from GitHub Pull Request
 sorting/filtering/searching
unable to reproduce
upload
users & permissions
waiting
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam (Adam Melkus)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/audiobookshelf#3490
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?