starred/audiobookshelf
1
0
Fork 0
mirror of https://github.com/advplyr/audiobookshelf.git synced 2026-05-30 23:40:40 +02:00
Code Issues 1.0k Packages Projects Releases 10 Wiki Activity

[PR #1193] [MERGED] No feed log level #3474

New Issue
Closed
opened 2026-04-25 00:15:48 +02:00 by adam · 0 comments
adam commented 2026-04-25 00:15:48 +02:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/advplyr/audiobookshelf/pull/1193
Author: @lkiesow
Created: 11/21/2022
Status: ✅ Merged
Merged: 11/21/2022
Merged by: @advplyr

Base: master ← Head: no-feed-no-error

📝 Commits (2)

  • c307b1e No feed log level
  • a2f1723 Update log level for RSS feed requests

📊 Changes

1 file changed (+3 additions, -3 deletions)

View changed files

📝 server/managers/RssFeedManager.js (+3 -3)

📄 Description

This patch drops the log level for logging requests to non-existing feeds from error to debug. The reasoning behind this is that this is a client error and a client error is returned and can be handled by the client.

Otherwise anyone can easily spam the logs with error messages by just requesting non-existing feeds.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/advplyr/audiobookshelf/pull/1193 **Author:** [@lkiesow](https://github.com/lkiesow) **Created:** 11/21/2022 **Status:** ✅ Merged **Merged:** 11/21/2022 **Merged by:** [@advplyr](https://github.com/advplyr) **Base:** `master` ← **Head:** `no-feed-no-error` --- ### 📝 Commits (2) - [`c307b1e`](https://github.com/advplyr/audiobookshelf/commit/c307b1e6fbb0147732bfe98079fb713b7fccc670) No feed log level - [`a2f1723`](https://github.com/advplyr/audiobookshelf/commit/a2f17236422a70aa9cce29b97584784fb7fc74c2) Update log level for RSS feed requests ### 📊 Changes **1 file changed** (+3 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `server/managers/RssFeedManager.js` (+3 -3) </details> ### 📄 Description This patch drops the log level for logging requests to non-existing feeds from error to debug. The reasoning behind this is that this is a client error and a client error is returned and can be handled by the client. Otherwise anyone can easily spam the logs with error messages by just requesting non-existing feeds. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2026-04-25 00:15:48 +02:00
adam closed this issue 2026-04-25 00:15:48 +02:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
authentication
backlog
bug
chapter editor
config-issue
ebooks
encoding/embedding
enhancement
help wanted
listening sessions & progress
planned
possible plugin
progress sync
pull-request
Mirrored from GitHub Pull Request
 sorting/filtering/searching
unable to reproduce
upload
users & permissions
waiting
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam (Adam Melkus)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/audiobookshelf#3474
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?