starred/audiobookshelf
1
0
Fork 0
mirror of https://github.com/advplyr/audiobookshelf.git synced 2026-05-30 23:40:40 +02:00
Code Issues 1.0k Packages Projects Releases 10 Wiki Activity

[PR #1047] [CLOSED] WIP: Show all podcast episodes in podcast view #3441

New Issue
Closed
opened 2026-04-25 00:15:39 +02:00 by adam · 0 comments
adam commented 2026-04-25 00:15:39 +02:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/advplyr/audiobookshelf/pull/1047
Author: @rhyst
Created: 10/5/2022
Status: ❌ Closed

Base: master ← Head: show-all-episodes-in-podcast-view

📝 Commits (1)

📊 Changes

8 files changed (+157 additions, -200 deletions)

View changed files

➖ client/components/modals/podcast/EpisodeFeed.vue (+0 -174)
📝 client/components/tables/podcast/EpisodeTableRow.vue (+47 -9)
📝 client/components/tables/podcast/EpisodesTable.vue (+72 -3)
📝 client/pages/item/_id/index.vue (+1 -7)
📝 server/controllers/PodcastController.js (+10 -1)
📝 server/managers/PodcastManager.js (+7 -0)
📝 server/objects/mediaTypes/Podcast.js (+19 -5)
📝 server/routers/ApiRouter.js (+1 -1)

📄 Description

Very WIP:

  • Removes "search for episode modal"
  • Fetches podcast feed when adding a new podcast
  • Shows all podcast episodes in the episodes list and shows which are downloaded
  • Allows downloading from the episodes list
  • Allows refreshing the episode list

Thought I'd stop there and get feedback before I carried on because I don't normally work with Vue so I am sure this is terrible 😆

Questions based on what I have done:

  • I create PodcastEpisodes for the undownloaded episodes, isthat a good idea?
  • It uses PodcastEpidose.audioFile being null/not null to determine if the podcast is downloaded. Should the downloaded state be its own property?
  • What should the behaviour of the "Latest" page be? I think other podcast apps would show you new epsidoes that you have not downloaded yet. Maybe that should be a filter.
  • WIll this need a new config option alongside autodownload for "autorefresh" the list.
  • This kind of changes the concept of removing/adding episodes. So the episodes are always there, and removing them just deletes the file. This seems like desirable behaviour for podcasts at least?
  • No idea how this interacts with the mobile apps

I am happy to work on it or you can say this is completely the wrong direction.

Screenshot of what it looks like with one episode downloaded:
image

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/advplyr/audiobookshelf/pull/1047 **Author:** [@rhyst](https://github.com/rhyst) **Created:** 10/5/2022 **Status:** ❌ Closed **Base:** `master` ← **Head:** `show-all-episodes-in-podcast-view` --- ### 📝 Commits (1) - [`51b3f0d`](https://github.com/advplyr/audiobookshelf/commit/51b3f0d4654e2d51ccc4699d4b5cd6377267738e) WIP ### 📊 Changes **8 files changed** (+157 additions, -200 deletions) <details> <summary>View changed files</summary> ➖ `client/components/modals/podcast/EpisodeFeed.vue` (+0 -174) 📝 `client/components/tables/podcast/EpisodeTableRow.vue` (+47 -9) 📝 `client/components/tables/podcast/EpisodesTable.vue` (+72 -3) 📝 `client/pages/item/_id/index.vue` (+1 -7) 📝 `server/controllers/PodcastController.js` (+10 -1) 📝 `server/managers/PodcastManager.js` (+7 -0) 📝 `server/objects/mediaTypes/Podcast.js` (+19 -5) 📝 `server/routers/ApiRouter.js` (+1 -1) </details> ### 📄 Description Very WIP: - Removes "search for episode modal" - Fetches podcast feed when adding a new podcast - Shows all podcast episodes in the episodes list and shows which are downloaded - Allows downloading from the episodes list - Allows refreshing the episode list Thought I'd stop there and get feedback before I carried on because I don't normally work with Vue so I am sure this is terrible 😆 Questions based on what I have done: - I create PodcastEpisodes for the undownloaded episodes, isthat a good idea? - It uses PodcastEpidose.audioFile being null/not null to determine if the podcast is downloaded. Should the `downloaded` state be its own property? - What should the behaviour of the "Latest" page be? I think other podcast apps would show you new epsidoes that you have not downloaded yet. Maybe that should be a filter. - WIll this need a new config option alongside autodownload for "autorefresh" the list. - This kind of changes the concept of removing/adding episodes. So the episodes are always there, and removing them just deletes the file. This seems like desirable behaviour for podcasts at least? - No idea how this interacts with the mobile apps I am happy to work on it or you can say this is completely the wrong direction. Screenshot of what it looks like with one episode downloaded: ![image](https://user-images.githubusercontent.com/5313660/194113720-2bf68364-dc58-4c5a-b272-533661189ec1.png) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2026-04-25 00:15:39 +02:00
adam closed this issue 2026-04-25 00:15:40 +02:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
authentication
backlog
bug
chapter editor
config-issue
ebooks
encoding/embedding
enhancement
help wanted
listening sessions & progress
planned
possible plugin
progress sync
pull-request
Mirrored from GitHub Pull Request
 sorting/filtering/searching
unable to reproduce
upload
users & permissions
waiting
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam (Adam Melkus)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/audiobookshelf#3441
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?