starred/audiobookshelf
1
0
Fork 0
mirror of https://github.com/advplyr/audiobookshelf.git synced 2026-05-30 23:40:40 +02:00
Code Issues 1.0k Packages Projects Releases 10 Wiki Activity

[PR #791] [MERGED] fix: disable workbox to prevent failure with service worker #3424

New Issue
Closed
opened 2026-04-25 00:15:36 +02:00 by adam · 0 comments
adam commented 2026-04-25 00:15:36 +02:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/advplyr/audiobookshelf/pull/791
Author: @alexmaras
Created: 6/29/2022
Status: ✅ Merged
Merged: 6/29/2022
Merged by: @advplyr

Base: master ← Head: master

📝 Commits (1)

  • 49d0835 fix: disable workbox to prevent failure with service worker

📊 Changes

1 file changed (+3 additions, -0 deletions)

View changed files

📝 client/nuxt.config.js (+3 -0)

📄 Description

This fixes a variety of lockups and failures to play on both chrome and firefox. Previously, rapidly clickiing through the application with workbox enabled (the default in nuxt production environments) would cause chrome to practically lock up, and firefox would fail to play files until the entire m4b had downloaded.

In theory, this may cause issues with offline caching and playback. I'm not sure what level of offline functionality the audiobookshelf app is supposed to support. This is probably worth a fairly thorough test.

The change makes the service significantly more robust in my short time testing with the change.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/advplyr/audiobookshelf/pull/791 **Author:** [@alexmaras](https://github.com/alexmaras) **Created:** 6/29/2022 **Status:** ✅ Merged **Merged:** 6/29/2022 **Merged by:** [@advplyr](https://github.com/advplyr) **Base:** `master` ← **Head:** `master` --- ### 📝 Commits (1) - [`49d0835`](https://github.com/advplyr/audiobookshelf/commit/49d083523614f1331ca6b0924577b99e61e99f16) fix: disable workbox to prevent failure with service worker ### 📊 Changes **1 file changed** (+3 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `client/nuxt.config.js` (+3 -0) </details> ### 📄 Description This fixes a variety of lockups and failures to play on both chrome and firefox. Previously, rapidly clickiing through the application with workbox enabled (the default in nuxt production environments) would cause chrome to practically lock up, and firefox would fail to play files until the entire m4b had downloaded. In theory, this may cause issues with offline caching and playback. I'm not sure what level of offline functionality the audiobookshelf app is supposed to support. This is probably worth a fairly thorough test. The change makes the service significantly more robust in my short time testing with the change. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2026-04-25 00:15:36 +02:00
adam closed this issue 2026-04-25 00:15:36 +02:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
authentication
backlog
bug
chapter editor
config-issue
ebooks
encoding/embedding
enhancement
help wanted
listening sessions & progress
planned
possible plugin
progress sync
pull-request
Mirrored from GitHub Pull Request
 sorting/filtering/searching
unable to reproduce
upload
users & permissions
waiting
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam (Adam Melkus)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/audiobookshelf#3424
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?