starred/audiobookshelf
1
0
Fork 0
mirror of https://github.com/advplyr/audiobookshelf.git synced 2026-05-30 23:40:40 +02:00
Code Issues 1.0k Packages Projects Releases 10 Wiki Activity

[PR #777] [MERGED] Fix/chapter seek bar #3423

New Issue
Closed
opened 2026-04-25 00:15:36 +02:00 by adam · 0 comments
adam commented 2026-04-25 00:15:36 +02:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/advplyr/audiobookshelf/pull/777
Author: @alexmaras
Created: 6/25/2022
Status: ✅ Merged
Merged: 6/25/2022
Merged by: @advplyr

Base: master ← Head: fix/chapter-seek-bar

📝 Commits (4)

  • 729a756 fix: use total time for chapter name resolution when in chapter track mode
  • 26348cc Merge remote-tracking branch 'fork/master' into fix/chapter-seek-bar
  • e837e5f fix: reuse existing variable
  • 3c347be fix: better variable naming

📊 Changes

1 file changed (+7 additions, -5 deletions)

View changed files

📝 client/components/player/PlayerTrackBar.vue (+7 -5)

📄 Description

One extra fixed missed in https://github.com/advplyr/audiobookshelf/pull/776 - chapter names weren't resolving correctly due to using the track duration rather than the total duration when checking what the name of the chapter was

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/advplyr/audiobookshelf/pull/777 **Author:** [@alexmaras](https://github.com/alexmaras) **Created:** 6/25/2022 **Status:** ✅ Merged **Merged:** 6/25/2022 **Merged by:** [@advplyr](https://github.com/advplyr) **Base:** `master` ← **Head:** `fix/chapter-seek-bar` --- ### 📝 Commits (4) - [`729a756`](https://github.com/advplyr/audiobookshelf/commit/729a756e2135aea2a62dd35a20bc9fe2f929e813) fix: use total time for chapter name resolution when in chapter track mode - [`26348cc`](https://github.com/advplyr/audiobookshelf/commit/26348ccc74a0d61e520c5355f1e237ec12b5dc92) Merge remote-tracking branch 'fork/master' into fix/chapter-seek-bar - [`e837e5f`](https://github.com/advplyr/audiobookshelf/commit/e837e5f78035bec49991123be5ae5afaaac5bf45) fix: reuse existing variable - [`3c347be`](https://github.com/advplyr/audiobookshelf/commit/3c347bef7d40f1d3eac0d3f6f1c854c10ea451cf) fix: better variable naming ### 📊 Changes **1 file changed** (+7 additions, -5 deletions) <details> <summary>View changed files</summary> 📝 `client/components/player/PlayerTrackBar.vue` (+7 -5) </details> ### 📄 Description One extra fixed missed in https://github.com/advplyr/audiobookshelf/pull/776 - chapter names weren't resolving correctly due to using the track duration rather than the total duration when checking what the name of the chapter was --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2026-04-25 00:15:36 +02:00
adam closed this issue 2026-04-25 00:15:36 +02:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
authentication
backlog
bug
chapter editor
config-issue
ebooks
encoding/embedding
enhancement
help wanted
listening sessions & progress
planned
possible plugin
progress sync
pull-request
Mirrored from GitHub Pull Request
 sorting/filtering/searching
unable to reproduce
upload
users & permissions
waiting
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam (Adam Melkus)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/audiobookshelf#3423
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?