starred/audiobookshelf
1
0
Fork 0
mirror of https://github.com/advplyr/audiobookshelf.git synced 2026-05-30 23:40:40 +02:00
Code Issues 1.0k Packages Projects Releases 10 Wiki Activity

[PR #770] [MERGED] Show chapter duration in the "now playing" chapter modal (Issue #767) #3422

New Issue
Closed
opened 2026-04-25 00:15:35 +02:00 by adam · 0 comments
adam commented 2026-04-25 00:15:35 +02:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/advplyr/audiobookshelf/pull/770
Author: @jmt-gh
Created: 6/23/2022
Status: ✅ Merged
Merged: 6/24/2022
Merged by: @advplyr

Base: master ← Head: relative_chapter_times

📝 Commits (3)

  • 48431b1 add support for showing chapter duration in chapters modal
  • f4ee215 Update chapters modal truncate long chapter titles and show chapter duration
  • a9a3423 Update chapter modal for mobile

📊 Changes

1 file changed (+19 additions, -5 deletions)

View changed files

📝 client/components/modals/ChaptersModal.vue (+19 -5)

📄 Description

This PR resolves #767 by adding the chapter duration alongside the chapter start timestamp. I went with showing them both at once rather than a toggle in the settings to change between these, as having it be a toggle could lead to more confusion (forgetting you had it set and not knowing why the times were not linear, or sharing with multiple users who have different preferences). If we end up adding the concept of user-scoped settings in the future, we should look at moving this over to there.

Before
image

After
image

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/advplyr/audiobookshelf/pull/770 **Author:** [@jmt-gh](https://github.com/jmt-gh) **Created:** 6/23/2022 **Status:** ✅ Merged **Merged:** 6/24/2022 **Merged by:** [@advplyr](https://github.com/advplyr) **Base:** `master` ← **Head:** `relative_chapter_times` --- ### 📝 Commits (3) - [`48431b1`](https://github.com/advplyr/audiobookshelf/commit/48431b1c35310f8cb139df86318904c8f7c211d6) add support for showing chapter duration in chapters modal - [`f4ee215`](https://github.com/advplyr/audiobookshelf/commit/f4ee215ad8b48bb3d07328509fd34a8d8f0ba3da) Update chapters modal truncate long chapter titles and show chapter duration - [`a9a3423`](https://github.com/advplyr/audiobookshelf/commit/a9a3423b58727b7bb260f03773f8d1a917e1f313) Update chapter modal for mobile ### 📊 Changes **1 file changed** (+19 additions, -5 deletions) <details> <summary>View changed files</summary> 📝 `client/components/modals/ChaptersModal.vue` (+19 -5) </details> ### 📄 Description This PR resolves #767 by adding the chapter duration alongside the chapter start timestamp. I went with showing them both at once rather than a toggle in the settings to change between these, as having it be a toggle could lead to more confusion (forgetting you had it set and not knowing why the times were not linear, or sharing with multiple users who have different preferences). If we end up adding the concept of user-scoped settings in the future, we should look at moving this over to there. Before ![image](https://user-images.githubusercontent.com/13617455/175191377-b93d8741-2e15-4f12-8fd2-443b2b1f3411.png) After ![image](https://user-images.githubusercontent.com/13617455/175191352-e0eeb56b-1b30-4e84-9c57-989e6d5ffd36.png) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2026-04-25 00:15:35 +02:00
adam closed this issue 2026-04-25 00:15:35 +02:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
authentication
backlog
bug
chapter editor
config-issue
ebooks
encoding/embedding
enhancement
help wanted
listening sessions & progress
planned
possible plugin
progress sync
pull-request
Mirrored from GitHub Pull Request
 sorting/filtering/searching
unable to reproduce
upload
users & permissions
waiting
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam (Adam Melkus)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/audiobookshelf#3422
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?