starred/audiobookshelf
1
0
Fork 0
mirror of https://github.com/advplyr/audiobookshelf.git synced 2026-05-30 23:40:40 +02:00
Code Issues 1.0k Packages Projects Releases 10 Wiki Activity

[PR #755] [MERGED] Update Sessions page to have a matching "settings UI" #3417

New Issue
Closed
opened 2026-04-25 00:15:34 +02:00 by adam · 0 comments
adam commented 2026-04-25 00:15:34 +02:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/advplyr/audiobookshelf/pull/755
Author: @jmt-gh
Created: 6/19/2022
Status: ✅ Merged
Merged: 6/20/2022
Merged by: @advplyr

Base: master ← Head: update_sessions_table

📝 Commits (3)

  • 5525587 update sessions table to match other settings tables UI
  • fdfaa7e unify on 'Listening Sessions'
  • 50b1098 add back in empty state

📊 Changes

2 files changed (+54 additions, -54 deletions)

View changed files

📝 client/components/app/ConfigSideNav.vue (+1 -1)
📝 client/pages/config/sessions.vue (+53 -53)

📄 Description

Similar to #748 , the UI on this page was slightly different from the other ones. In both of these, I think there is room for improvement in a future PR on the headers (when there is a picker with a label, it feels like there is a lot of whitespace because we align it to the right. We also had enough room to unify on the left nav + page h1, so I updated that.

Future Work: We should probably extract out the "Header" on these pages to it's own component, and standardize the controls for search + input select

Before:
image

After:
image

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/advplyr/audiobookshelf/pull/755 **Author:** [@jmt-gh](https://github.com/jmt-gh) **Created:** 6/19/2022 **Status:** ✅ Merged **Merged:** 6/20/2022 **Merged by:** [@advplyr](https://github.com/advplyr) **Base:** `master` ← **Head:** `update_sessions_table` --- ### 📝 Commits (3) - [`5525587`](https://github.com/advplyr/audiobookshelf/commit/55255875137abd0d11725cc854a640e5026c7259) update sessions table to match other settings tables UI - [`fdfaa7e`](https://github.com/advplyr/audiobookshelf/commit/fdfaa7eba47ea295d3535d81fd119e1ec9dff2af) unify on 'Listening Sessions' - [`50b1098`](https://github.com/advplyr/audiobookshelf/commit/50b1098797d096ff271e25ca638efee8eed946ff) add back in empty state ### 📊 Changes **2 files changed** (+54 additions, -54 deletions) <details> <summary>View changed files</summary> 📝 `client/components/app/ConfigSideNav.vue` (+1 -1) 📝 `client/pages/config/sessions.vue` (+53 -53) </details> ### 📄 Description Similar to #748 , the UI on this page was slightly different from the other ones. In both of these, I think there is room for improvement in a future PR on the headers (when there is a picker with a label, it _feels_ like there is a lot of whitespace because we align it to the right. We also had enough room to unify on the left nav + page h1, so I updated that. Future Work: We should probably extract out the "Header" on these pages to it's own component, and standardize the controls for search + input select Before: ![image](https://user-images.githubusercontent.com/13617455/174492554-9b5aa6e7-06e2-496d-911e-07b0399bbdba.png) After: ![image](https://user-images.githubusercontent.com/13617455/174492540-4f6a60cc-b584-48e2-9dc4-55b893573284.png) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2026-04-25 00:15:34 +02:00
adam closed this issue 2026-04-25 00:15:34 +02:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
authentication
backlog
bug
chapter editor
config-issue
ebooks
encoding/embedding
enhancement
help wanted
listening sessions & progress
planned
possible plugin
progress sync
pull-request
Mirrored from GitHub Pull Request
 sorting/filtering/searching
unable to reproduce
upload
users & permissions
waiting
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam (Adam Melkus)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/audiobookshelf#3417
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?