starred/audiobookshelf
1
0
Fork 0
mirror of https://github.com/advplyr/audiobookshelf.git synced 2026-05-30 23:40:40 +02:00
Code Issues 1.0k Packages Projects Releases 10 Wiki Activity

[PR #681] [MERGED] Fix cover art not being generated for M4B export #3392

New Issue
Closed
opened 2026-04-25 00:15:28 +02:00 by adam · 0 comments
adam commented 2026-04-25 00:15:28 +02:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/advplyr/audiobookshelf/pull/681
Author: @jmt-gh
Created: 6/5/2022
Status: ✅ Merged
Merged: 6/5/2022
Merged by: @advplyr

Base: master ← Head: m4b_no_coverart

📝 Commits (1)

  • 3bc3914 Fix cover art not being generated for m4b export

📊 Changes

1 file changed (+2 additions, -2 deletions)

View changed files

📝 server/managers/AbMergeManager.js (+2 -2)

📄 Description

This commit fixes an issue where cover art was not being generated properly when creating an M4B audiobook from MP3 files. Thanks to @advplyr for pointing out what the actual fix was for this

More context can be found in discord:
https://discord.com/channels/942908292873723984/981321213882282035/982777444631195681

These are available in the discord conversation as well, but here are what the covers look like now, in various forms:
image
image
image
image

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/advplyr/audiobookshelf/pull/681 **Author:** [@jmt-gh](https://github.com/jmt-gh) **Created:** 6/5/2022 **Status:** ✅ Merged **Merged:** 6/5/2022 **Merged by:** [@advplyr](https://github.com/advplyr) **Base:** `master` ← **Head:** `m4b_no_coverart` --- ### 📝 Commits (1) - [`3bc3914`](https://github.com/advplyr/audiobookshelf/commit/3bc3914fd97e8be0589c5a7538b819946204e830) Fix cover art not being generated for m4b export ### 📊 Changes **1 file changed** (+2 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `server/managers/AbMergeManager.js` (+2 -2) </details> ### 📄 Description This commit fixes an issue where cover art was not being generated properly when creating an M4B audiobook from MP3 files. Thanks to @advplyr for pointing out what the actual fix was for this More context can be found in discord: https://discord.com/channels/942908292873723984/981321213882282035/982777444631195681 These are available in the discord conversation as well, but here are what the covers look like now, in various forms: ![image](https://user-images.githubusercontent.com/13617455/172030412-eacffcfe-8a9a-422a-b691-c8d3af68249f.png) ![image](https://user-images.githubusercontent.com/13617455/172030416-b25cf78b-0410-49f3-9d80-2a41221ef03e.png) ![image](https://user-images.githubusercontent.com/13617455/172030420-32323e20-4a2c-4524-b5ba-e424e0185888.png) ![image](https://user-images.githubusercontent.com/13617455/172030422-c7a8df8f-7fa7-45c5-bdcc-efccfd3ff0ac.png) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2026-04-25 00:15:28 +02:00
adam closed this issue 2026-04-25 00:15:28 +02:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
authentication
backlog
bug
chapter editor
config-issue
ebooks
encoding/embedding
enhancement
help wanted
listening sessions & progress
planned
possible plugin
progress sync
pull-request
Mirrored from GitHub Pull Request
 sorting/filtering/searching
unable to reproduce
upload
users & permissions
waiting
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam (Adam Melkus)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/audiobookshelf#3392
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?