starred/audiobookshelf
1
0
Fork 0
mirror of https://github.com/advplyr/audiobookshelf.git synced 2026-05-30 23:40:40 +02:00
Code Issues 1.0k Packages Projects Releases 10 Wiki Activity

[PR #632] [MERGED] URGENT: Fix to serious bug #3386

New Issue
Closed
opened 2026-04-25 00:15:27 +02:00 by adam · 0 comments
adam commented 2026-04-25 00:15:27 +02:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/advplyr/audiobookshelf/pull/632
Author: @cassieesposito
Created: 5/25/2022
Status: ✅ Merged
Merged: 5/25/2022
Merged by: @advplyr

Base: master ← Head: getBookDataFromDir-refactor

📝 Commits (3)

  • b22173a Undoing changes caused by linter run amok
  • 31fd75a Merge branch 'getBookDataFromDir-refactor' of github.com:cassieesposito/audiobookshelf into getBookDataFromDir-refactor
  • 3153bdc Fixed bug that caused scanner to fail to get title when subtitle parsing is off, refactored possibly confusing variable declarations.

📊 Changes

1 file changed (+8 additions, -5 deletions)

View changed files

📝 server/utils/scandir.js (+8 -5)

📄 Description

Following the refactor of getBookDataFromDir, if subtitle parsing is turned off, then the title is not imported at all. This fixes it and also resolves your confusion about variable scope.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/advplyr/audiobookshelf/pull/632 **Author:** [@cassieesposito](https://github.com/cassieesposito) **Created:** 5/25/2022 **Status:** ✅ Merged **Merged:** 5/25/2022 **Merged by:** [@advplyr](https://github.com/advplyr) **Base:** `master` ← **Head:** `getBookDataFromDir-refactor` --- ### 📝 Commits (3) - [`b22173a`](https://github.com/advplyr/audiobookshelf/commit/b22173a63174acda8a966bc12b264ac6f87b9267) Undoing changes caused by linter run amok - [`31fd75a`](https://github.com/advplyr/audiobookshelf/commit/31fd75a895b9015b54d4523c0b454e332796fdcd) Merge branch 'getBookDataFromDir-refactor' of github.com:cassieesposito/audiobookshelf into getBookDataFromDir-refactor - [`3153bdc`](https://github.com/advplyr/audiobookshelf/commit/3153bdc5bb71b9d28bc469bdc65978cd05a8d587) Fixed bug that caused scanner to fail to get title when subtitle parsing is off, refactored possibly confusing variable declarations. ### 📊 Changes **1 file changed** (+8 additions, -5 deletions) <details> <summary>View changed files</summary> 📝 `server/utils/scandir.js` (+8 -5) </details> ### 📄 Description Following the refactor of getBookDataFromDir, if subtitle parsing is turned off, then the title is not imported at all. This fixes it and also resolves your confusion about variable scope. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2026-04-25 00:15:27 +02:00
adam closed this issue 2026-04-25 00:15:27 +02:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
authentication
backlog
bug
chapter editor
config-issue
ebooks
encoding/embedding
enhancement
help wanted
listening sessions & progress
planned
possible plugin
progress sync
pull-request
Mirrored from GitHub Pull Request
 sorting/filtering/searching
unable to reproduce
upload
users & permissions
waiting
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam (Adam Melkus)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/audiobookshelf#3386
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?