starred/audiobookshelf
1
0
Fork 0
mirror of https://github.com/advplyr/audiobookshelf.git synced 2026-05-30 23:40:40 +02:00
Code Issues 1.0k Packages Projects Releases 10 Wiki Activity

[PR #512] [MERGED] Log full path when warning about empty root #3364

New Issue
Closed
opened 2026-04-25 00:15:22 +02:00 by adam · 0 comments
adam commented 2026-04-25 00:15:22 +02:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/advplyr/audiobookshelf/pull/512
Author: @selfhost-alt
Created: 4/26/2022
Status: ✅ Merged
Merged: 4/26/2022
Merged by: @advplyr

Base: master ← Head: log-empty-folder-path-on-scan

📝 Commits (1)

  • 22900a3 Log full path when warning about empty root

📊 Changes

1 file changed (+1 additions, -1 deletions)

View changed files

📝 server/utils/scandir.js (+1 -1)

📄 Description

When a library has a root folder containing no media items, a warning is logged when scanning.

[2022-04-25T22:28:15.859Z] ERROR: Root path has no media folders 0

However, that 0 isn't really helpful since we already know the root path is empty.

This PR updates the log message to instead log the folder path:

[2022-04-25T22:26:52.842Z] ERROR: Root path has no media folders: C:/code/audiobookshelf/audiobooks2

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/advplyr/audiobookshelf/pull/512 **Author:** [@selfhost-alt](https://github.com/selfhost-alt) **Created:** 4/26/2022 **Status:** ✅ Merged **Merged:** 4/26/2022 **Merged by:** [@advplyr](https://github.com/advplyr) **Base:** `master` ← **Head:** `log-empty-folder-path-on-scan` --- ### 📝 Commits (1) - [`22900a3`](https://github.com/advplyr/audiobookshelf/commit/22900a3f679847e2d8e81d7295bd5eee2434f5e1) Log full path when warning about empty root ### 📊 Changes **1 file changed** (+1 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `server/utils/scandir.js` (+1 -1) </details> ### 📄 Description When a library has a root folder containing no media items, a warning is logged when scanning. ``` [2022-04-25T22:28:15.859Z] ERROR: Root path has no media folders 0 ``` However, that `0` isn't really helpful since we already know the root path is empty. This PR updates the log message to instead log the folder path: ``` [2022-04-25T22:26:52.842Z] ERROR: Root path has no media folders: C:/code/audiobookshelf/audiobooks2 ``` --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2026-04-25 00:15:22 +02:00
adam closed this issue 2026-04-25 00:15:22 +02:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
authentication
backlog
bug
chapter editor
config-issue
ebooks
encoding/embedding
enhancement
help wanted
listening sessions & progress
planned
possible plugin
progress sync
pull-request
Mirrored from GitHub Pull Request
 sorting/filtering/searching
unable to reproduce
upload
users & permissions
waiting
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam (Adam Melkus)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/audiobookshelf#3364
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?