starred/audiobookshelf
1
0
Fork 0
mirror of https://github.com/advplyr/audiobookshelf.git synced 2026-05-30 23:40:40 +02:00
Code Issues 1.0k Packages Projects Releases 10 Wiki Activity

[PR #351] [CLOSED] Basic SSO support (openid connect) #3339

New Issue
Closed
opened 2026-04-25 00:15:16 +02:00 by adam · 0 comments
adam commented 2026-04-25 00:15:16 +02:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/advplyr/audiobookshelf/pull/351
Author: @davidLeimroth
Created: 2/6/2022
Status: ❌ Closed

Base: master ← Head: oidc

📝 Commits (10+)

📊 Changes

35 files changed (+19937 additions, -89 deletions)

View changed files

📝 client/components/app/BookShelfCategorized.vue (+1 -1)
📝 client/components/app/ConfigSideNav.vue (+5 -0)
📝 client/components/app/LazyBookshelf.vue (+2 -2)
📝 client/components/app/StreamContainer.vue (+1 -1)
📝 client/components/cards/AudiobookSearchCard.vue (+1 -1)
📝 client/components/cards/SeriesSearchCard.vue (+1 -1)
📝 client/components/modals/EditCollectionModal.vue (+1 -1)
📝 client/components/modals/edit-tabs/Cover.vue (+1 -1)
📝 client/components/modals/edit-tabs/Match.vue (+1 -1)
📝 client/components/tables/CollectionBooksTable.vue (+1 -1)
📝 client/layouts/default.vue (+3 -0)
📝 client/nuxt.config.js (+2 -1)
📝 client/package-lock.json (+19192 -20)
📝 client/pages/audiobook/_id/index.vue (+1 -1)
📝 client/pages/batch/index.vue (+1 -1)
📝 client/pages/collection/_id.vue (+1 -1)
📝 client/pages/config/backups.vue (+2 -2)
📝 client/pages/config/index.vue (+1 -1)
📝 client/pages/config/log.vue (+2 -2)
➕ client/pages/config/sso.vue (+208 -0)

...and 15 more files

📄 Description

I started adding sso support via passport js yesterday.
Users are generated as guests on the fly, if they don't exist.
There are a couple of things missing, like:

  • hiding the sso button in the web ui if sso is not configured. But as it was my first time looking into vue today, it was out of scope for now.
  • being able to change the password, if the user was generated via sso access create a flow for users logging in for the first time via sso with the ability to choose username and/or password
  • add the ability for existing users to link their "sso account"

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/advplyr/audiobookshelf/pull/351 **Author:** [@davidLeimroth](https://github.com/davidLeimroth) **Created:** 2/6/2022 **Status:** ❌ Closed **Base:** `master` ← **Head:** `oidc` --- ### 📝 Commits (10+) - [`e7f034c`](https://github.com/advplyr/audiobookshelf/commit/e7f034ce597fd1b26368d13f742179686c21d39b) added sso via passport js - [`b7bb124`](https://github.com/advplyr/audiobookshelf/commit/b7bb124eb0602188cc697d28f222f4bf532fbdaf) removed unnecessary dependency - [`d2395a5`](https://github.com/advplyr/audiobookshelf/commit/d2395a5896d34a8c4250942adfd2daff962ad330) removed unnecessary dependency - [`2cd622c`](https://github.com/advplyr/audiobookshelf/commit/2cd622cb896a1096b901d827503470f5540c835c) added a new settings page for sso - [`f5cd93c`](https://github.com/advplyr/audiobookshelf/commit/f5cd93c6dba332fcd4e744ff73af10938d386964) added more settings - [`b66e0f6`](https://github.com/advplyr/audiobookshelf/commit/b66e0f6b242c8fc017406b21ac52271a631b106c) fixed a small mistake - [`27f498f`](https://github.com/advplyr/audiobookshelf/commit/27f498ffaeb0d183f7167ddd4b7dad29a78014b6) Merge branch 'master' of https://github.com/advplyr/audiobookshelf into oidc - [`53e6c9f`](https://github.com/advplyr/audiobookshelf/commit/53e6c9f91310a0484f60bccba7b5cfc5c198abd0) removed sso related code from client/store/index.js and renamed some functions in client/store/sso.js - [`dbf09ad`](https://github.com/advplyr/audiobookshelf/commit/dbf09ad451ae96558020b2a167a680353a96c218) added a SSOSettings class - [`e61d7f1`](https://github.com/advplyr/audiobookshelf/commit/e61d7f1ee8fe2d2776ea6a8d2403b164ad49dd29) modified Db.js to store sso settings ### 📊 Changes **35 files changed** (+19937 additions, -89 deletions) <details> <summary>View changed files</summary> 📝 `client/components/app/BookShelfCategorized.vue` (+1 -1) 📝 `client/components/app/ConfigSideNav.vue` (+5 -0) 📝 `client/components/app/LazyBookshelf.vue` (+2 -2) 📝 `client/components/app/StreamContainer.vue` (+1 -1) 📝 `client/components/cards/AudiobookSearchCard.vue` (+1 -1) 📝 `client/components/cards/SeriesSearchCard.vue` (+1 -1) 📝 `client/components/modals/EditCollectionModal.vue` (+1 -1) 📝 `client/components/modals/edit-tabs/Cover.vue` (+1 -1) 📝 `client/components/modals/edit-tabs/Match.vue` (+1 -1) 📝 `client/components/tables/CollectionBooksTable.vue` (+1 -1) 📝 `client/layouts/default.vue` (+3 -0) 📝 `client/nuxt.config.js` (+2 -1) 📝 `client/package-lock.json` (+19192 -20) 📝 `client/pages/audiobook/_id/index.vue` (+1 -1) 📝 `client/pages/batch/index.vue` (+1 -1) 📝 `client/pages/collection/_id.vue` (+1 -1) 📝 `client/pages/config/backups.vue` (+2 -2) 📝 `client/pages/config/index.vue` (+1 -1) 📝 `client/pages/config/log.vue` (+2 -2) ➕ `client/pages/config/sso.vue` (+208 -0) _...and 15 more files_ </details> ### 📄 Description I started adding sso support via passport js yesterday. Users are generated as guests on the fly, if they don't exist. There are a couple of things missing, like: * ~hiding the sso button in the web ui if sso is not configured. But as it was my first time looking into vue today, it was out of scope for now.~ * ~being able to change the password, if the user was generated via sso access~ create a flow for users logging in for the first time via sso with the ability to choose username and/or password * add the ability for existing users to link their "sso account" --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2026-04-25 00:15:16 +02:00
adam closed this issue 2026-04-25 00:15:16 +02:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
authentication
backlog
bug
chapter editor
config-issue
ebooks
encoding/embedding
enhancement
help wanted
listening sessions & progress
planned
possible plugin
progress sync
pull-request
Mirrored from GitHub Pull Request
 sorting/filtering/searching
unable to reproduce
upload
users & permissions
waiting
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam (Adam Melkus)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/audiobookshelf#3339
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?