starred/audiobookshelf
1
0
Fork 0
mirror of https://github.com/advplyr/audiobookshelf.git synced 2026-05-30 23:40:40 +02:00
Code Issues 1.0k Packages Projects Releases 10 Wiki Activity

[PR #240] [MERGED] Remove sharp in favor of ffmpeg, fallback to cover #3325

New Issue
Closed
opened 2026-04-25 00:15:13 +02:00 by adam · 0 comments
adam commented 2026-04-25 00:15:13 +02:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/advplyr/audiobookshelf/pull/240
Author: @keaganhilliard
Created: 12/13/2021
Status: ✅ Merged
Merged: 12/13/2021
Merged by: @advplyr

Base: master ← Head: master

📝 Commits (2)

  • d6ae50f Remove sharp in favor of ffmpeg, fallback to cover
  • 57b464c Fix:Set full cover path for extracted covers & use temp fix to update books without a full cover path

📊 Changes

6 files changed (+71 additions, -35 deletions)

View changed files

📝 package.json (+0 -1)
📝 server/CacheManager.js (+14 -14)
📝 server/controllers/BookController.js (+12 -2)
📝 server/objects/Audiobook.js (+19 -1)
📝 server/utils/ffmpegHelpers.js (+26 -1)
➖ server/utils/resizeImage.js (+0 -16)

📄 Description

Since you were having issues getting sharp to work... I made ffmpeg work instead. Also fixed a couple of issues that I noticed in testing with my library. Namely embedded covers that have been extracted don't have a fullPath so I'm falling back to use the cover attribute if that fullPath is null.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/advplyr/audiobookshelf/pull/240 **Author:** [@keaganhilliard](https://github.com/keaganhilliard) **Created:** 12/13/2021 **Status:** ✅ Merged **Merged:** 12/13/2021 **Merged by:** [@advplyr](https://github.com/advplyr) **Base:** `master` ← **Head:** `master` --- ### 📝 Commits (2) - [`d6ae50f`](https://github.com/advplyr/audiobookshelf/commit/d6ae50f89ab8b06e7eac19dcd1df80630b55863b) Remove sharp in favor of ffmpeg, fallback to cover - [`57b464c`](https://github.com/advplyr/audiobookshelf/commit/57b464c867da8a8e12ea66cc1a087615f4321464) Fix:Set full cover path for extracted covers & use temp fix to update books without a full cover path ### 📊 Changes **6 files changed** (+71 additions, -35 deletions) <details> <summary>View changed files</summary> 📝 `package.json` (+0 -1) 📝 `server/CacheManager.js` (+14 -14) 📝 `server/controllers/BookController.js` (+12 -2) 📝 `server/objects/Audiobook.js` (+19 -1) 📝 `server/utils/ffmpegHelpers.js` (+26 -1) ➖ `server/utils/resizeImage.js` (+0 -16) </details> ### 📄 Description Since you were having issues getting sharp to work... I made ffmpeg work instead. Also fixed a couple of issues that I noticed in testing with my library. Namely embedded covers that have been extracted don't have a fullPath so I'm falling back to use the cover attribute if that fullPath is null. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2026-04-25 00:15:13 +02:00
adam closed this issue 2026-04-25 00:15:13 +02:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
authentication
backlog
bug
chapter editor
config-issue
ebooks
encoding/embedding
enhancement
help wanted
listening sessions & progress
planned
possible plugin
progress sync
pull-request
Mirrored from GitHub Pull Request
 sorting/filtering/searching
unable to reproduce
upload
users & permissions
waiting
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam (Adam Melkus)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/audiobookshelf#3325
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?