mirror of
https://github.com/advplyr/audiobookshelf.git
synced 2026-05-30 23:40:40 +02:00
[Bug]: Quick Embed does not check to see if file is open in external player through a SMB share and reports successful embedding #2975
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @ZLoth on GitHub (Aug 28, 2025).
What happened?
I am cleaning up the chapters in my audiobook collection. I am usually opening that file from the SMB share on my TrueNAS server to my Windows 11 computer using MPC-HC (64 bit) or VLC (64-bit) which "locks" the file from modification from other programs. This is so that I can find the appropriate time stamps for missing sections such as "Opening Credits", "Dedicaton", "Epigraph", and so on. Once I find those time stamps, I use ABS → Tools → Quick Embed to upload the modified chapter data back into the M4B file. If I forget to close the external player, the data isn't updated.
What did you expect to happen?
There needs to be a check to see if the file is in use before attempting to embed the data. If so, a error should be thrown.
Steps to reproduce the issue
STEPS TO REPLICATE:
/audiobooks/Audiobooks/Non-Fiction/Horologicon - A Day's Jaunt Through the Lost Words of the English Language/Horologicon - A Day's Jaunt Through the Lost Words of the English Language.m4b)/audiobooks/Audiobooks/Non-Fiction/Horologicon - A Day's Jaunt Through the Lost Words of the English Language/Horologicon - A Day's Jaunt Through the Lost Words of the English Language.tmp.m4b/audiobooks/Audiobooks/Non-Fiction/Horologicon - A Day's Jaunt Through the Lost Words of the English Language/Horologicon - A Day's Jaunt Through the Lost Words of the English Language.m4bHOWEVER, the copy actually failed. Here is the log extract:
When I closed the player and tried again, the embed was successful:
Here is the recording of the issue:
https://github.com/user-attachments/assets/bba2e4c0-3093-4716-af63-8a2b391bd286
Audiobookshelf version
2.29.0, also earlier versions
How are you running audiobookshelf?
Docker
What OS is your Audiobookshelf server hosted from?
Other (list in "Additional Notes" box)
If the issue is being seen in the UI, what browsers are you seeing the problem on?
None
Logs
Additional Notes
This is running in a Docker Contain running TrueNAS 25.04.2.1. I am connected via a Windows 11 system using a SMB share on my TrueNAS Server.
Log File.zip