starred/audiobookshelf
1
0
Fork 0
mirror of https://github.com/advplyr/audiobookshelf.git synced 2026-05-30 23:40:40 +02:00
Code Issues 1.0k Packages Projects Releases 10 Wiki Activity

[Bug]: No correct translation on toast message #2959

New Issue
Open
opened 2026-04-25 00:12:20 +02:00 by adam · 2 comments
adam commented 2026-04-25 00:12:20 +02:00
Owner
Copy Link
Copy Source

Originally created by @WangLei1993 on GitHub (Aug 19, 2025).

What happened?

When I use in Chinese but found some toast message is English. And then I search some source code, some toast message without current translation like below screenshots:

Image Image Image Image

What did you expect to happen?

Make all correct translation like other toast message.

Steps to reproduce the issue

Audiobookshelf version

v2.28.0 in use or master code in Github

How are you running audiobookshelf?

Docker

What OS is your Audiobookshelf server hosted from?

Windows

If the issue is being seen in the UI, what browsers are you seeing the problem on?

None

Logs

Additional Notes

No response

Originally created by @WangLei1993 on GitHub (Aug 19, 2025). ### What happened? When I use in Chinese but found some toast message is English. And then I search some source code, some toast message without current translation like below screenshots: <img width="859" height="422" alt="Image" src="https://github.com/user-attachments/assets/118aa346-d9d0-4954-a0f2-9d2b45545578" /> <img width="767" height="813" alt="Image" src="https://github.com/user-attachments/assets/7bb925ab-ea24-4d46-904c-557ec0a4e7f6" /> <img width="1028" height="933" alt="Image" src="https://github.com/user-attachments/assets/5339c78c-4aa8-45fb-bf64-d5d518892daf" /> <img width="1087" height="908" alt="Image" src="https://github.com/user-attachments/assets/e31c4f66-9d62-4749-ae95-dfdeb0d5a13c" /> ### What did you expect to happen? Make all correct translation like other toast message. ### Steps to reproduce the issue 1. ### Audiobookshelf version v2.28.0 in use or master code in Github ### How are you running audiobookshelf? Docker ### What OS is your Audiobookshelf server hosted from? Windows ### If the issue is being seen in the UI, what browsers are you seeing the problem on? None ### Logs ```shell ``` ### Additional Notes _No response_
adam added the bug label 2026-04-25 00:12:21 +02:00
adam commented 2026-04-25 00:12:21 +02:00
Author
Owner
Copy Link
Copy Source

@advplyr commented on GitHub (Aug 19, 2025):

Some notes on these

  1. The bulk quick match needs to be updated to use a notification task instead of toasts. I think we should automatically undo the selection after starting so that can be seen in the appbar.
  2. The form needs to get updated to highlight text fields with errors in red with a "Required" message instead of using toasts for errors. We are working on a new frontend so this probably won't happen for a while.
  3. I removed this toast. There are still some unnecessary toasts throughout the app and this was one of them.
  4. I added an "Episode updated" translation. Although the UI/UX for episode matching should probably get re-done. It is not clear that the episode is going to be updated when selecting a match.
@advplyr commented on GitHub (Aug 19, 2025): Some notes on these 1. The bulk quick match needs to be updated to use a notification task instead of toasts. I think we should automatically undo the selection after starting so that can be seen in the appbar. 2. The form needs to get updated to highlight text fields with errors in red with a "Required" message instead of using toasts for errors. We are working on a new frontend so this probably won't happen for a while. 3. I removed this toast. There are still some unnecessary toasts throughout the app and this was one of them. 4. I added an "Episode updated" translation. Although the UI/UX for episode matching should probably get re-done. It is not clear that the episode is going to be updated when selecting a match.
adam commented 2026-04-25 00:12:22 +02:00
Author
Owner
Copy Link
Copy Source

@WangLei1993 commented on GitHub (Aug 20, 2025):

First, thank you for answering and changing code so fast. And then, these four screenshots just a part of toast without current translation, just some error I found in the first few search pages. And any others, you could just to search '$toast' in code to find which line should be modify. But as what you said, there will be some design changes. So after a few days and the new version published, I'll check the code. If find the same question, I'll mark it in this issue.

@WangLei1993 commented on GitHub (Aug 20, 2025): First, thank you for answering and changing code so fast. And then, these four screenshots just a part of toast without current translation, just some error I found in the first few search pages. And any others, you could just to search '$toast' in code to find which line should be modify. But as what you said, there will be some design changes. So after a few days and the new version published, I'll check the code. If find the same question, I'll mark it in this issue.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
authentication
backlog
bug
chapter editor
config-issue
ebooks
encoding/embedding
enhancement
help wanted
listening sessions & progress
planned
possible plugin
progress sync
pull-request
Mirrored from GitHub Pull Request
 sorting/filtering/searching
unable to reproduce
upload
users & permissions
waiting
No Label bug
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam (Adam Melkus)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/audiobookshelf#2959
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?