mirror of
https://github.com/advplyr/audiobookshelf.git
synced 2026-05-30 23:40:40 +02:00
[Bug]: Embed Metadata removes some existing but not overlapping metadata #2947
Closed
opened 2026-04-25 00:12:10 +02:00 by adam
·
6 comments
No Branch/Tag Specified
master
book_tags_genres_dedupe
episode_download_fallback
Issue-4540-SortBy-StartedDate-and-FinishedDate
episode_meta_tagging
fix_authorize_race_condition
redirect_transcode_requests
progress_updated_sort
fix_ereader_socket_event
fix_change_empty_root_password
fix_podcast_session_track_index
fix_set_token
session_modal_user
localize_durations
fix_oidc_create_user
jwt_auth_refactor
fix_scanner_deleting_single_file_books
fix_mediaprogress_updatedat_2
experimental_next_client
podcast_episode_duration
episode-timestamps-clickable
book_author_secondary_sort_title
podcast_useragents
pathexists_user_access
fix_pathexists_join
book_author_secondary_sort
clean_duplicate_mediaprogress
sanitize_html_description
trix_prevent_attachments
check_path_api_fix
fix_mediaprogress_updatedat
increase_express_json_limit
fix_dockerfile_nunicode
search_episodes
audiobook_tools_update
episode_secondary_sorts
hls_stream_url_update
new_session_track_endpoint
audiobook_tools_enhancements
watcher_rescans_update
player_track_tooltip
fix_exclude_prefixes_crash
socket_item_events
fix_podcast_episode_scanner_promise
new_stats_controller
count_cache_for_userpermissions
parsing-opf-v3
validate_migration_files
fix-quick-match-all-crash
fix-chapter-end-sleep-timer
stringify_sequelize_query
remove-col-ambiguity
fix_next_prev_edit_description
details_trim_whitespace
fix_content_url_basepath
fix_logger_fatal
progress_bar_visibility
batch-edit-populate-map-details
feed_generator_updates
bookmark-modal-updates
migrate-library-item-in-scanner
migrate-new-library-items
migrate-podcasts-new-library-item-2
migrate-podcasts-new-library-item
fix-remove-episode-from-playlist
playback-session-use-new-library-item
refactor-library-item
fix-heatmap-caption
feed-episodes-upsert
share-media-player-media-session-api
remove-old-playlist
remove_old_collection_object
plugin-implementation-demo
feed_migration
refactor-feeds-from-item
fix_remove_authors_no_books
v2.17.3-fk-constraints-migration
migrations-first-upgrade
sqlite_2
feature/nuxt-target-server
waveform
sqlite
playlists
video
v2.35.1
v2.35.0
v2.34.0
v2.33.2
v2.33.1
v2.33.0
v2.32.1
v2.32.0
v2.31.0
v2.30.0
v2.29.0
v2.28.0
v2.27.0
v2.26.3
v2.26.2
v2.26.1
v2.26.0
v2.25.1
v2.25.0
v2.24.0
v2.23.0
v2.22.0
v2.21.0
v2.20.0
v2.19.5
v2.19.4
v2.19.3
v2.19.2
v2.19.1
v2.19.0
v2.18.1
v2.18.0
v2.17.7
v2.17.6
v2.17.5
v2.17.4
v2.17.3
v2.17.2
v2.17.1
v2.17.0
v2.16.2
v2.16.1
v2.16.0
v2.15.1
v2.15.0
v2.14.0
v2.13.4
v2.13.3
v2.13.2
v2.13.1
v2.13.0
v2.12.3
v2.12.2
v2.12.1
v2.12.0
v2.11.0
v2.10.1
v2.10.0
v2.9.0
v2.8.1
v2.8.0
v2.7.2
v2.7.1
v2.7.0
v2.6.0
v2.5.0
v2.4.4
v2.4.3
v2.4.2
v2.4.1
v2.4.0
v2.3.5
v2.3.4
v2.3.3
v2.3.2
v2.3.1
v2.3.0
v2.2.23
v2.2.22
v2.2.21
v2.2.20
v2.2.19
v2.2.18
v2.2.17
v2.2.16
v2.2.15
v2.2.14
v2.2.13
v2.2.12
v2.2.11
v2.2.10
v2.2.9
v2.2.8
v2.2.7
v2.2.6
v2.2.5
v2.2.4
v2.2.3
v2.2.2
v2.2.1
v2.2.0
v2.1.5
v2.1.4
v2.1.3
v2.1.2
v2.1.1
v2.1.0
v2.0.24
v2.0.23
v2.0.22
v2.0.21
v2.0.20
v2.0.19
v2.0.18
v2.0.17
v2.0.16
v2.0.15
v2.0.14
v2.0.13
v2.0.12
v2.0.11
v2.0.10
v2.0.9
v2.0.8
v2.0.7
v2.0.6
v2.0.5
v2.0.4
v2.0.3
v2.0.2
v2.0.1
v1.7.2
v1.7.1
v1.7.0
v1.6.0
v1.5.5
v1.5.0
v1.4.11
v1.4.9
v1.4.7
v1.4.6
v1.4.4
v1.4.2
v1.4.0
v1.4.1
v1.3.4
v1.3.3
v1.3.1
v1.2.8
v1.2.6
v1.2.5
v1.2.4
v1.2.1
v1.1.15
v1.1.14
v1.1.13
v1.1.12
v1.1.11
v1.1.10
v1.1.9
v1.1.8
v1.0.0
0.9.61-beta.0
0.9.61-beta
Labels
Clear labels
authentication
backlog
bug
chapter editor
config-issue
ebooks
encoding/embedding
enhancement
help wanted
listening sessions & progress
planned
possible plugin
progress sync
pull-request
sorting/filtering/searching
unable to reproduce
upload
users & permissions
waiting
Mirrored from GitHub Pull Request
No Label
bug
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
adam (Adam Melkus)
Clear assignees
No Assignees
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: starred/audiobookshelf#2947
Reference in New Issue
Block a user
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @ListerD000169 on GitHub (Aug 12, 2025).
What happened?
I was testing the embed metadata feature, and it did a great job of adding/updating much of the metadata in an m4b file. However, it also removed metadata that was not on the list of items to be updated. In my case, I noticed that #Series and #Series-Part were removed from the file. These are the tag names used in the default view of mp3tag. I had been using this field for the book series name (#Series) and number (#Series-Part). While I expected embed metadata to update and overwrite tags listed in the Metadata to embed table, I did not expect it to delete tags not in that list. I did verify that this is not an issue with the grouping tag, as that goes to what mp3tag refers to as Content Group.
What did you expect to happen?
I expected tags not listed in the Metadata to embed table to be left in place.
Steps to reproduce the issue
Audiobookshelf version
2.27.0
How are you running audiobookshelf?
Docker
What OS is your Audiobookshelf server hosted from?
Windows
If the issue is being seen in the UI, what browsers are you seeing the problem on?
None
Logs
Additional Notes
No response
@advplyr commented on GitHub (Aug 13, 2025):
This is only the case with m4b/mp4 files because of ffmpegs limitation on meta tags.
I'm not sure there is anything we can do about this without including another dependency. We already experimented with that with tone and is not likely to happen.
In my tests any re-encoding of an mp4 file with ffmpeg, even when copying the stream, will remove all meta tags that ffmpeg doesn't support.
The supported meta tags are here https://wiki.multimedia.cx/index.php/FFmpeg_Metadata
@ListerD000169 commented on GitHub (Aug 13, 2025):
Wow, thanks for the quick response! So I guess by another dependency you mean using something other then ffmpeg to just manage tags? Didn't realize that it was reencoding the file to update the tags, although that explains why it seems to take longer to process than if it were just updating the metadata.
Guess for now I'll just update the series info manually, and I'll also look into the API to see if I can pull the info that way to update the file metadata.
Thanks again for the fast response, and for the great tool. Audiobookshelf is awesome!
@nichwall commented on GitHub (Aug 13, 2025):
You can either use the API or the
metadata.jsonthat Audiobookshelf creates. This JSON file includes all of the metadata for the item (not including collection/playlist or user progress information) and is stored in/metadataby default. You can enable the server settings to store this metadata file in the same folder as your media items instead, but the metadata files are not moved automatically.The metadata file is created/updated for a book any time the Audiobookshelf metadata change. An easy way to move the metadata file to the media folder is to bulk add a temporary tag to your books, then delete the tag in the server settings.
@advplyr commented on GitHub (Aug 14, 2025):
I'm not sure if the technical term would be encoding since the streams aren't being touched but the m4b encoding tool uses the same metadata embed logic.
@ListerD000169 commented on GitHub (Aug 14, 2025):
@nichwall , Good point on the metadata.json file. That would allow for doing everything via the filesystem. Thanks!
@advplyr , encoding was the wrong term, but the process seems to be interacting with more than just the metadata. I tested, without backing up a file, and for a 1 gig m4b, the metadata embed took about 30 seconds to complete. It took about 6 seconds for a 150 meg file. Just an FYI. Thanks!
@ListerD000169 commented on GitHub (Aug 14, 2025):
Since it looks like this isn't a bug in audiobookshelf, but a "feature" of ffmpeg, I'm going to close the ticket. Thanks for all the info!