mirror of
https://github.com/advplyr/audiobookshelf.git
synced 2026-05-30 23:40:40 +02:00
[ISSUE]: 404 errors for author photos triggers crowdsec http-probing ban for new devices #2832
Assignees
adam (Adam Melkus)
Clear assignees
adam (Adam Melkus)
No Assignees
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: starred/audiobookshelf#2832
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @iconoclasthero on GitHub (Jun 7, 2025).
What happened?
One of my users got a new phone and ended up getting her IP banned by my fairly stock CrowdSec config watching NGINX logs. This was discussed on Discord: https://discord.com/channels/942908292873723984/942914154254176257/1378468432143585330
From the logs and the CrowdSec Discord, what triggered this was the 404 errors resulting from the paucity of available author images that were generated upon first attempting to populate the client's app.
What did you expect to happen?
This totally caught me by surprise...I didn't expect my user to get banned.
Steps to reproduce the issue
/var/logs/nginx/abs-error.log; /var/logs/nginx/abs-access.log)sudo cscli decisions listAudiobookshelf version
v.2.23.0
How are you running audiobookshelf?
Docker
What OS is your Audiobookshelf server hosted from?
Linux
If the issue is being seen in the UI, what browsers are you seeing the problem on?
None
Logs
Additional Notes
From the CrowdSec Discord, this also happens with NextCloud:
https://discord.com/channels/921520481163673640/922593826986672178/1378512972686557264
and the suggestion was made that the number of 404 errors returned in such scenarios could be fixed to prevent triggering this http-probing ban: https://discord.com/channels/921520481163673640/922593826986672178/1378785541100802228
However, I wanted to post this here so that if someone else is having problems they can find the solution that worked for me suggested here: https://discord.com/channels/921520481163673640/922593826986672178/1380105164853088346
of
saved as
PATH_TO_CROWDSEC_CONFIG/parsers/s02-enrich/audiobookshelf-whitelist.yaml@Vito0912 commented on GitHub (Jun 7, 2025):
That is not a bug or issue with ABS.
If there is no image for an author, a 404 error will occur, which is the correct response for a missing file.
The website only tries to load the image if the item has a cover path (afaik -> https://github.com/advplyr/audiobookshelf/blob/4a3eb7727beab6f9bd859a351dfcf0dd8342212b/client/components/covers/AuthorImage.vue#L59).
Maybe at that time there was a problem and the files were no longer available to your server (e.g. wrong mounts, deleted manually etc. etc.).
You can check this by looking at the network activity in your browser and seeing if there are any 404 errors. But even if, 404 are totally normal "errors" to return in this case and this is a result in the strictness you setup crowdsec
Edit: Also the app checks for it https://github.com/advplyr/audiobookshelf-app/blob/d26403c8004fcc06509d87ec8ad6b31ac7fb7322/components/covers/AuthorImage.vue#L57
@nichwall commented on GitHub (Jun 8, 2025):
From further discussion in Discord, this was caused by a number of author images not existing in the
/metadata/authorsdirectory (where author images are stored) but paths to these missing files existed in the ABS database.A cached version of some images were available under
/metadata/cache, which made it appear that some images existed due to the same size already being generated. The 404 is correct due to the original image files not existing.@iconoclasthero commented on GitHub (Jun 16, 2025):
Yes, I was able to fix the author image issues and that should resolve it and I wasn't able to unlabel it a bug after I hit submit the first time. Like I said, I was adding it more for future reference than anything.