mirror of
https://github.com/advplyr/audiobookshelf.git
synced 2026-05-30 23:40:40 +02:00
[Bug]: API progress failed ! set "finishedAt" to today and not to value of parameter #2645
Assignees
adam (Adam Melkus)
Clear assignees
adam (Adam Melkus)
No Assignees
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: starred/audiobookshelf#2645
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @Gru0810 on GitHub (Mar 10, 2025).
What happened?
I listening hundreds of audiobook in the past and i logged the the "finished at" in e seperate document.
I was able to transfer some of these information to ABS by using API Progress but in the current version 2.19.5 the API progress set always today as finished at:
This is my code and the correct statement (It works)
I let run a bulk load on 07.04.2024 for 630 Audiobookand all works fine with Version 2.8.0:
What did you expect to happen?
When I will set "finishedAt" to 02.03.2004" the "finishedAt" should be set to "02.03.2004" and not to "Today"
Steps to reproduce the issue
Audiobookshelf version
2.19.5
How are you running audiobookshelf?
Docker
What OS is your Audiobookshelf server hosted from?
Linux
If the issue is being seen in the UI, what browsers are you seeing the problem on?
None
Logs
Additional Notes
No response
@Vito0912 commented on GitHub (Mar 10, 2025):
This could be connected to https://github.com/advplyr/audiobookshelf/blob/master/server/models/MediaProgress.js#L186. When updating a progress that already exists, it does not pass the finishedAt parameter like it does here: https://github.com/advplyr/audiobookshelf/blob/master/server/models/User.js#L714.
But could also be that it needs the format like
2025-03-10T15:30:45.123Z. I am not that much into JS data structures.Like the passion for Excel VBA xD
@Gru0810 commented on GitHub (Mar 10, 2025):
It's not a wrong format. I hade to convert 2013-06-07 to 1370563200000 for using in HTTP request:
{"isFinished":true ,"startedAt": 1369958400000,"finishedAt": 1370563200000,"duration":21805.061223,"currentTime":21805.061223}
( based on : https://api.audiobookshelf.org/#create-update-media-progress)
And there is no existing Progress in ABS.
FYI : It's not MS Excel , I build a big master-App in MS Access ;)
@Vito0912 commented on GitHub (Mar 10, 2025):
Yes, I still believe that it has to do with progress that is not created but only modified. If I am back home I will test it a bit and make a PR if that’s the case. (Also not that the API Docs do not represent the current state of the endpoints. Most still are correct, but there are new/modified for some)
And how could I mix up access with Excel, oh no. But still the same pain shit editor xD
@nichwall commented on GitHub (Mar 10, 2025):
This is already fixed by https://github.com/advplyr/audiobookshelf/pull/3546
@Vito0912 commented on GitHub (Mar 10, 2025):
You are right. I did not see that PR. Still I created a PR to add this capability for doing it for books that already have a progress (My investigation was made on the main branch, so why this should still be valid)
@nichwall commented on GitHub (Mar 10, 2025):
Ah thanks, I didn't notice that was only for newly created progress