starred/audiobookshelf
1
0
Fork 0
mirror of https://github.com/advplyr/audiobookshelf.git synced 2026-05-30 23:40:40 +02:00
Code Issues 1.0k Packages Projects Releases 10 Wiki Activity

[Bug]: Accessibility Issues with Items that Expand, and Missing Labels #256

New Issue
Closed
opened 2026-04-24 23:02:28 +02:00 by adam · 2 comments
adam commented 2026-04-24 23:02:28 +02:00
Owner
Copy Link
Copy Source

Originally created by @duplaja on GitHub (Apr 3, 2022).

Describe the issue

Items that can expand when clicked, such as:

  • filter dropdown
  • sort dropdown
  • chapter selection from the player

are hard-coded with aria-expanded="true". This should be false when they are not opened up, and true when they are expanded.

In addition, these items are all missing properly accessible labels.

They are using the aria-labeledby attribute which is supposed to reference another element that has the correct label. However, these all are set as "listbox-label", which is not actually an element that exists on the page. If you want to label these directly, these should use aria-label="".

Steps to reproduce the issue

  1. Appears when using Audiobookshelf site with a screen reader of any sort.

Audiobookshelf version

v1.7.2

How are you running audiobookshelf?

Debian/PPA

Originally created by @duplaja on GitHub (Apr 3, 2022). ### Describe the issue Items that can expand when clicked, such as: * filter dropdown * sort dropdown * chapter selection from the player are hard-coded with aria-expanded="true". This should be false when they are not opened up, and true when they are expanded. In addition, these items are all missing properly accessible labels. They are using the aria-labeledby attribute which is supposed to reference another element that has the correct label. However, these all are set as "listbox-label", which is not actually an element that exists on the page. If you want to label these directly, these should use aria-label="<Name of Item>". ### Steps to reproduce the issue 1. Appears when using Audiobookshelf site with a screen reader of any sort. ### Audiobookshelf version v1.7.2 ### How are you running audiobookshelf? Debian/PPA
adam added the bug label 2026-04-24 23:02:28 +02:00
adam closed this issue 2026-04-24 23:02:28 +02:00
adam commented 2026-04-24 23:02:29 +02:00
Author
Owner
Copy Link
Copy Source

@duplaja commented on GitHub (Apr 3, 2022):

library-screen

This is the aria view of the library screen, for example. I've submitted a pull request that should address the add / remove at the bottom (those are the adjust the ebook cover size), and partially address the account label (need to probably remove "root", and the pull request replaces "person" with "User Account").

You can see that the Filter just shows as "All", with no other label, and as expanded even when it first loads. Similarly, "Sort" appears as "Title expand_less".

One good resource for (quickly) checking what a screenreader will see, as far as labels, is this Chrome extension

@duplaja commented on GitHub (Apr 3, 2022): ![library-screen](https://user-images.githubusercontent.com/20245408/161409833-8d8efe6c-4376-429f-bb53-65bb6bce9684.png) This is the aria view of the library screen, for example. I've submitted a pull request that should address the add / remove at the bottom (those are the adjust the ebook cover size), and partially address the account label (need to probably remove "root", and the pull request replaces "person" with "User Account"). You can see that the Filter just shows as "All", with no other label, and as expanded even when it first loads. Similarly, "Sort" appears as "Title expand_less". One good resource for (quickly) checking what a screenreader will see, as far as labels, is [this Chrome extension](https://chrome.google.com/webstore/detail/aria-devtools/dneemiigcbbgbdjlcdjjnianlikimpck/related?hl=en)
adam commented 2026-04-24 23:02:29 +02:00
Author
Owner
Copy Link
Copy Source

@github-actions[bot] commented on GitHub (Dec 30, 2024):

Fixed in v2.17.6.

@github-actions[bot] commented on GitHub (Dec 30, 2024): Fixed in [v2.17.6](https://github.com/advplyr/audiobookshelf/releases/tag/v2.17.6).
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
authentication
backlog
bug
chapter editor
config-issue
ebooks
encoding/embedding
enhancement
help wanted
listening sessions & progress
planned
possible plugin
progress sync
pull-request
Mirrored from GitHub Pull Request
 sorting/filtering/searching
unable to reproduce
upload
users & permissions
waiting
No Label bug
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam (Adam Melkus)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/audiobookshelf#256
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?