starred/audiobookshelf
1
0
Fork 0
mirror of https://github.com/advplyr/audiobookshelf.git synced 2026-05-30 23:40:40 +02:00
Code Issues 1.0k Packages Projects Releases 10 Wiki Activity

[Bug]: Incorrect authors / narrators list when there is a single word named author / narrator in the list #2548

New Issue
Closed
opened 2026-04-25 00:08:18 +02:00 by adam · 4 comments
adam commented 2026-04-25 00:08:18 +02:00
Owner
Copy Link
Copy Source

Originally created by @damajor on GitHub (Feb 5, 2025).

What happened?

I noticed an issue when an audiobook has multiple authors or narrators and one or more of them has a single word name.

Image

I used this library settings:

Image

Folder authors string is exactly the same inside the audiobook file.

And the results:

Image

Image

Image

Image

Well honestly I did not test with a single name author/narrator in middle of the list, but it seems that does not work if there is one in the first place of the author list. Maybe a side/edge effect ?

The fuzzy discovering logic is great BUT it should never be mandatory.

I think ABS should have a way to blindly use the defined metadata.

  • Having a configuration flag to disable it per library can be a solution
  • Having a authors/narrators separator that automatically disable fuzzy discover is also a good idea

What did you expect to happen?

Perfect match of defined authors & narrators in metadata or on path.

Steps to reproduce the issue

Check screenshots.

Audiobookshelf version

v2.19.0

How are you running audiobookshelf?

Docker

What OS is your Audiobookshelf server hosted from?

Linux

If the issue is being seen in the UI, what browsers are you seeing the problem on?

Other (list in "Additional Notes" box)

Logs

Additional Notes

Podman is used to run ABS in a rootless container.

Originally created by @damajor on GitHub (Feb 5, 2025). ### What happened? I noticed an issue when an audiobook has multiple authors or narrators and one or more of them has a single word name. ![Image](https://github.com/user-attachments/assets/5f59d136-a803-4e70-82b7-b4354a7e34a5) I used this library settings: ![Image](https://github.com/user-attachments/assets/bece7e4c-11d1-4d22-97a4-0404dcfe6a4f) Folder authors string is exactly the same inside the audiobook file. And the results: ![Image](https://github.com/user-attachments/assets/fe3a0aa8-3857-4c04-9689-58d0ddc6efdc) ![Image](https://github.com/user-attachments/assets/ac398112-c956-4b08-b541-726864f574b4) ![Image](https://github.com/user-attachments/assets/b6047ada-fdbe-4b1d-8fdf-ba83d00ae1af) ![Image](https://github.com/user-attachments/assets/65b3b54a-6c05-4300-b513-9d612aaabec5) Well honestly I did not test with a single name author/narrator in middle of the list, but it seems that does not work if there is one in the first place of the author list. Maybe a side/edge effect ? The fuzzy discovering logic is great BUT it should never be mandatory. I think ABS should have a way to blindly use the defined metadata. - Having a configuration flag to disable it per library can be a solution - Having a authors/narrators separator that automatically disable fuzzy discover is also a good idea ### What did you expect to happen? Perfect match of defined authors & narrators in metadata or on path. ### Steps to reproduce the issue Check screenshots. ### Audiobookshelf version v2.19.0 ### How are you running audiobookshelf? Docker ### What OS is your Audiobookshelf server hosted from? Linux ### If the issue is being seen in the UI, what browsers are you seeing the problem on? Other (list in "Additional Notes" box) ### Logs ```shell ``` ### Additional Notes Podman is used to run ABS in a rootless container.
adam added the bug label 2026-04-25 00:08:18 +02:00
adam closed this issue 2026-04-25 00:08:18 +02:00
adam commented 2026-04-25 00:08:18 +02:00
Author
Owner
Copy Link
Copy Source

@advplyr commented on GitHub (Feb 6, 2025):

I fixed the bug where if you aren't using commas at all it was still checking for "last, first" format in names.

There is a lot more that can be done here but I got it started by including a unit test for name parsing https://github.com/advplyr/audiobookshelf/blob/5e5a604d0332f07c18ac73b45fe8b3681b9a05cc/test/server/utils/parsers/parseNameString.test.js

We can also consider a library setting in the future to optimize the parser for specific use-cases but before doing that the parser should be refactored.

@advplyr commented on GitHub (Feb 6, 2025): I fixed the bug where if you aren't using commas at all it was still checking for "last, first" format in names. There is a lot more that can be done here but I got it started by including a unit test for name parsing https://github.com/advplyr/audiobookshelf/blob/5e5a604d0332f07c18ac73b45fe8b3681b9a05cc/test/server/utils/parsers/parseNameString.test.js We can also consider a library setting in the future to optimize the parser for specific use-cases but before doing that the parser should be refactored.
adam commented 2026-04-25 00:08:18 +02:00
Author
Owner
Copy Link
Copy Source

@advplyr commented on GitHub (Feb 6, 2025):

Also this issue only happens because the single word name is listed first.

@advplyr commented on GitHub (Feb 6, 2025): Also this issue only happens because the single word name is listed first.
adam commented 2026-04-25 00:08:18 +02:00
Author
Owner
Copy Link
Copy Source

@damajor commented on GitHub (Feb 6, 2025):

Awesome.

@damajor commented on GitHub (Feb 6, 2025): Awesome.
adam commented 2026-04-25 00:08:19 +02:00
Author
Owner
Copy Link
Copy Source

@github-actions[bot] commented on GitHub (Feb 12, 2025):

Fixed in v2.19.1.

@github-actions[bot] commented on GitHub (Feb 12, 2025): Fixed in [v2.19.1](https://github.com/advplyr/audiobookshelf/releases/tag/v2.19.1).
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
authentication
backlog
bug
chapter editor
config-issue
ebooks
encoding/embedding
enhancement
help wanted
listening sessions & progress
planned
possible plugin
progress sync
pull-request
Mirrored from GitHub Pull Request
 sorting/filtering/searching
unable to reproduce
upload
users & permissions
waiting
No Label bug
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam (Adam Melkus)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/audiobookshelf#2548
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?