mirror of
https://github.com/advplyr/audiobookshelf.git
synced 2026-05-30 23:40:40 +02:00
Request: Turn Off Automatically Empty Trash #25
Closed
opened 2026-04-24 22:56:37 +02:00 by adam
·
11 comments
No Branch/Tag Specified
master
book_tags_genres_dedupe
episode_download_fallback
Issue-4540-SortBy-StartedDate-and-FinishedDate
episode_meta_tagging
fix_authorize_race_condition
redirect_transcode_requests
progress_updated_sort
fix_ereader_socket_event
fix_change_empty_root_password
fix_podcast_session_track_index
fix_set_token
session_modal_user
localize_durations
fix_oidc_create_user
jwt_auth_refactor
fix_scanner_deleting_single_file_books
fix_mediaprogress_updatedat_2
experimental_next_client
podcast_episode_duration
episode-timestamps-clickable
book_author_secondary_sort_title
podcast_useragents
pathexists_user_access
fix_pathexists_join
book_author_secondary_sort
clean_duplicate_mediaprogress
sanitize_html_description
trix_prevent_attachments
check_path_api_fix
fix_mediaprogress_updatedat
increase_express_json_limit
fix_dockerfile_nunicode
search_episodes
audiobook_tools_update
episode_secondary_sorts
hls_stream_url_update
new_session_track_endpoint
audiobook_tools_enhancements
watcher_rescans_update
player_track_tooltip
fix_exclude_prefixes_crash
socket_item_events
fix_podcast_episode_scanner_promise
new_stats_controller
count_cache_for_userpermissions
parsing-opf-v3
validate_migration_files
fix-quick-match-all-crash
fix-chapter-end-sleep-timer
stringify_sequelize_query
remove-col-ambiguity
fix_next_prev_edit_description
details_trim_whitespace
fix_content_url_basepath
fix_logger_fatal
progress_bar_visibility
batch-edit-populate-map-details
feed_generator_updates
bookmark-modal-updates
migrate-library-item-in-scanner
migrate-new-library-items
migrate-podcasts-new-library-item-2
migrate-podcasts-new-library-item
fix-remove-episode-from-playlist
playback-session-use-new-library-item
refactor-library-item
fix-heatmap-caption
feed-episodes-upsert
share-media-player-media-session-api
remove-old-playlist
remove_old_collection_object
plugin-implementation-demo
feed_migration
refactor-feeds-from-item
fix_remove_authors_no_books
v2.17.3-fk-constraints-migration
migrations-first-upgrade
sqlite_2
feature/nuxt-target-server
waveform
sqlite
playlists
video
v2.35.1
v2.35.0
v2.34.0
v2.33.2
v2.33.1
v2.33.0
v2.32.1
v2.32.0
v2.31.0
v2.30.0
v2.29.0
v2.28.0
v2.27.0
v2.26.3
v2.26.2
v2.26.1
v2.26.0
v2.25.1
v2.25.0
v2.24.0
v2.23.0
v2.22.0
v2.21.0
v2.20.0
v2.19.5
v2.19.4
v2.19.3
v2.19.2
v2.19.1
v2.19.0
v2.18.1
v2.18.0
v2.17.7
v2.17.6
v2.17.5
v2.17.4
v2.17.3
v2.17.2
v2.17.1
v2.17.0
v2.16.2
v2.16.1
v2.16.0
v2.15.1
v2.15.0
v2.14.0
v2.13.4
v2.13.3
v2.13.2
v2.13.1
v2.13.0
v2.12.3
v2.12.2
v2.12.1
v2.12.0
v2.11.0
v2.10.1
v2.10.0
v2.9.0
v2.8.1
v2.8.0
v2.7.2
v2.7.1
v2.7.0
v2.6.0
v2.5.0
v2.4.4
v2.4.3
v2.4.2
v2.4.1
v2.4.0
v2.3.5
v2.3.4
v2.3.3
v2.3.2
v2.3.1
v2.3.0
v2.2.23
v2.2.22
v2.2.21
v2.2.20
v2.2.19
v2.2.18
v2.2.17
v2.2.16
v2.2.15
v2.2.14
v2.2.13
v2.2.12
v2.2.11
v2.2.10
v2.2.9
v2.2.8
v2.2.7
v2.2.6
v2.2.5
v2.2.4
v2.2.3
v2.2.2
v2.2.1
v2.2.0
v2.1.5
v2.1.4
v2.1.3
v2.1.2
v2.1.1
v2.1.0
v2.0.24
v2.0.23
v2.0.22
v2.0.21
v2.0.20
v2.0.19
v2.0.18
v2.0.17
v2.0.16
v2.0.15
v2.0.14
v2.0.13
v2.0.12
v2.0.11
v2.0.10
v2.0.9
v2.0.8
v2.0.7
v2.0.6
v2.0.5
v2.0.4
v2.0.3
v2.0.2
v2.0.1
v1.7.2
v1.7.1
v1.7.0
v1.6.0
v1.5.5
v1.5.0
v1.4.11
v1.4.9
v1.4.7
v1.4.6
v1.4.4
v1.4.2
v1.4.0
v1.4.1
v1.3.4
v1.3.3
v1.3.1
v1.2.8
v1.2.6
v1.2.5
v1.2.4
v1.2.1
v1.1.15
v1.1.14
v1.1.13
v1.1.12
v1.1.11
v1.1.10
v1.1.9
v1.1.8
v1.0.0
0.9.61-beta.0
0.9.61-beta
Labels
Clear labels
authentication
backlog
bug
chapter editor
config-issue
ebooks
encoding/embedding
enhancement
help wanted
listening sessions & progress
planned
possible plugin
progress sync
pull-request
sorting/filtering/searching
unable to reproduce
upload
users & permissions
waiting
Mirrored from GitHub Pull Request
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
adam (Adam Melkus)
Clear assignees
No Assignees
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: starred/audiobookshelf#25
Reference in New Issue
Block a user
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @Budlyte on GitHub (Sep 17, 2021).
Anyone using this with remote mounted storage will likely get frustrated if they start up their machine and the remote mount doesn't come up, then the scanner can't find the files so it removes the book from the library and then pairs it as something new once reconnected.
Please add an option to turn off the Automatically Empty Trash on scan in the Settings.
@advplyr commented on GitHub (Sep 17, 2021):
Good point. Instead of automatically removing items it should flag them as having missing files, similar to other media platforms.
@advplyr commented on GitHub (Sep 18, 2021):
This update warrants a bit of an explanation.
As of
v1.1.12it functions like this:@Budlyte commented on GitHub (Sep 18, 2021):
Awesome. I'll test it later by moving a directory or something. I know this kind of thing drove me nuts and almost made me quit Ubooquity back when I used it and also ran a NAS.
How is the trash emptied now? Is there a button to force it and clear some memory?
Also, what file should I copy to backup the db? Or I'll just backup the whole container once/week maybe.
@Budlyte commented on GitHub (Sep 22, 2021):
Alright, so to test I'm moving an author to a temp folder. Everything in the system is hardlinks, so the ID shouldn't be changing, correct? Either I'm mistaken or the system doesn't preserve listening progress through the missing and rediscovery.
Marked it read

Move it out, Scan, and get the 1 missing

Move it back, file system still shows it hasn't been modified in over a year

Next scan shows everything is there.

Reading status is reset though.

[2021-09-22T19:22:23.616Z] INFO: [Server] Starting Scan
[2021-09-22T19:22:24.121Z] INFO: [Scanner] Audiobook "A Rational Zombie" is missing
[2021-09-22T19:22:24.927Z] INFO: [Scanned] Finished | 0 added | 0 updated | 0 removed | 1 missing | elapsed: 0:01
[2021-09-22T19:22:24.927Z] INFO: [Server] Scan complete
[2021-09-22T19:22:24.935Z] INFO: [Server] 2 Files Changed
[2021-09-22T19:22:25.120Z] INFO: [Server] Files changed result [ 3 ]
[2021-09-22T19:22:50.911Z] INFO: [Server] 2 Files Changed
[2021-09-22T19:22:50.992Z] INFO: [Scanner] Audiobook "A Rational Zombie" Scanned (380 MB) [13 hr 57 min]
[2021-09-22T19:22:50.996Z] INFO: [Server] Files changed result [ 1 ]
[2021-09-22T19:24:02.512Z] INFO: [Server] Starting Scan
[2021-09-22T19:24:03.648Z] INFO: [Scanned] Finished | 0 added | 0 updated | 0 removed | 0 missing | elapsed: 0:01
[2021-09-22T19:24:03.648Z] INFO: [Server] Scan complete
@advplyr commented on GitHub (Sep 24, 2021):
I just tested this and the audio progress for me is not changed. Something strange is happening with the inode values your OS is assigning.
I think if we can get to the bottom of that, then we can solve this issue and the other one for you.
--
On the topic of backups:
I've been thinking on this. Now that covers will start to be stored locally, a system for backups becomes more important. I'm not sure how other media servers are handling this yet, so I'm going to look into that.
In the meantime you can do a full backup of the database by copying this directory
user/appdata/audiobookshelf/config/, that directory will have 3 folders foraudioooks,settings, andusers.@Budlyte commented on GitHub (Sep 24, 2021):
Yeah, something's going on. Maybe it's permissions, I don't know yet, but I'm not terribly worried about it since my system is all local storage. I just know that others use NASs, running stuff on RPis and whatnot, and if things are trashed whenever a reboot occurs it can be a huge pain.
For backups, I just did the Plugin: CA Backup / Restore Appdata on Unraid. It's making a weekly backup of select containers into my array. Plenty of space in there, especially for <50GB of containers.
@advplyr commented on GitHub (Sep 25, 2021):
I'm not sure I understand what you mean.
Are you using the original files for your audiobooks, or are you using symlinks?
@Budlyte commented on GitHub (Sep 25, 2021):
I'm using the actual files.
Which part was confusing though? Maybe I can clarify that portion.
@advplyr commented on GitHub (Sep 26, 2021):
What do you mean by
my system is all local storage?Also,
I just know that others use NASs, because aren't you also using a NAS since you are running Unraid?@Budlyte commented on GitHub (Sep 26, 2021):
Hmm, I forgot NASs these days can run docker and things, but the support is usually questionable.
I used to run a windows server, to host my programs, with my TBs of data stored in a Synology NAS. These days it's all in one physical machine running Unraid, with my HDDs connected to the same motherboard as the OS running the programs accessing them, so I don't consider it a NAS.
@Budlyte commented on GitHub (Sep 26, 2021):
I'm gonna close this, since it looks like the progress tracking is a "me" issue and everything else has been added.
Great job, as always!