mirror of
https://github.com/advplyr/audiobookshelf.git
synced 2026-05-30 23:40:40 +02:00
[Enhancement]: Attempt download over https, even if url is given as http in feed #2477
Assignees
adam (Adam Melkus)
Clear assignees
adam (Adam Melkus)
No Assignees
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: starred/audiobookshelf#2477
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @ImmanuelMc on GitHub (Jan 10, 2025).
Type of Enhancement
Server Backend
Describe the Feature/Enhancement
Attempt to download podcast episodes via https when the url is given as http. And fallback to http if that fails.
Why would this be helpful?
On a few long running rss feeds I am subscribed to, old links were never updated to https, but server security policy must have changed to refuse http connections. This is technically an issue with the feed, but if there isn't a concern with attempting https connections, it would allow continuing to download old episodes even if the feed is not fixed.
Future Implementation (Screenshot)
This isn't a ui suggestion.
Audiobookshelf Server Version
2.17.7
Current Implementation (Screenshot)
No response
@advplyr commented on GitHub (Jan 10, 2025):
You can change the feed URL of the podcast then use the quick match all episodes feature in the context menu of the episode list
@ImmanuelMc commented on GitHub (Jan 11, 2025):
I have changed the feed URL. Inside the feed, links to older episodes point to http://feeds.soundcloud.com, newer episodes point to https://feeds.soundcloud.com . The feed url is https://www.filmreroll.com/?feed=podcast . It switches from http to https at episode 81. I have contacted them about the issue, so they may update the urls in the meantime, but I have run into this issue on other feeds with old content.
When navigating to the old download link in a browser it is automatically redirected to https, which seems like what is supposed to happen with HSTS, but it is not my field so I am not sure.
@advplyr commented on GitHub (Jan 15, 2025):
I'm able to download the oldest episodes and the newest episodes for that podcast fine. Are you getting an error when you download?
@ImmanuelMc commented on GitHub (Jan 16, 2025):
This appears to be an issue with my network. In testing with wget/curl I am getting connection refused instead of a 301 response, from every site using 301 redirects to https that I have tried, from multiple computers on my network using different OSes. The same wget/curl commands do work when tested on machines not on my network. So I think this can be closed.