starred/audiobookshelf
1
0
Fork 0
mirror of https://github.com/advplyr/audiobookshelf.git synced 2026-05-30 23:40:40 +02:00
Code Issues 1.0k Packages Projects Releases 10 Wiki Activity

[Bug]: em spaces are not preserved in chapter editor #2422

New Issue
Open
opened 2026-04-25 00:06:57 +02:00 by adam · 5 comments
adam commented 2026-04-25 00:06:57 +02:00
Owner
Copy Link
Copy Source

Originally created by @Linden-Ryuujin on GitHub (Dec 15, 2024).

What happened?

If you prefix a chapter name with em spaces they are discarded on save.
em spaces are respected in m4b files, chapter file formats and in the audiobookself player (I use them to indent some chapters, particular if a book container multiple "parts").

e.g.

Part 1: The Start
  Chapter 1: Inside part 1

What did you expect to happen?

Em spaces should not be removed. Possibly all white space could be preserved? The audiobookself chapter format doesn't seem to have the same limitations as M4B (as fully quoted strings are used in the new json meta data files).

Steps to reproduce the issue

  1. Open chapter editor
  2. Begin chapter name with one or more em spaces e.g.   Chapter 1: Inside part 1
  3. Save Changes
  4. Check chapters and em spaces have been discarded.

Audiobookshelf version

v2.17.1

How are you running audiobookshelf?

Docker

What OS is your Audiobookshelf server hosted from?

Linux

If the issue is being seen in the UI, what browsers are you seeing the problem on?

Firefox

Logs

No response

Additional Notes

No response

Originally created by @Linden-Ryuujin on GitHub (Dec 15, 2024). ### What happened? If you prefix a chapter name with em spaces they are discarded on save. em spaces are respected in m4b files, chapter file formats and in the audiobookself player (I use them to indent some chapters, particular if a book container multiple "parts"). e.g. ``` Part 1: The Start   Chapter 1: Inside part 1 ``` ### What did you expect to happen? Em spaces should not be removed. Possibly all white space could be preserved? The audiobookself chapter format doesn't seem to have the same limitations as M4B (as fully quoted strings are used in the new json meta data files). ### Steps to reproduce the issue 1. Open chapter editor 2. Begin chapter name with one or more em spaces e.g. `  Chapter 1: Inside part 1` 3. Save Changes 4. Check chapters and em spaces have been discarded. ### Audiobookshelf version v2.17.1 ### How are you running audiobookshelf? Docker ### What OS is your Audiobookshelf server hosted from? Linux ### If the issue is being seen in the UI, what browsers are you seeing the problem on? Firefox ### Logs _No response_ ### Additional Notes _No response_
adam added the bugchapter editor labels 2026-04-25 00:06:57 +02:00
adam commented 2026-04-25 00:06:57 +02:00
Author
Owner
Copy Link
Copy Source

@pwinnski commented on GitHub (Dec 16, 2024):

I am amused by how closely in time this follows #3720, although they are about different metadata.

@pwinnski commented on GitHub (Dec 16, 2024): I am amused by how closely in time this follows #3720, although they are about different metadata.
adam commented 2026-04-25 00:06:58 +02:00
Author
Owner
Copy Link
Copy Source

@advplyr commented on GitHub (Dec 21, 2024):

Hmm I see what you mean but I wonder if most users would prefer to trim the whitespace. Usually when I see extra whitespace at the end of the string it's because some people instinctively press the spacebar after a word. Trimming trailing whitespace but leaving the leading whitespace could be the middle ground

@advplyr commented on GitHub (Dec 21, 2024): Hmm I see what you mean but I wonder if most users would prefer to trim the whitespace. Usually when I see extra whitespace at the end of the string it's because some people instinctively press the spacebar after a word. Trimming trailing whitespace but leaving the leading whitespace could be the middle ground
adam commented 2026-04-25 00:06:58 +02:00
Author
Owner
Copy Link
Copy Source

@pwinnski commented on GitHub (Dec 21, 2024):

Is there any harm in preserving all white space? Yes, there might be an unintentional extra space at the end, but people who care about such things could manually remove them, while people who don't care can leave them.

@pwinnski commented on GitHub (Dec 21, 2024): Is there any harm in preserving all white space? Yes, there might be an unintentional extra space at the end, but people who care about such things could manually remove them, while people who don't care can leave them.
adam commented 2026-04-25 00:06:58 +02:00
Author
Owner
Copy Link
Copy Source

@advplyr commented on GitHub (Dec 21, 2024):

Not really. The only thing I can think of is if the chapter title is only white space.

@advplyr commented on GitHub (Dec 21, 2024): Not really. The only thing I can think of is if the chapter title is only white space.
adam commented 2026-04-25 00:06:58 +02:00
Author
Owner
Copy Link
Copy Source

@ZLoth commented on GitHub (Feb 6, 2025):

This issue follows closely with the (rejected) feature request https://github.com/advplyr/audiobookshelf/issues/3421 in which a chapter title can be bolded/italicized/underlined to highlight different sections of the book, or for this user's case, indented. This can be part of the metadata.json file:

    {
      "id": 1,
      "start": 299.9673,
      "end": 2029.537856,
      "title": "Chapter 1",
      "format": "bold, indent"
    },
@ZLoth commented on GitHub (Feb 6, 2025): This issue follows closely with the (rejected) feature request https://github.com/advplyr/audiobookshelf/issues/3421 in which a chapter title can be bolded/italicized/underlined to highlight different sections of the book, or for this user's case, indented. This can be part of the metadata.json file: ``` { "id": 1, "start": 299.9673, "end": 2029.537856, "title": "Chapter 1", "format": "bold, indent" }, ```
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
authentication
backlog
bug
chapter editor
config-issue
ebooks
encoding/embedding
enhancement
help wanted
listening sessions & progress
planned
possible plugin
progress sync
pull-request
Mirrored from GitHub Pull Request
 sorting/filtering/searching
unable to reproduce
upload
users & permissions
waiting
No Label bug chapter editor
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam (Adam Melkus)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/audiobookshelf#2422
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?