starred/audiobookshelf
1
0
Fork 0
mirror of https://github.com/advplyr/audiobookshelf.git synced 2026-05-30 23:40:40 +02:00
Code Issues 1.0k Packages Projects Releases 10 Wiki Activity

[Bug]: Migration can crash if migrationsMeta table exists but is empty #2346

New Issue
Closed
opened 2026-04-25 00:06:19 +02:00 by adam · 2 comments
adam commented 2026-04-25 00:06:19 +02:00
Owner
Copy Link
Copy Source

Originally created by @nichwall on GitHub (Nov 7, 2024).

What happened?

A user in Discord reported a crash when upgrading from server version 2.12.3 to 2.16.2. Upon request, they tried upgrading to a few different versions, including 2.13.3 and 2.14.0. They were able to upgrade to all versions before 2.14.0, but the migration failed and crashed for all servers version at 2.14.0 and above.

The user provided their database to me and I was able to reproduce the crash. Upon investigation, it looks like they somehow got an empty migrationsMeta table. I am not sure if this is a result of the failed upgrade to 2.16.2 or something else.

What did you expect to happen?

Migration to be handled when the table is empty. It appears to be a problem with how isDatabaseNew is handled. Instead of only checking if the table exists, we should also check that the version row exists.

https://github.com/advplyr/audiobookshelf/blob/0c244cbf952efd8e0b63a1c73d93ea4584bc7ff4/server/managers/MigrationManager.js#L190-L217

Steps to reproduce the issue

  1. Create migrationsMeta table in an existing database with no rows
  2. Attempt to upgrade to a version greater than or equal to 2.14.0

Audiobookshelf version

v2.16.2

How are you running audiobookshelf?

Built from source

What OS is your Audiobookshelf server hosted from?

Linux

If the issue is being seen in the UI, what browsers are you seeing the problem on?

None

Logs

[2024-11-06 21:53:19.790] ERROR: [Database] Failed to run migrations TypeError: Cannot read properties of undefined (reading 'version')
    at MigrationManager.fetchVersionsFromDatabase (/home/chell/data/Documents/git/audiobookshelf/server/managers/MigrationManager.js:178:14)
    at async MigrationManager.init (/home/chell/data/Documents/git/audiobookshelf/server/managers/MigrationManager.js:46:5)
    at async Database.init (/home/chell/data/Documents/git/audiobookshelf/server/Database.js:183:7)
    at async Server.init (/home/chell/data/Documents/git/audiobookshelf/server/Server.js:128:5)
    at async Server.start (/home/chell/data/Documents/git/audiobookshelf/server/Server.js:191:5)
[2024-11-06 21:53:19.793] FATAL: [Server] Unhandled rejection: Error: Database migration failed
    at Database.init (/home/chell/data/Documents/git/audiobookshelf/server/Database.js:187:13)
    at async Server.init (/home/chell/data/Documents/git/audiobookshelf/server/Server.js:128:5)
    at async Server.start (/home/chell/data/Documents/git/audiobookshelf/server/Server.js:191:5) 
promise: Promise {
  <rejected> Error: Database migration failed
      at Database.init (/home/chell/data/Documents/git/audiobookshelf/server/Database.js:187:13)
      at async Server.init (/home/chell/data/Documents/git/audiobookshelf/server/Server.js:128:5)
      at async Server.start (/home/chell/data/Documents/git/audiobookshelf/server/Server.js:191:5)
}

Additional Notes

No response

Originally created by @nichwall on GitHub (Nov 7, 2024). ### What happened? A user in Discord reported a crash when upgrading from server version `2.12.3` to `2.16.2`. Upon request, they tried upgrading to a few different versions, including `2.13.3` and `2.14.0`. They were able to upgrade to all versions before `2.14.0`, but the migration failed and crashed for all servers version at `2.14.0` and above. The user provided their database to me and I was able to reproduce the crash. Upon investigation, it looks like they somehow got an empty `migrationsMeta` table. I am not sure if this is a result of the failed upgrade to `2.16.2` or something else. ### What did you expect to happen? Migration to be handled when the table is empty. It appears to be a problem with how `isDatabaseNew` is handled. Instead of only checking if the table exists, we should also check that the `version` row exists. https://github.com/advplyr/audiobookshelf/blob/0c244cbf952efd8e0b63a1c73d93ea4584bc7ff4/server/managers/MigrationManager.js#L190-L217 ### Steps to reproduce the issue 1. Create `migrationsMeta` table in an existing database with no rows 2. Attempt to upgrade to a version greater than or equal to `2.14.0` ### Audiobookshelf version v2.16.2 ### How are you running audiobookshelf? Built from source ### What OS is your Audiobookshelf server hosted from? Linux ### If the issue is being seen in the UI, what browsers are you seeing the problem on? None ### Logs ```shell [2024-11-06 21:53:19.790] ERROR: [Database] Failed to run migrations TypeError: Cannot read properties of undefined (reading 'version') at MigrationManager.fetchVersionsFromDatabase (/home/chell/data/Documents/git/audiobookshelf/server/managers/MigrationManager.js:178:14) at async MigrationManager.init (/home/chell/data/Documents/git/audiobookshelf/server/managers/MigrationManager.js:46:5) at async Database.init (/home/chell/data/Documents/git/audiobookshelf/server/Database.js:183:7) at async Server.init (/home/chell/data/Documents/git/audiobookshelf/server/Server.js:128:5) at async Server.start (/home/chell/data/Documents/git/audiobookshelf/server/Server.js:191:5) [2024-11-06 21:53:19.793] FATAL: [Server] Unhandled rejection: Error: Database migration failed at Database.init (/home/chell/data/Documents/git/audiobookshelf/server/Database.js:187:13) at async Server.init (/home/chell/data/Documents/git/audiobookshelf/server/Server.js:128:5) at async Server.start (/home/chell/data/Documents/git/audiobookshelf/server/Server.js:191:5) promise: Promise { <rejected> Error: Database migration failed at Database.init (/home/chell/data/Documents/git/audiobookshelf/server/Database.js:187:13) at async Server.init (/home/chell/data/Documents/git/audiobookshelf/server/Server.js:128:5) at async Server.start (/home/chell/data/Documents/git/audiobookshelf/server/Server.js:191:5) } ``` ### Additional Notes _No response_
adam added the bug label 2026-04-25 00:06:19 +02:00
adam closed this issue 2026-04-25 00:06:19 +02:00
adam commented 2026-04-25 00:06:20 +02:00
Author
Owner
Copy Link
Copy Source

@ggladchun-nasuni commented on GitHub (Nov 7, 2024):

Confirming @nichwall root cause. Manually dropped migrationData and was able to upgrade

@ggladchun-nasuni commented on GitHub (Nov 7, 2024): Confirming @nichwall root cause. Manually dropped `migrationData` and was able to upgrade
adam commented 2026-04-25 00:06:20 +02:00
Author
Owner
Copy Link
Copy Source

@github-actions[bot] commented on GitHub (Nov 17, 2024):

Fixed in v2.17.0.

@github-actions[bot] commented on GitHub (Nov 17, 2024): Fixed in [v2.17.0](https://github.com/advplyr/audiobookshelf/releases/tag/v2.17.0).
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
authentication
backlog
bug
chapter editor
config-issue
ebooks
encoding/embedding
enhancement
help wanted
listening sessions & progress
planned
possible plugin
progress sync
pull-request
Mirrored from GitHub Pull Request
 sorting/filtering/searching
unable to reproduce
upload
users & permissions
waiting
No Label bug
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam (Adam Melkus)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/audiobookshelf#2346
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?